* [PATCH v2 1/2] net: phy: at803x: dont inline helpers
@ 2019-02-18 10:18 Vinod Koul
2019-02-18 10:18 ` [PATCH v2 2/2] net: phy: at803x: disable delay only for RGMII mode Vinod Koul
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Vinod Koul @ 2019-02-18 10:18 UTC (permalink / raw)
To: David S Miller
Cc: linux-arm-msm, Bjorn Andersson, Vinod Koul, netdev,
Niklas Cassel, Andrew Lunn, Florian Fainelli, Nori, Sekhar,
Peter Ujfalusi, Marc Gonzalez
Some helpers were inlined, but makes more sense to allow compiler
to do the right optiomazations instead, so remove inline for
at803x_disable_rx_delay() and at803x_disable_tx_delay()
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/net/phy/at803x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index 8ff12938ab47..c6e7d800fd7a 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -110,13 +110,13 @@ static int at803x_debug_reg_mask(struct phy_device *phydev, u16 reg,
return phy_write(phydev, AT803X_DEBUG_DATA, val);
}
-static inline int at803x_disable_rx_delay(struct phy_device *phydev)
+static int at803x_disable_rx_delay(struct phy_device *phydev)
{
return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_0,
AT803X_DEBUG_RX_CLK_DLY_EN, 0);
}
-static inline int at803x_disable_tx_delay(struct phy_device *phydev)
+static int at803x_disable_tx_delay(struct phy_device *phydev)
{
return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_5,
AT803X_DEBUG_TX_CLK_DLY_EN, 0);
--
2.20.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 2/2] net: phy: at803x: disable delay only for RGMII mode
2019-02-18 10:18 [PATCH v2 1/2] net: phy: at803x: dont inline helpers Vinod Koul
@ 2019-02-18 10:18 ` Vinod Koul
2019-02-18 10:28 ` Niklas Cassel
2019-02-18 14:40 ` Peter Ujfalusi
2019-02-18 10:28 ` [PATCH v2 1/2] net: phy: at803x: dont inline helpers Niklas Cassel
2019-02-19 0:28 ` David Miller
2 siblings, 2 replies; 9+ messages in thread
From: Vinod Koul @ 2019-02-18 10:18 UTC (permalink / raw)
To: David S Miller
Cc: linux-arm-msm, Bjorn Andersson, Vinod Koul, netdev,
Niklas Cassel, Andrew Lunn, Florian Fainelli, Nori, Sekhar,
Peter Ujfalusi, Marc Gonzalez
Per "Documentation/devicetree/bindings/net/ethernet.txt" RGMII mode
should not have delay in PHY wheras RGMII_ID and RGMII_RXID/RGMII_TXID
can have delay in phy.
So disable the delay only for RGMII mode and enable for other modes.
Also treat the default case as disabled delays.
Fixes: cd28d1d6e52e: ("net: phy: at803x: Disable phy delay for RGMII mode")
Reported-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/net/phy/at803x.c | 47 ++++++++++++++++++++++++++++++----------
1 file changed, 36 insertions(+), 11 deletions(-)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index c6e7d800fd7a..dc1b13f7fc12 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -110,6 +110,18 @@ static int at803x_debug_reg_mask(struct phy_device *phydev, u16 reg,
return phy_write(phydev, AT803X_DEBUG_DATA, val);
}
+static int at803x_enable_rx_delay(struct phy_device *phydev)
+{
+ return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_0, 0,
+ AT803X_DEBUG_RX_CLK_DLY_EN);
+}
+
+static int at803x_enable_tx_delay(struct phy_device *phydev)
+{
+ return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_5, 0,
+ AT803X_DEBUG_TX_CLK_DLY_EN);
+}
+
static int at803x_disable_rx_delay(struct phy_device *phydev)
{
return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_0,
@@ -255,23 +267,36 @@ static int at803x_config_init(struct phy_device *phydev)
if (ret < 0)
return ret;
- if (phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID ||
- phydev->interface == PHY_INTERFACE_MODE_RGMII_ID ||
- phydev->interface == PHY_INTERFACE_MODE_RGMII) {
- ret = at803x_disable_rx_delay(phydev);
+ /* The hardware register default is RX and TX delay enabled, so lets
+ * first disable the RX and TX delays in phy and enable them based
+ * on the mode selected
+ */
+ ret = at803x_disable_rx_delay(phydev);
+ if (ret < 0)
+ return ret;
+ ret = at803x_disable_tx_delay(phydev);
+ if (ret < 0)
+ return ret;
+
+ if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID ||
+ phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID) {
+ /* If RGMII_ID or RGMII_RXID are specified enable RX delay,
+ * otherwise keep it disabled
+ */
+ ret = at803x_enable_rx_delay(phydev);
if (ret < 0)
return ret;
}
- if (phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID ||
- phydev->interface == PHY_INTERFACE_MODE_RGMII_ID ||
- phydev->interface == PHY_INTERFACE_MODE_RGMII) {
- ret = at803x_disable_tx_delay(phydev);
- if (ret < 0)
- return ret;
+ if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID ||
+ phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID) {
+ /* If RGMII_ID or RGMII_TXID are specified enable TX delay,
+ * otherwise keep it disabled
+ */
+ ret = at803x_enable_tx_delay(phydev);
}
- return 0;
+ return ret;
}
static int at803x_ack_interrupt(struct phy_device *phydev)
--
2.20.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] net: phy: at803x: dont inline helpers
2019-02-18 10:18 [PATCH v2 1/2] net: phy: at803x: dont inline helpers Vinod Koul
2019-02-18 10:18 ` [PATCH v2 2/2] net: phy: at803x: disable delay only for RGMII mode Vinod Koul
@ 2019-02-18 10:28 ` Niklas Cassel
2019-02-19 0:28 ` David Miller
2 siblings, 0 replies; 9+ messages in thread
From: Niklas Cassel @ 2019-02-18 10:28 UTC (permalink / raw)
To: Vinod Koul
Cc: David S Miller, linux-arm-msm, Bjorn Andersson, netdev,
Andrew Lunn, Florian Fainelli, Nori, Sekhar, Peter Ujfalusi,
Marc Gonzalez
On Mon, Feb 18, 2019 at 03:48:52PM +0530, Vinod Koul wrote:
> Some helpers were inlined, but makes more sense to allow compiler
> to do the right optiomazations instead, so remove inline for
> at803x_disable_rx_delay() and at803x_disable_tx_delay()
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> drivers/net/phy/at803x.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
> index 8ff12938ab47..c6e7d800fd7a 100644
> --- a/drivers/net/phy/at803x.c
> +++ b/drivers/net/phy/at803x.c
> @@ -110,13 +110,13 @@ static int at803x_debug_reg_mask(struct phy_device *phydev, u16 reg,
> return phy_write(phydev, AT803X_DEBUG_DATA, val);
> }
>
> -static inline int at803x_disable_rx_delay(struct phy_device *phydev)
> +static int at803x_disable_rx_delay(struct phy_device *phydev)
> {
> return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_0,
> AT803X_DEBUG_RX_CLK_DLY_EN, 0);
> }
>
> -static inline int at803x_disable_tx_delay(struct phy_device *phydev)
> +static int at803x_disable_tx_delay(struct phy_device *phydev)
> {
> return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_5,
> AT803X_DEBUG_TX_CLK_DLY_EN, 0);
> --
> 2.20.1
>
Reviewed-by: Niklas Cassel <niklas.cassel@linaro.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] net: phy: at803x: disable delay only for RGMII mode
2019-02-18 10:18 ` [PATCH v2 2/2] net: phy: at803x: disable delay only for RGMII mode Vinod Koul
@ 2019-02-18 10:28 ` Niklas Cassel
2019-02-18 14:40 ` Peter Ujfalusi
1 sibling, 0 replies; 9+ messages in thread
From: Niklas Cassel @ 2019-02-18 10:28 UTC (permalink / raw)
To: Vinod Koul
Cc: David S Miller, linux-arm-msm, Bjorn Andersson, netdev,
Andrew Lunn, Florian Fainelli, Nori, Sekhar, Peter Ujfalusi,
Marc Gonzalez
On Mon, Feb 18, 2019 at 03:48:53PM +0530, Vinod Koul wrote:
> Per "Documentation/devicetree/bindings/net/ethernet.txt" RGMII mode
> should not have delay in PHY wheras RGMII_ID and RGMII_RXID/RGMII_TXID
> can have delay in phy.
>
> So disable the delay only for RGMII mode and enable for other modes.
> Also treat the default case as disabled delays.
>
> Fixes: cd28d1d6e52e: ("net: phy: at803x: Disable phy delay for RGMII mode")
> Reported-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> drivers/net/phy/at803x.c | 47 ++++++++++++++++++++++++++++++----------
> 1 file changed, 36 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
> index c6e7d800fd7a..dc1b13f7fc12 100644
> --- a/drivers/net/phy/at803x.c
> +++ b/drivers/net/phy/at803x.c
> @@ -110,6 +110,18 @@ static int at803x_debug_reg_mask(struct phy_device *phydev, u16 reg,
> return phy_write(phydev, AT803X_DEBUG_DATA, val);
> }
>
> +static int at803x_enable_rx_delay(struct phy_device *phydev)
> +{
> + return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_0, 0,
> + AT803X_DEBUG_RX_CLK_DLY_EN);
> +}
> +
> +static int at803x_enable_tx_delay(struct phy_device *phydev)
> +{
> + return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_5, 0,
> + AT803X_DEBUG_TX_CLK_DLY_EN);
> +}
> +
> static int at803x_disable_rx_delay(struct phy_device *phydev)
> {
> return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_0,
> @@ -255,23 +267,36 @@ static int at803x_config_init(struct phy_device *phydev)
> if (ret < 0)
> return ret;
>
> - if (phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID ||
> - phydev->interface == PHY_INTERFACE_MODE_RGMII_ID ||
> - phydev->interface == PHY_INTERFACE_MODE_RGMII) {
> - ret = at803x_disable_rx_delay(phydev);
> + /* The hardware register default is RX and TX delay enabled, so lets
> + * first disable the RX and TX delays in phy and enable them based
> + * on the mode selected
> + */
> + ret = at803x_disable_rx_delay(phydev);
> + if (ret < 0)
> + return ret;
> + ret = at803x_disable_tx_delay(phydev);
> + if (ret < 0)
> + return ret;
> +
> + if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID ||
> + phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID) {
> + /* If RGMII_ID or RGMII_RXID are specified enable RX delay,
> + * otherwise keep it disabled
> + */
> + ret = at803x_enable_rx_delay(phydev);
> if (ret < 0)
> return ret;
> }
>
> - if (phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID ||
> - phydev->interface == PHY_INTERFACE_MODE_RGMII_ID ||
> - phydev->interface == PHY_INTERFACE_MODE_RGMII) {
> - ret = at803x_disable_tx_delay(phydev);
> - if (ret < 0)
> - return ret;
> + if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID ||
> + phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID) {
> + /* If RGMII_ID or RGMII_TXID are specified enable TX delay,
> + * otherwise keep it disabled
> + */
> + ret = at803x_enable_tx_delay(phydev);
> }
>
> - return 0;
> + return ret;
> }
>
> static int at803x_ack_interrupt(struct phy_device *phydev)
> --
> 2.20.1
>
Reviewed-by: Niklas Cassel <niklas.cassel@linaro.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] net: phy: at803x: disable delay only for RGMII mode
2019-02-18 10:18 ` [PATCH v2 2/2] net: phy: at803x: disable delay only for RGMII mode Vinod Koul
2019-02-18 10:28 ` Niklas Cassel
@ 2019-02-18 14:40 ` Peter Ujfalusi
1 sibling, 0 replies; 9+ messages in thread
From: Peter Ujfalusi @ 2019-02-18 14:40 UTC (permalink / raw)
To: Vinod Koul, David S Miller
Cc: linux-arm-msm, Bjorn Andersson, netdev, Niklas Cassel,
Andrew Lunn, Florian Fainelli, Nori, Sekhar, Marc Gonzalez
Hi Vinod,
On 18/02/2019 12.18, Vinod Koul wrote:
> Per "Documentation/devicetree/bindings/net/ethernet.txt" RGMII mode
> should not have delay in PHY wheras RGMII_ID and RGMII_RXID/RGMII_TXID
> can have delay in phy.
>
> So disable the delay only for RGMII mode and enable for other modes.
> Also treat the default case as disabled delays.
With https://patchwork.ozlabs.org/project/netdev/list/?series=92672
ethernet is working on am335x-evmsk. thank you:
Tested-by: Peter Ujfalusi <peter.ujflausi@ti.com>
> Fixes: cd28d1d6e52e: ("net: phy: at803x: Disable phy delay for RGMII mode")
> Reported-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> drivers/net/phy/at803x.c | 47 ++++++++++++++++++++++++++++++----------
> 1 file changed, 36 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
> index c6e7d800fd7a..dc1b13f7fc12 100644
> --- a/drivers/net/phy/at803x.c
> +++ b/drivers/net/phy/at803x.c
> @@ -110,6 +110,18 @@ static int at803x_debug_reg_mask(struct phy_device *phydev, u16 reg,
> return phy_write(phydev, AT803X_DEBUG_DATA, val);
> }
>
> +static int at803x_enable_rx_delay(struct phy_device *phydev)
> +{
> + return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_0, 0,
> + AT803X_DEBUG_RX_CLK_DLY_EN);
> +}
> +
> +static int at803x_enable_tx_delay(struct phy_device *phydev)
> +{
> + return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_5, 0,
> + AT803X_DEBUG_TX_CLK_DLY_EN);
> +}
> +
> static int at803x_disable_rx_delay(struct phy_device *phydev)
> {
> return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_0,
> @@ -255,23 +267,36 @@ static int at803x_config_init(struct phy_device *phydev)
> if (ret < 0)
> return ret;
>
> - if (phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID ||
> - phydev->interface == PHY_INTERFACE_MODE_RGMII_ID ||
> - phydev->interface == PHY_INTERFACE_MODE_RGMII) {
> - ret = at803x_disable_rx_delay(phydev);
> + /* The hardware register default is RX and TX delay enabled, so lets
> + * first disable the RX and TX delays in phy and enable them based
> + * on the mode selected
> + */
> + ret = at803x_disable_rx_delay(phydev);
> + if (ret < 0)
> + return ret;
> + ret = at803x_disable_tx_delay(phydev);
> + if (ret < 0)
> + return ret;
> +
> + if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID ||
> + phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID) {
> + /* If RGMII_ID or RGMII_RXID are specified enable RX delay,
> + * otherwise keep it disabled
> + */
> + ret = at803x_enable_rx_delay(phydev);
> if (ret < 0)
> return ret;
> }
>
> - if (phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID ||
> - phydev->interface == PHY_INTERFACE_MODE_RGMII_ID ||
> - phydev->interface == PHY_INTERFACE_MODE_RGMII) {
> - ret = at803x_disable_tx_delay(phydev);
> - if (ret < 0)
> - return ret;
> + if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID ||
> + phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID) {
> + /* If RGMII_ID or RGMII_TXID are specified enable TX delay,
> + * otherwise keep it disabled
> + */
> + ret = at803x_enable_tx_delay(phydev);
> }
>
> - return 0;
> + return ret;
> }
>
> static int at803x_ack_interrupt(struct phy_device *phydev)
>
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] net: phy: at803x: dont inline helpers
2019-02-18 10:18 [PATCH v2 1/2] net: phy: at803x: dont inline helpers Vinod Koul
2019-02-18 10:18 ` [PATCH v2 2/2] net: phy: at803x: disable delay only for RGMII mode Vinod Koul
2019-02-18 10:28 ` [PATCH v2 1/2] net: phy: at803x: dont inline helpers Niklas Cassel
@ 2019-02-19 0:28 ` David Miller
2019-02-19 5:02 ` Vinod Koul
2 siblings, 1 reply; 9+ messages in thread
From: David Miller @ 2019-02-19 0:28 UTC (permalink / raw)
To: vkoul
Cc: linux-arm-msm, bjorn.andersson, netdev, niklas.cassel, andrew,
f.fainelli, nsekhar, peter.ujfalusi, marc.w.gonzalez
From: Vinod Koul <vkoul@kernel.org>
Date: Mon, 18 Feb 2019 15:48:52 +0530
> Some helpers were inlined, but makes more sense to allow compiler
> to do the right optiomazations instead, so remove inline for
> at803x_disable_rx_delay() and at803x_disable_tx_delay()
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Two problem with this patch series.
1) It fixes a bug in 'net' but the patches only apply cleanly to
'net-next'. Please respin this against 'net'.
2) This series lacks a header posting "[PATCH vX 0/N] " which
explains at a high level what the series is doing, how it is
doing it, and why it is doing it that way.
Thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] net: phy: at803x: dont inline helpers
2019-02-19 0:28 ` David Miller
@ 2019-02-19 5:02 ` Vinod Koul
2019-02-19 5:35 ` Sekhar Nori
0 siblings, 1 reply; 9+ messages in thread
From: Vinod Koul @ 2019-02-19 5:02 UTC (permalink / raw)
To: David Miller
Cc: linux-arm-msm, bjorn.andersson, netdev, niklas.cassel, andrew,
f.fainelli, nsekhar, peter.ujfalusi, marc.w.gonzalez
Hello Dave,
On 18-02-19, 16:28, David Miller wrote:
> From: Vinod Koul <vkoul@kernel.org>
> Date: Mon, 18 Feb 2019 15:48:52 +0530
>
> > Some helpers were inlined, but makes more sense to allow compiler
> > to do the right optiomazations instead, so remove inline for
> > at803x_disable_rx_delay() and at803x_disable_tx_delay()
> >
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
>
> Two problem with this patch series.
>
> 1) It fixes a bug in 'net' but the patches only apply cleanly to
> 'net-next'. Please respin this against 'net'.
I assume the 'net' is fixes going into current -rcX. This fixes issues
reported on linux-next due to patches in net-next, so these fixes should
go to net-next as well.
> 2) This series lacks a header posting "[PATCH vX 0/N] " which
> explains at a high level what the series is doing, how it is
> doing it, and why it is doing it that way.
Sure I will add this and repost
Thanks
--
~Vinod
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] net: phy: at803x: dont inline helpers
2019-02-19 5:02 ` Vinod Koul
@ 2019-02-19 5:35 ` Sekhar Nori
2019-02-19 5:39 ` Vinod Koul
0 siblings, 1 reply; 9+ messages in thread
From: Sekhar Nori @ 2019-02-19 5:35 UTC (permalink / raw)
To: Vinod Koul, David Miller
Cc: linux-arm-msm, bjorn.andersson, netdev, niklas.cassel, andrew,
f.fainelli, peter.ujfalusi, marc.w.gonzalez
Hi Vinod,
On 19/02/19 10:32 AM, Vinod Koul wrote:
> Hello Dave,
>
> On 18-02-19, 16:28, David Miller wrote:
>> From: Vinod Koul <vkoul@kernel.org>
>> Date: Mon, 18 Feb 2019 15:48:52 +0530
>>
>>> Some helpers were inlined, but makes more sense to allow compiler
>>> to do the right optiomazations instead, so remove inline for
>>> at803x_disable_rx_delay() and at803x_disable_tx_delay()
>>>
>>> Signed-off-by: Vinod Koul <vkoul@kernel.org>
>>
>> Two problem with this patch series.
>>
>> 1) It fixes a bug in 'net' but the patches only apply cleanly to
>> 'net-next'. Please respin this against 'net'.
>
> I assume the 'net' is fixes going into current -rcX. This fixes issues
> reported on linux-next due to patches in net-next, so these fixes should
> go to net-next as well.
net-next should be part of subject prefix in this case. See
Documentation/networking/netdev-FAQ.rst
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] net: phy: at803x: dont inline helpers
2019-02-19 5:35 ` Sekhar Nori
@ 2019-02-19 5:39 ` Vinod Koul
0 siblings, 0 replies; 9+ messages in thread
From: Vinod Koul @ 2019-02-19 5:39 UTC (permalink / raw)
To: Sekhar Nori
Cc: David Miller, linux-arm-msm, bjorn.andersson, netdev,
niklas.cassel, andrew, f.fainelli, peter.ujfalusi,
marc.w.gonzalez
On 19-02-19, 11:05, Sekhar Nori wrote:
> Hi Vinod,
>
> On 19/02/19 10:32 AM, Vinod Koul wrote:
> > Hello Dave,
> >
> > On 18-02-19, 16:28, David Miller wrote:
> >> From: Vinod Koul <vkoul@kernel.org>
> >> Date: Mon, 18 Feb 2019 15:48:52 +0530
> >>
> >>> Some helpers were inlined, but makes more sense to allow compiler
> >>> to do the right optiomazations instead, so remove inline for
> >>> at803x_disable_rx_delay() and at803x_disable_tx_delay()
> >>>
> >>> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> >>
> >> Two problem with this patch series.
> >>
> >> 1) It fixes a bug in 'net' but the patches only apply cleanly to
> >> 'net-next'. Please respin this against 'net'.
> >
> > I assume the 'net' is fixes going into current -rcX. This fixes issues
> > reported on linux-next due to patches in net-next, so these fixes should
> > go to net-next as well.
>
> net-next should be part of subject prefix in this case. See
> Documentation/networking/netdev-FAQ.rst
Thanks for the pointer Sekhar, will do :)
--
~Vinod
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-02-19 5:39 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-18 10:18 [PATCH v2 1/2] net: phy: at803x: dont inline helpers Vinod Koul
2019-02-18 10:18 ` [PATCH v2 2/2] net: phy: at803x: disable delay only for RGMII mode Vinod Koul
2019-02-18 10:28 ` Niklas Cassel
2019-02-18 14:40 ` Peter Ujfalusi
2019-02-18 10:28 ` [PATCH v2 1/2] net: phy: at803x: dont inline helpers Niklas Cassel
2019-02-19 0:28 ` David Miller
2019-02-19 5:02 ` Vinod Koul
2019-02-19 5:35 ` Sekhar Nori
2019-02-19 5:39 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).