From: David Miller <davem@davemloft.net>
To: liuhangbin@gmail.com
Cc: netdev@vger.kernel.org, dsahern@gmail.com,
roopa@cumulusnetworks.com, sd@queasysnail.net
Subject: Re: [PATCH v2 net] ipv4: Add ICMPv6 support when parse route ipproto
Date: Fri, 01 Mar 2019 16:42:34 -0800 (PST) [thread overview]
Message-ID: <20190301.164234.33116600327008363.davem@davemloft.net> (raw)
In-Reply-To: <20190227081529.23657-1-liuhangbin@gmail.com>
From: Hangbin Liu <liuhangbin@gmail.com>
Date: Wed, 27 Feb 2019 16:15:29 +0800
> For ip rules, we need to use 'ipproto ipv6-icmp' to match ICMPv6 headers.
> But for ip -6 route, currently we only support tcp, udp and icmp.
>
> Add ICMPv6 support so we can match ipv6-icmp rules for route lookup.
>
> v2: As David Ahern and Sabrina Dubroca suggested, Add an argument to
> rtm_getroute_parse_ip_proto() to handle ICMP/ICMPv6 with different family.
>
> Reported-by: Jianlin Shi <jishi@redhat.com>
> Fixes: eacb9384a3fe ("ipv6: support sport, dport and ip_proto in RTM_GETROUTE")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2019-03-02 0:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 7:47 [PATCH net] ipv4: Add ICMPv6 support when parse route ipproto Hangbin Liu
2019-02-25 11:14 ` Sabrina Dubroca
2019-02-25 18:46 ` David Ahern
2019-02-26 2:17 ` Hangbin Liu
2019-02-26 2:23 ` David Ahern
2019-02-26 3:48 ` Hangbin Liu
2019-02-26 9:06 ` Sabrina Dubroca
2019-02-27 8:15 ` [PATCH v2 " Hangbin Liu
2019-03-02 0:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301.164234.33116600327008363.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).