* [PATCH net] net: keep refcount warning in reqsk_free()
@ 2019-03-09 9:26 Guillaume Nault
2019-03-10 3:52 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Guillaume Nault @ 2019-03-09 9:26 UTC (permalink / raw)
To: netdev; +Cc: Eric Dumazet
As Eric Dumazet said, "We do not have a way to tell if the req was ever
inserted in a hash table, so better play safe.".
Let's remove this comment, so that nobody will be tempted to drop the
WARN_ON_ONCE() line.
Signed-off-by: Guillaume Nault <gnault@redhat.com>
---
include/net/request_sock.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/net/request_sock.h b/include/net/request_sock.h
index 347015515a7d..21a5243fecd1 100644
--- a/include/net/request_sock.h
+++ b/include/net/request_sock.h
@@ -108,7 +108,6 @@ reqsk_alloc(const struct request_sock_ops *ops, struct sock *sk_listener,
static inline void reqsk_free(struct request_sock *req)
{
- /* temporary debugging */
WARN_ON_ONCE(refcount_read(&req->rsk_refcnt) != 0);
req->rsk_ops->destructor(req);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: keep refcount warning in reqsk_free()
2019-03-09 9:26 [PATCH net] net: keep refcount warning in reqsk_free() Guillaume Nault
@ 2019-03-10 3:52 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-03-10 3:52 UTC (permalink / raw)
To: gnault; +Cc: netdev, eric.dumazet
From: Guillaume Nault <gnault@redhat.com>
Date: Sat, 9 Mar 2019 10:26:53 +0100
> As Eric Dumazet said, "We do not have a way to tell if the req was ever
> inserted in a hash table, so better play safe.".
> Let's remove this comment, so that nobody will be tempted to drop the
> WARN_ON_ONCE() line.
>
> Signed-off-by: Guillaume Nault <gnault@redhat.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-10 3:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-09 9:26 [PATCH net] net: keep refcount warning in reqsk_free() Guillaume Nault
2019-03-10 3:52 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).