* [PATCH] staging: e1000: e1000_main.c: remove extern declarations in .c file.
@ 2019-03-10 11:46 Quentin Deslandes
2019-03-10 18:03 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Quentin Deslandes @ 2019-03-10 11:46 UTC (permalink / raw)
To: jeffrey.t.kirsher, davem, intel-wired-lan, netdev, linux-kernel,
kernel-janitors
This patch fixes the checkpatch.pl warning:
WARNING: externs should be avoided in .c files
Some of the driver's function declared in e1000.h were declared a second
time in e1000_main.c, triggering checkpatch.pl warnings.
Signed-off-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>
---
drivers/net/ethernet/intel/e1000/e1000_main.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c
index 8fe9af0e2ab7..b3d5cd750dca 100644
--- a/drivers/net/ethernet/intel/e1000/e1000_main.c
+++ b/drivers/net/ethernet/intel/e1000/e1000_main.c
@@ -65,14 +65,6 @@ static const struct pci_device_id e1000_pci_tbl[] = {
MODULE_DEVICE_TABLE(pci, e1000_pci_tbl);
-int e1000_up(struct e1000_adapter *adapter);
-void e1000_down(struct e1000_adapter *adapter);
-void e1000_reinit_locked(struct e1000_adapter *adapter);
-void e1000_reset(struct e1000_adapter *adapter);
-int e1000_setup_all_tx_resources(struct e1000_adapter *adapter);
-int e1000_setup_all_rx_resources(struct e1000_adapter *adapter);
-void e1000_free_all_tx_resources(struct e1000_adapter *adapter);
-void e1000_free_all_rx_resources(struct e1000_adapter *adapter);
static int e1000_setup_tx_resources(struct e1000_adapter *adapter,
struct e1000_tx_ring *txdr);
static int e1000_setup_rx_resources(struct e1000_adapter *adapter,
@@ -81,7 +73,6 @@ static void e1000_free_tx_resources(struct e1000_adapter *adapter,
struct e1000_tx_ring *tx_ring);
static void e1000_free_rx_resources(struct e1000_adapter *adapter,
struct e1000_rx_ring *rx_ring);
-void e1000_update_stats(struct e1000_adapter *adapter);
static int e1000_init_module(void);
static void e1000_exit_module(void);
@@ -89,8 +80,6 @@ static int e1000_probe(struct pci_dev *pdev, const struct pci_device_id *ent);
static void e1000_remove(struct pci_dev *pdev);
static int e1000_alloc_queues(struct e1000_adapter *adapter);
static int e1000_sw_init(struct e1000_adapter *adapter);
-int e1000_open(struct net_device *netdev);
-int e1000_close(struct net_device *netdev);
static void e1000_configure_tx(struct e1000_adapter *adapter);
static void e1000_configure_rx(struct e1000_adapter *adapter);
static void e1000_setup_rctl(struct e1000_adapter *adapter);
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: e1000: e1000_main.c: remove extern declarations in .c file.
2019-03-10 11:46 [PATCH] staging: e1000: e1000_main.c: remove extern declarations in .c file Quentin Deslandes
@ 2019-03-10 18:03 ` David Miller
2019-03-10 18:19 ` Quentin Deslandes
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2019-03-10 18:03 UTC (permalink / raw)
To: quentin.deslandes
Cc: jeffrey.t.kirsher, intel-wired-lan, netdev, linux-kernel,
kernel-janitors
"staging"?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: e1000: e1000_main.c: remove extern declarations in .c file.
2019-03-10 18:03 ` David Miller
@ 2019-03-10 18:19 ` Quentin Deslandes
0 siblings, 0 replies; 3+ messages in thread
From: Quentin Deslandes @ 2019-03-10 18:19 UTC (permalink / raw)
To: David Miller
Cc: jeffrey.t.kirsher, intel-wired-lan, netdev, linux-kernel,
kernel-janitors
On Sun, Mar 10, 2019 at 11:03:09AM -0700, David Miller wrote:
>
> "staging"?
"staging" was an error, someone explained me after I sent the patch, sorry for
the inconvenience.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-10 18:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-10 11:46 [PATCH] staging: e1000: e1000_main.c: remove extern declarations in .c file Quentin Deslandes
2019-03-10 18:03 ` David Miller
2019-03-10 18:19 ` Quentin Deslandes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).