* [PATCH] net: qlge: fix a potential NULL pointer dereference
@ 2019-03-11 6:53 Kangjie Lu
2019-03-11 23:16 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Kangjie Lu @ 2019-03-11 6:53 UTC (permalink / raw)
To: kjlu
Cc: pakki001, Manish Chopra, GR-Linux-NIC-Dev, David S. Miller,
netdev, linux-kernel
In case alloc_ordered_workqueue fails, the fix returns
-ENOMEM to avoid NULL pointer dereference.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
---
drivers/net/ethernet/qlogic/qlge/qlge_main.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/qlogic/qlge/qlge_main.c b/drivers/net/ethernet/qlogic/qlge/qlge_main.c
index 096515c27263..07e1c623048e 100644
--- a/drivers/net/ethernet/qlogic/qlge/qlge_main.c
+++ b/drivers/net/ethernet/qlogic/qlge/qlge_main.c
@@ -4681,6 +4681,11 @@ static int ql_init_device(struct pci_dev *pdev, struct net_device *ndev,
*/
qdev->workqueue = alloc_ordered_workqueue("%s", WQ_MEM_RECLAIM,
ndev->name);
+ if (!qdev->workqueue) {
+ err = -ENOMEM;
+ goto err_out2;
+ }
+
INIT_DELAYED_WORK(&qdev->asic_reset_work, ql_asic_reset_work);
INIT_DELAYED_WORK(&qdev->mpi_reset_work, ql_mpi_reset_work);
INIT_DELAYED_WORK(&qdev->mpi_work, ql_mpi_work);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: qlge: fix a potential NULL pointer dereference
2019-03-11 6:53 [PATCH] net: qlge: fix a potential NULL pointer dereference Kangjie Lu
@ 2019-03-11 23:16 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-03-11 23:16 UTC (permalink / raw)
To: kjlu; +Cc: pakki001, manishc, GR-Linux-NIC-Dev, netdev, linux-kernel
From: Kangjie Lu <kjlu@umn.edu>
Date: Mon, 11 Mar 2019 01:53:15 -0500
> In case alloc_ordered_workqueue fails, the fix returns
> -ENOMEM to avoid NULL pointer dereference.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-11 23:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-11 6:53 [PATCH] net: qlge: fix a potential NULL pointer dereference Kangjie Lu
2019-03-11 23:16 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).