* [PATCH v2] net: qlogic: fix a potential NULL pointer dereference
@ 2019-03-12 7:06 Kangjie Lu
2019-03-12 21:44 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Kangjie Lu @ 2019-03-12 7:06 UTC (permalink / raw)
To: kjlu; +Cc: pakki001, GR-Linux-NIC-Dev, David S. Miller, netdev, linux-kernel
In case create_singlethread_workqueue fails, the fix returns
-ENOMEM to avoid NULL pointer dereference.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
---
drivers/net/ethernet/qlogic/qla3xxx.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/ethernet/qlogic/qla3xxx.c b/drivers/net/ethernet/qlogic/qla3xxx.c
index 10b075bc5959..b61b88cbc0c7 100644
--- a/drivers/net/ethernet/qlogic/qla3xxx.c
+++ b/drivers/net/ethernet/qlogic/qla3xxx.c
@@ -3886,6 +3886,12 @@ static int ql3xxx_probe(struct pci_dev *pdev,
netif_stop_queue(ndev);
qdev->workqueue = create_singlethread_workqueue(ndev->name);
+ if (!qdev->workqueue) {
+ unregister_netdev(ndev);
+ err = -ENOMEM;
+ goto err_out_iounmap;
+ }
+
INIT_DELAYED_WORK(&qdev->reset_work, ql_reset_work);
INIT_DELAYED_WORK(&qdev->tx_timeout_work, ql_tx_timeout_work);
INIT_DELAYED_WORK(&qdev->link_state_work, ql_link_state_machine_work);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] net: qlogic: fix a potential NULL pointer dereference
2019-03-12 7:06 [PATCH v2] net: qlogic: fix a potential NULL pointer dereference Kangjie Lu
@ 2019-03-12 21:44 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-03-12 21:44 UTC (permalink / raw)
To: kjlu; +Cc: pakki001, GR-Linux-NIC-Dev, netdev, linux-kernel
From: Kangjie Lu <kjlu@umn.edu>
Date: Tue, 12 Mar 2019 02:06:47 -0500
> In case create_singlethread_workqueue fails, the fix returns
> -ENOMEM to avoid NULL pointer dereference.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-12 21:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-12 7:06 [PATCH v2] net: qlogic: fix a potential NULL pointer dereference Kangjie Lu
2019-03-12 21:44 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).