* [PATCH bpf-next] libbpf: fix BPF_LOG_BUF_SIZE off-by-one error
@ 2019-04-19 16:52 robert.mccabe
0 siblings, 0 replies; 6+ messages in thread
From: robert.mccabe @ 2019-04-19 16:52 UTC (permalink / raw)
To: netdev; +Cc: robertjmccabe, robert.mccabe
From: <robert.mccabe@rockwellcollins.com>
The BPF_PROG_LOAD condition for kernel version <= 5.1 is
log->len_total > UINT_MAX >> 8 /* (16 * 1024 * 1024) - 1 */
Signed-off-by: rjmccabe3701 <robert.mccabe@rockwellcollins.com>
---
tools/lib/bpf/bpf.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/lib/bpf/bpf.h b/tools/lib/bpf/bpf.h
index bc30783d1403..62d67caa7aea 100644
--- a/tools/lib/bpf/bpf.h
+++ b/tools/lib/bpf/bpf.h
@@ -92,7 +92,7 @@ struct bpf_load_program_attr {
#define MAPS_RELAX_COMPAT 0x01
/* Recommend log buffer size */
-#define BPF_LOG_BUF_SIZE (16 * 1024 * 1024) /* verifier maximum in kernels <= 5.1 */
+#define BPF_LOG_BUF_SIZE ((16 * 1024 * 1024) - 1) /* verifier maximum in kernels <= 5.1 */
LIBBPF_API int
bpf_load_program_xattr(const struct bpf_load_program_attr *load_attr,
char *log_buf, size_t log_buf_sz);
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH bpf-next] libbpf: fix BPF_LOG_BUF_SIZE off-by-one error
2019-04-19 19:32 ` Alexei Starovoitov
@ 2019-04-19 23:23 ` Robert McCabe
0 siblings, 0 replies; 6+ messages in thread
From: Robert McCabe @ 2019-04-19 23:23 UTC (permalink / raw)
To: Alexei Starovoitov; +Cc: netdev, Rob, bpf
> sending one patch was enough. no need to spam 5 times.
Gosh that's embarrassing. I was having a difficult time sending the
patch (I'm new at patchwork-based development).
I'll submit a a new patch with your suggestion.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH bpf-next] libbpf: fix BPF_LOG_BUF_SIZE off-by-one error
2019-04-19 16:47 robert.mccabe
@ 2019-04-19 19:32 ` Alexei Starovoitov
2019-04-19 23:23 ` Robert McCabe
0 siblings, 1 reply; 6+ messages in thread
From: Alexei Starovoitov @ 2019-04-19 19:32 UTC (permalink / raw)
To: robert.mccabe; +Cc: netdev, robertjmccabe, bpf
On Fri, Apr 19, 2019 at 11:47:45AM -0500, robert.mccabe@rockwellcollins.com wrote:
> From: "McCabe, Robert J" <Robert.McCabe@rockwellcollins.com>
>
> The BPF_PROG_LOAD condition for kernel version <= 5.1 is
>
> log->len_total > UINT_MAX >> 8 /* (16 * 1024 * 1024) - 1 */
>
> Signed-off-by: rjmccabe3701 <robert.mccabe@rockwellcollins.com>
> ---
> tools/lib/bpf/bpf.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/bpf/bpf.h b/tools/lib/bpf/bpf.h
> index bc30783d1403..62d67caa7aea 100644
> --- a/tools/lib/bpf/bpf.h
> +++ b/tools/lib/bpf/bpf.h
> @@ -92,7 +92,7 @@ struct bpf_load_program_attr {
> #define MAPS_RELAX_COMPAT 0x01
>
> /* Recommend log buffer size */
> -#define BPF_LOG_BUF_SIZE (16 * 1024 * 1024) /* verifier maximum in kernels <= 5.1 */
> +#define BPF_LOG_BUF_SIZE ((16 * 1024 * 1024) - 1) /* verifier maximum in kernels <= 5.1 */
thanks. good catch.
please replace with (UINT32_MAX >> 8)
sending one patch was enough. no need to spam 5 times.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH bpf-next] libbpf: fix BPF_LOG_BUF_SIZE off-by-one error
@ 2019-04-19 16:47 robert.mccabe
2019-04-19 19:32 ` Alexei Starovoitov
0 siblings, 1 reply; 6+ messages in thread
From: robert.mccabe @ 2019-04-19 16:47 UTC (permalink / raw)
To: netdev; +Cc: robertjmccabe, McCabe, Robert J, rjmccabe3701
From: "McCabe, Robert J" <Robert.McCabe@rockwellcollins.com>
The BPF_PROG_LOAD condition for kernel version <= 5.1 is
log->len_total > UINT_MAX >> 8 /* (16 * 1024 * 1024) - 1 */
Signed-off-by: rjmccabe3701 <robert.mccabe@rockwellcollins.com>
---
tools/lib/bpf/bpf.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/lib/bpf/bpf.h b/tools/lib/bpf/bpf.h
index bc30783d1403..62d67caa7aea 100644
--- a/tools/lib/bpf/bpf.h
+++ b/tools/lib/bpf/bpf.h
@@ -92,7 +92,7 @@ struct bpf_load_program_attr {
#define MAPS_RELAX_COMPAT 0x01
/* Recommend log buffer size */
-#define BPF_LOG_BUF_SIZE (16 * 1024 * 1024) /* verifier maximum in kernels <= 5.1 */
+#define BPF_LOG_BUF_SIZE ((16 * 1024 * 1024) - 1) /* verifier maximum in kernels <= 5.1 */
LIBBPF_API int
bpf_load_program_xattr(const struct bpf_load_program_attr *load_attr,
char *log_buf, size_t log_buf_sz);
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH bpf-next] libbpf: fix BPF_LOG_BUF_SIZE off-by-one error
@ 2019-04-19 16:44 robert.mccabe
0 siblings, 0 replies; 6+ messages in thread
From: robert.mccabe @ 2019-04-19 16:44 UTC (permalink / raw)
To: netdev; +Cc: robertjmccabe, McCabe, Robert J, rjmccabe3701
From: "McCabe, Robert J" <Robert.McCabe@rockwellcollins.com>
The BPF_PROG_LOAD condition for kernel version <= 5.1 is
log->len_total > UINT_MAX >> 8 /* (16 * 1024 * 1024) - 1 */
Signed-off-by: rjmccabe3701 <robert.mccabe@rockwellcollins.com>
---
tools/lib/bpf/bpf.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/lib/bpf/bpf.h b/tools/lib/bpf/bpf.h
index bc30783d1403..62d67caa7aea 100644
--- a/tools/lib/bpf/bpf.h
+++ b/tools/lib/bpf/bpf.h
@@ -92,7 +92,7 @@ struct bpf_load_program_attr {
#define MAPS_RELAX_COMPAT 0x01
/* Recommend log buffer size */
-#define BPF_LOG_BUF_SIZE (16 * 1024 * 1024) /* verifier maximum in kernels <= 5.1 */
+#define BPF_LOG_BUF_SIZE ((16 * 1024 * 1024) - 1) /* verifier maximum in kernels <= 5.1 */
LIBBPF_API int
bpf_load_program_xattr(const struct bpf_load_program_attr *load_attr,
char *log_buf, size_t log_buf_sz);
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH bpf-next] libbpf: fix BPF_LOG_BUF_SIZE off-by-one error
@ 2019-04-19 16:42 robert.mccabe
0 siblings, 0 replies; 6+ messages in thread
From: robert.mccabe @ 2019-04-19 16:42 UTC (permalink / raw)
To: netdev; +Cc: robert.mccabe, robertjmccabe, McCabe, Robert J, rjmccabe3701
From: "McCabe, Robert J" <Robert.McCabe@rockwellcollins.com>
The BPF_PROG_LOAD condition for kernel version <= 5.1 is
log->len_total > UINT_MAX >> 8 /* (16 * 1024 * 1024) - 1 */
Signed-off-by: rjmccabe3701 <robert.mccabe@rockwellcollins.com>
---
tools/lib/bpf/bpf.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/lib/bpf/bpf.h b/tools/lib/bpf/bpf.h
index bc30783d1403..62d67caa7aea 100644
--- a/tools/lib/bpf/bpf.h
+++ b/tools/lib/bpf/bpf.h
@@ -92,7 +92,7 @@ struct bpf_load_program_attr {
#define MAPS_RELAX_COMPAT 0x01
/* Recommend log buffer size */
-#define BPF_LOG_BUF_SIZE (16 * 1024 * 1024) /* verifier maximum in kernels <= 5.1 */
+#define BPF_LOG_BUF_SIZE ((16 * 1024 * 1024) - 1) /* verifier maximum in kernels <= 5.1 */
LIBBPF_API int
bpf_load_program_xattr(const struct bpf_load_program_attr *load_attr,
char *log_buf, size_t log_buf_sz);
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-19 23:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-19 16:52 [PATCH bpf-next] libbpf: fix BPF_LOG_BUF_SIZE off-by-one error robert.mccabe
-- strict thread matches above, loose matches on Subject: below --
2019-04-19 16:47 robert.mccabe
2019-04-19 19:32 ` Alexei Starovoitov
2019-04-19 23:23 ` Robert McCabe
2019-04-19 16:44 robert.mccabe
2019-04-19 16:42 robert.mccabe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).