* [PATCH net] net: seeq: fix crash caused by not set dev.parent
@ 2019-05-13 11:15 Thomas Bogendoerfer
2019-05-13 16:04 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Bogendoerfer @ 2019-05-13 11:15 UTC (permalink / raw)
To: David S. Miller, netdev, linux-kernel
The old MIPS implementation of dma_cache_sync() didn't use the dev argument,
but commit c9eb6172c328 ("dma-mapping: turn dma_cache_sync into a
dma_map_ops method") changed that, so we now need to set dev.parent.
Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
---
drivers/net/ethernet/seeq/sgiseeq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/seeq/sgiseeq.c b/drivers/net/ethernet/seeq/sgiseeq.c
index 70cce63a6081..696037d5ac3d 100644
--- a/drivers/net/ethernet/seeq/sgiseeq.c
+++ b/drivers/net/ethernet/seeq/sgiseeq.c
@@ -735,6 +735,7 @@ static int sgiseeq_probe(struct platform_device *pdev)
}
platform_set_drvdata(pdev, dev);
+ SET_NETDEV_DEV(dev, &pdev->dev);
sp = netdev_priv(dev);
/* Make private data page aligned */
--
2.13.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: seeq: fix crash caused by not set dev.parent
2019-05-13 11:15 [PATCH net] net: seeq: fix crash caused by not set dev.parent Thomas Bogendoerfer
@ 2019-05-13 16:04 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-05-13 16:04 UTC (permalink / raw)
To: tbogendoerfer; +Cc: netdev, linux-kernel
From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
Date: Mon, 13 May 2019 13:15:17 +0200
> The old MIPS implementation of dma_cache_sync() didn't use the dev argument,
> but commit c9eb6172c328 ("dma-mapping: turn dma_cache_sync into a
> dma_map_ops method") changed that, so we now need to set dev.parent.
>
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-13 16:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-13 11:15 [PATCH net] net: seeq: fix crash caused by not set dev.parent Thomas Bogendoerfer
2019-05-13 16:04 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).