netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Michael Schmitz <schmitzmic@gmail.com>
Cc: netdev@vger.kernel.org, schmitz@debian.org, sfr@canb.auug.org.au,
	davem@davemloft.net
Subject: Re: [PATCH 0/3] resolve module name conflict for asix PHY and USB modules
Date: Fri, 17 May 2019 23:20:02 +0200	[thread overview]
Message-ID: <20190517212002.GA22024@lunn.ch> (raw)
In-Reply-To: <1558124718-19209-1-git-send-email-schmitzmic@gmail.com>

On Sat, May 18, 2019 at 08:25:15AM +1200, Michael Schmitz wrote:
> Haven't heard back in a while, so here goes: 
> 
> Commit 31dd83b96641 ("net-next: phy: new Asix Electronics PHY driver")
> introduced a new PHY driver drivers/net/phy/asix.c that causes a module
> name conflict with a pre-existiting driver (drivers/net/usb/asix.c). 
> 
> The PHY driver is used by the X-Surf 100 ethernet card driver, and loaded
> by that driver via its PHY ID. A rename of the driver looks unproblematic.
>  
> Rename PHY driver to ax88796b.c in order to resolve name conflict. 

Hi Michael

Please just use git mv and do it all one patch. It then makes it clear
you have not changed the driver, just renamed it.

Thanks
	Andrew

  reply	other threads:[~2019-05-17 21:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190514105649.512267cd@canb.auug.org.au>
2019-05-17 20:25 ` [PATCH 0/3] resolve module name conflict for asix PHY and USB modules Michael Schmitz
2019-05-17 21:20   ` Andrew Lunn [this message]
2019-05-18  1:17     ` Michael Schmitz
2019-05-17 20:25 ` [PATCH 1/3] net: phy: new ax88796b.c Asix Electronics PHY driver Michael Schmitz
2019-05-17 20:25 ` [PATCH 2/3] net: 8390: switch X-Surf 100 driver to use ax88796b PHY Michael Schmitz
2019-05-17 20:25 ` [PATCH 3/3] net: phy: remove old Asix Electronics PHY driver Michael Schmitz
2019-05-18  1:14 ` [PATCH v2] net: phy: rename " Michael Schmitz
2019-05-18 14:20   ` Andrew Lunn
2019-05-18 17:48     ` Michael Schmitz
2019-05-18 18:04       ` Andrew Lunn
2019-06-07  5:37 ` [PATCH net v3] " Michael Schmitz
2019-06-07 13:00   ` Andrew Lunn
2019-06-08  1:54     ` Michael Schmitz
2019-06-09 20:24   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190517212002.GA22024@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=schmitz@debian.org \
    --cc=schmitzmic@gmail.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).