From: Jiri Pirko <jiri@resnulli.us>
To: Saeed Mahameed <saeedm@mellanox.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"sthemmin@microsoft.com" <sthemmin@microsoft.com>,
"dsahern@gmail.com" <dsahern@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
mlxsw <mlxsw@mellanox.com>,
"jakub.kicinski@netronome.com" <jakub.kicinski@netronome.com>,
"leon@kernel.org" <leon@kernel.org>
Subject: Re: [patch net-next 0/7] expose flash update status to user
Date: Fri, 24 May 2019 10:15:10 +0200 [thread overview]
Message-ID: <20190524081510.GD2904@nanopsycho> (raw)
In-Reply-To: <c4bd07725a1e5a4d09066eb73094623d8b37082b.camel@mellanox.com>
Thu, May 23, 2019 at 08:37:28PM CEST, saeedm@mellanox.com wrote:
>On Thu, 2019-05-23 at 11:45 +0200, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@mellanox.com>
>>
>> When user is flashing device using devlink, he currenly does not see
>> any
>> information about what is going on, percentages, etc.
>> Drivers, for example mlxsw and mlx5, have notion about the progress
>> and what is happening. This patchset exposes this progress
>> information to userspace.
>>
>
>Very cool stuff, \let's update devlink docs with the new potential
>output of the fw flash commands, and show us some output example here
>or on one of the commit messages, it would really help getting an idea
>of what this cool patchset provides.
You mean in man? I can put some example there.
>
>> See this console recording which shows flashing FW on a Mellanox
>> Spectrum device:
>> https://asciinema.org/a/247926
>>
>> Jiri Pirko (7):
>> mlxsw: Move firmware flash implementation to devlink
>> mlx5: Move firmware flash implementation to devlink
>> mlxfw: Propagate error messages through extack
>> devlink: allow driver to update progress of flash update
>> mlxfw: Introduce status_notify op and call it to notify about the
>> status
>> mlxsw: Implement flash update status notifications
>> netdevsim: implement fake flash updating with notifications
>>
>> drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 -
>> .../ethernet/mellanox/mlx5/core/en_ethtool.c | 35 ------
>> drivers/net/ethernet/mellanox/mlx5/core/fw.c | 6 +-
>> .../mellanox/mlx5/core/ipoib/ethtool.c | 9 --
>> .../net/ethernet/mellanox/mlx5/core/main.c | 20 ++++
>> .../ethernet/mellanox/mlx5/core/mlx5_core.h | 3 +-
>> drivers/net/ethernet/mellanox/mlxfw/mlxfw.h | 11 +-
>> .../net/ethernet/mellanox/mlxfw/mlxfw_fsm.c | 57 ++++++++--
>> drivers/net/ethernet/mellanox/mlxsw/core.c | 15 +++
>> drivers/net/ethernet/mellanox/mlxsw/core.h | 3 +
>> .../net/ethernet/mellanox/mlxsw/spectrum.c | 75 +++++++------
>> drivers/net/netdevsim/dev.c | 35 ++++++
>> include/net/devlink.h | 8 ++
>> include/uapi/linux/devlink.h | 5 +
>> net/core/devlink.c | 102
>> ++++++++++++++++++
>> 15 files changed, 295 insertions(+), 91 deletions(-)
>>
>
>Reviewed-by: Saeed Mahameed <saeedm@mellanox.com>
next prev parent reply other threads:[~2019-05-24 8:15 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 9:45 [patch net-next 0/7] expose flash update status to user Jiri Pirko
2019-05-23 9:45 ` [patch net-next 1/7] mlxsw: Move firmware flash implementation to devlink Jiri Pirko
2019-05-23 9:45 ` [patch net-next 2/7] mlx5: " Jiri Pirko
2019-05-23 9:45 ` [patch net-next 3/7] mlxfw: Propagate error messages through extack Jiri Pirko
2019-05-23 15:19 ` David Ahern
2019-05-23 18:30 ` Saeed Mahameed
2019-05-24 8:11 ` Jiri Pirko
2019-05-24 15:54 ` Jakub Kicinski
2019-05-24 22:26 ` Jiri Pirko
2019-05-25 0:08 ` Jakub Kicinski
2019-05-27 13:33 ` Jiri Pirko
2019-05-23 9:45 ` [patch net-next 4/7] devlink: allow driver to update progress of flash update Jiri Pirko
2019-05-23 17:39 ` Jakub Kicinski
2019-05-23 9:45 ` [patch net-next 5/7] mlxfw: Introduce status_notify op and call it to notify about the status Jiri Pirko
2019-05-23 9:45 ` [patch net-next 6/7] mlxsw: Implement flash update status notifications Jiri Pirko
2019-05-23 9:45 ` [patch net-next 7/7] netdevsim: implement fake flash updating with notifications Jiri Pirko
2019-05-23 17:47 ` Jakub Kicinski
2019-05-24 8:17 ` Jiri Pirko
2019-05-23 9:47 ` [patch iproute2 1/3] header update Jiri Pirko
2019-05-23 9:47 ` [patch iproute2 2/3] devlink: implement flash update status monitoring Jiri Pirko
2019-05-23 9:47 ` [patch iproute2 3/3] devlink: implement flash " Jiri Pirko
2019-05-23 17:57 ` Jakub Kicinski
2019-05-24 8:14 ` Jiri Pirko
2019-05-23 18:37 ` [patch net-next 0/7] expose flash update status to user Saeed Mahameed
2019-05-24 8:15 ` Jiri Pirko [this message]
2019-05-24 15:04 ` David Ahern
2019-05-28 11:29 ` Jiri Pirko
2019-05-27 18:14 ` Florian Fainelli
2019-05-28 8:55 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524081510.GD2904@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=leon@kernel.org \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).