From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Jiri Pirko <jiri@resnulli.us>, David Ahern <dsahern@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com,
sthemmin@microsoft.com, saeedm@mellanox.com, leon@kernel.org
Subject: Re: [patch net-next 3/7] mlxfw: Propagate error messages through extack
Date: Fri, 24 May 2019 17:08:52 -0700 [thread overview]
Message-ID: <20190524170852.4fea5e77@cakuba.netronome.com> (raw)
In-Reply-To: <20190524222635.GA2284@nanopsycho.orion>
On Sat, 25 May 2019 00:26:35 +0200, Jiri Pirko wrote:
> Fri, May 24, 2019 at 05:54:46PM CEST, jakub.kicinski@netronome.com wrote:
> >On Fri, 24 May 2019 10:11:10 +0200, Jiri Pirko wrote:
> >> Thu, May 23, 2019 at 05:19:46PM CEST, dsahern@gmail.com wrote:
> >> >On 5/23/19 3:45 AM, Jiri Pirko wrote:
> >> >> @@ -57,11 +58,13 @@ static int mlxfw_fsm_state_wait(struct mlxfw_dev *mlxfw_dev, u32 fwhandle,
> >> >> if (fsm_state_err != MLXFW_FSM_STATE_ERR_OK) {
> >> >> pr_err("Firmware flash failed: %s\n",
> >> >> mlxfw_fsm_state_err_str[fsm_state_err]);
> >> >> + NL_SET_ERR_MSG_MOD(extack, "Firmware flash failed");
> >> >> return -EINVAL;
> >> >> }
> >> >> if (curr_fsm_state != fsm_state) {
> >> >> if (--times == 0) {
> >> >> pr_err("Timeout reached on FSM state change");
> >> >> + NL_SET_ERR_MSG_MOD(extack, "Timeout reached on FSM state change");
> >> >
> >> >FSM? Is the meaning obvious to users?
> >>
> >> It is specific to mlx drivers.
> >
> >What does it stand for? Isn't it just Finite State Machine?
>
> I believe so.
In which case it doesn't really add much, no? I second David's request
to make the messages as easy to understand as possible.
PSID for better or worse I have previously capitulated on, so I guess
the ship has indeed sailed there :)
$ grep -A4 psid -- Documentation/networking/devlink-info-versions.rst
fw.psid
=======
Unique identifier of the firmware parameter set.
next prev parent reply other threads:[~2019-05-25 0:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 9:45 [patch net-next 0/7] expose flash update status to user Jiri Pirko
2019-05-23 9:45 ` [patch net-next 1/7] mlxsw: Move firmware flash implementation to devlink Jiri Pirko
2019-05-23 9:45 ` [patch net-next 2/7] mlx5: " Jiri Pirko
2019-05-23 9:45 ` [patch net-next 3/7] mlxfw: Propagate error messages through extack Jiri Pirko
2019-05-23 15:19 ` David Ahern
2019-05-23 18:30 ` Saeed Mahameed
2019-05-24 8:11 ` Jiri Pirko
2019-05-24 15:54 ` Jakub Kicinski
2019-05-24 22:26 ` Jiri Pirko
2019-05-25 0:08 ` Jakub Kicinski [this message]
2019-05-27 13:33 ` Jiri Pirko
2019-05-23 9:45 ` [patch net-next 4/7] devlink: allow driver to update progress of flash update Jiri Pirko
2019-05-23 17:39 ` Jakub Kicinski
2019-05-23 9:45 ` [patch net-next 5/7] mlxfw: Introduce status_notify op and call it to notify about the status Jiri Pirko
2019-05-23 9:45 ` [patch net-next 6/7] mlxsw: Implement flash update status notifications Jiri Pirko
2019-05-23 9:45 ` [patch net-next 7/7] netdevsim: implement fake flash updating with notifications Jiri Pirko
2019-05-23 17:47 ` Jakub Kicinski
2019-05-24 8:17 ` Jiri Pirko
2019-05-23 9:47 ` [patch iproute2 1/3] header update Jiri Pirko
2019-05-23 9:47 ` [patch iproute2 2/3] devlink: implement flash update status monitoring Jiri Pirko
2019-05-23 9:47 ` [patch iproute2 3/3] devlink: implement flash " Jiri Pirko
2019-05-23 17:57 ` Jakub Kicinski
2019-05-24 8:14 ` Jiri Pirko
2019-05-23 18:37 ` [patch net-next 0/7] expose flash update status to user Saeed Mahameed
2019-05-24 8:15 ` Jiri Pirko
2019-05-24 15:04 ` David Ahern
2019-05-28 11:29 ` Jiri Pirko
2019-05-27 18:14 ` Florian Fainelli
2019-05-28 8:55 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524170852.4fea5e77@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=jiri@resnulli.us \
--cc=leon@kernel.org \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).