[PATCH net-next] r8169: silence sparse warning in rtl8169_start_xmit

[PATCH net-next] r8169: silence sparse warning in rtl8169_start_xmit

[Heiner Kallweit]

The opts[] array is of type u32. Therefore remove the wrong
cpu_to_le32(). The opts[] array members are converted to little endian
later when being assigned to the respective descriptor fields.

This is not a new issue, it just popped up due to r8169.c having
been renamed and more thoroughly checked. Due to the renaming
this patch applies to net-next only.

Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/net/ethernet/realtek/r8169_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index d34cc855f..8b7d45ff1 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -5621,7 +5621,7 @@ static netdev_tx_t rtl8169_start_xmit(struct sk_buff *skb,
 	if (unlikely(le32_to_cpu(txd->opts1) & DescOwn))
 		goto err_stop_0;
 
-	opts[1] = cpu_to_le32(rtl8169_tx_vlan_tag(skb));
+	opts[1] = rtl8169_tx_vlan_tag(skb);
 	opts[0] = DescOwn;
 
 	if (rtl_chip_supports_csum_v2(tp)) {
-- 
2.21.0

Re: [PATCH net-next] r8169: silence sparse warning in rtl8169_start_xmit

[David Miller]

From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Thu, 6 Jun 2019 07:49:17 +0200

> The opts[] array is of type u32. Therefore remove the wrong
> cpu_to_le32(). The opts[] array members are converted to little endian
> later when being assigned to the respective descriptor fields.
> 
> This is not a new issue, it just popped up due to r8169.c having
> been renamed and more thoroughly checked. Due to the renaming
> this patch applies to net-next only.
> 
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Applied.