* [PATCH 1/8] drivers: net: dsa: realtek: fix warning same module names
@ 2019-06-06 9:47 Anders Roxell
2019-06-06 12:50 ` Andrew Lunn
0 siblings, 1 reply; 3+ messages in thread
From: Anders Roxell @ 2019-06-06 9:47 UTC (permalink / raw)
To: andrew, vivien.didelot, f.fainelli, davem
Cc: marex, stefan, airlied, daniel, shawnguo, s.hauer, b.zolnierkie,
a.hajda, mchehab, p.zabel, hkallweit1, lee.jones, lgirdwood,
broonie, netdev, linux-kernel, dri-devel, linux-arm-kernel,
linux-fbdev, linux-media, Anders Roxell
When building with CONFIG_NET_DSA_REALTEK_SMI and CONFIG_REALTEK_PHY
enabled as loadable modules, we see the following warning:
warning: same module names found:
drivers/net/phy/realtek.ko
drivers/net/dsa/realtek.ko
Rework so the names matches the config fragment.
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
drivers/net/dsa/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/dsa/Makefile b/drivers/net/dsa/Makefile
index fefb6aaa82ba..dbe8352cf8a4 100644
--- a/drivers/net/dsa/Makefile
+++ b/drivers/net/dsa/Makefile
@@ -9,8 +9,8 @@ obj-$(CONFIG_NET_DSA_LANTIQ_GSWIP) += lantiq_gswip.o
obj-$(CONFIG_NET_DSA_MT7530) += mt7530.o
obj-$(CONFIG_NET_DSA_MV88E6060) += mv88e6060.o
obj-$(CONFIG_NET_DSA_QCA8K) += qca8k.o
-obj-$(CONFIG_NET_DSA_REALTEK_SMI) += realtek.o
-realtek-objs := realtek-smi.o rtl8366.o rtl8366rb.o
+obj-$(CONFIG_NET_DSA_REALTEK_SMI) += dsa-realtek-smi.o
+dsa-realtek-smi-objs := realtek-smi.o rtl8366.o rtl8366rb.o
obj-$(CONFIG_NET_DSA_SMSC_LAN9303) += lan9303-core.o
obj-$(CONFIG_NET_DSA_SMSC_LAN9303_I2C) += lan9303_i2c.o
obj-$(CONFIG_NET_DSA_SMSC_LAN9303_MDIO) += lan9303_mdio.o
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/8] drivers: net: dsa: realtek: fix warning same module names
2019-06-06 9:47 [PATCH 1/8] drivers: net: dsa: realtek: fix warning same module names Anders Roxell
@ 2019-06-06 12:50 ` Andrew Lunn
2019-06-07 23:21 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Lunn @ 2019-06-06 12:50 UTC (permalink / raw)
To: Anders Roxell, Linus Walleij
Cc: vivien.didelot, f.fainelli, davem, hkallweit1, netdev
On Thu, Jun 06, 2019 at 11:47:07AM +0200, Anders Roxell wrote:
> When building with CONFIG_NET_DSA_REALTEK_SMI and CONFIG_REALTEK_PHY
> enabled as loadable modules, we see the following warning:
>
> warning: same module names found:
> drivers/net/phy/realtek.ko
> drivers/net/dsa/realtek.ko
>
> Rework so the names matches the config fragment.
>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
[Removes most of the Cc:]
Hi Anders
Please base this patch on net-next and submit it to David
Miller/netdev.
It would also be nice to state the new name of the module in the
commit message.
Linus, would you prefer this module is called rtl8366?
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/8] drivers: net: dsa: realtek: fix warning same module names
2019-06-06 12:50 ` Andrew Lunn
@ 2019-06-07 23:21 ` Linus Walleij
0 siblings, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2019-06-07 23:21 UTC (permalink / raw)
To: Andrew Lunn
Cc: Anders Roxell, Vivien Didelot, Florian Fainelli, David S. Miller,
Heiner Kallweit, netdev
On Thu, Jun 6, 2019 at 2:50 PM Andrew Lunn <andrew@lunn.ch> wrote:
> On Thu, Jun 06, 2019 at 11:47:07AM +0200, Anders Roxell wrote:
> > When building with CONFIG_NET_DSA_REALTEK_SMI and CONFIG_REALTEK_PHY
> > enabled as loadable modules, we see the following warning:
> >
> > warning: same module names found:
> > drivers/net/phy/realtek.ko
> > drivers/net/dsa/realtek.ko
> >
> > Rework so the names matches the config fragment.
> >
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>
> [Removes most of the Cc:]
>
> Hi Anders
>
> Please base this patch on net-next and submit it to David
> Miller/netdev.
>
> It would also be nice to state the new name of the module in the
> commit message.
>
> Linus, would you prefer this module is called rtl8366?
Yes that should be unique enough!
Anders: thanks for looking into this. I just always compiled
all modules as y.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-07 23:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-06 9:47 [PATCH 1/8] drivers: net: dsa: realtek: fix warning same module names Anders Roxell
2019-06-06 12:50 ` Andrew Lunn
2019-06-07 23:21 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).