* [PATCH 6/8] drivers: net: phy: fix warning same module names
@ 2019-06-06 9:47 Anders Roxell
2019-06-06 12:58 ` Andrew Lunn
0 siblings, 1 reply; 5+ messages in thread
From: Anders Roxell @ 2019-06-06 9:47 UTC (permalink / raw)
To: andrew, f.fainelli, hkallweit1, davem
Cc: vivien.didelot, marex, stefan, airlied, daniel, shawnguo,
s.hauer, b.zolnierkie, a.hajda, mchehab, p.zabel, lee.jones,
lgirdwood, broonie, netdev, linux-kernel, dri-devel,
linux-arm-kernel, linux-fbdev, linux-media, Anders Roxell
When building with CONFIG_ASIX_PHY and CONFIG_USB_NET_AX8817X enabled as
loadable modules, we see the following warning:
warning: same module names found:
drivers/net/phy/asix.ko
drivers/net/usb/asix.ko
Rework so media coda matches the config fragment. Leaving
CONFIG_USB_NET_AX8817X as is since thats a well known module.
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
drivers/net/phy/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/Makefile b/drivers/net/phy/Makefile
index 947c974bc69e..bab179b75a2a 100644
--- a/drivers/net/phy/Makefile
+++ b/drivers/net/phy/Makefile
@@ -52,7 +52,8 @@ ifdef CONFIG_HWMON
aquantia-objs += aquantia_hwmon.o
endif
obj-$(CONFIG_AQUANTIA_PHY) += aquantia.o
-obj-$(CONFIG_ASIX_PHY) += asix.o
+obj-$(CONFIG_ASIX_PHY) += asix-phy.o
+asix-phy-objs := asix.o
obj-$(CONFIG_AT803X_PHY) += at803x.o
obj-$(CONFIG_BCM63XX_PHY) += bcm63xx.o
obj-$(CONFIG_BCM7XXX_PHY) += bcm7xxx.o
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 6/8] drivers: net: phy: fix warning same module names
2019-06-06 9:47 [PATCH 6/8] drivers: net: phy: fix warning same module names Anders Roxell
@ 2019-06-06 12:58 ` Andrew Lunn
2019-06-07 0:34 ` Michael Schmitz
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Lunn @ 2019-06-06 12:58 UTC (permalink / raw)
To: Michael Schmitz, Anders Roxell; +Cc: f.fainelli, hkallweit1, davem, netdev
On Thu, Jun 06, 2019 at 11:47:26AM +0200, Anders Roxell wrote:
> When building with CONFIG_ASIX_PHY and CONFIG_USB_NET_AX8817X enabled as
> loadable modules, we see the following warning:
>
> warning: same module names found:
> drivers/net/phy/asix.ko
> drivers/net/usb/asix.ko
>
> Rework so media coda matches the config fragment. Leaving
No media coda here.
> CONFIG_USB_NET_AX8817X as is since thats a well known module.
Again, place base on net-next and submit to just netdev.
Please rename the PHY driver asix88796.
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 6/8] drivers: net: phy: fix warning same module names
2019-06-06 12:58 ` Andrew Lunn
@ 2019-06-07 0:34 ` Michael Schmitz
2019-06-07 1:59 ` Andrew Lunn
0 siblings, 1 reply; 5+ messages in thread
From: Michael Schmitz @ 2019-06-07 0:34 UTC (permalink / raw)
To: Andrew Lunn, Anders Roxell; +Cc: f.fainelli, hkallweit1, davem, netdev
Hi Andew, Anders,
sorry I dropped the ball on that one - I've got a patch for the ax88796b
PHY driver that I just forgot to resend.
It'll clash with your patch, Anders - are you happy to drop the
CONFIG_ASIX_PHY from your series?
Cheers,
Michael
On 7/06/19 12:58 AM, Andrew Lunn wrote:
> On Thu, Jun 06, 2019 at 11:47:26AM +0200, Anders Roxell wrote:
>> When building with CONFIG_ASIX_PHY and CONFIG_USB_NET_AX8817X enabled as
>> loadable modules, we see the following warning:
>>
>> warning: same module names found:
>> drivers/net/phy/asix.ko
>> drivers/net/usb/asix.ko
>>
>> Rework so media coda matches the config fragment. Leaving
> No media coda here.
>
>> CONFIG_USB_NET_AX8817X as is since thats a well known module.
> Again, place base on net-next and submit to just netdev.
>
> Please rename the PHY driver asix88796.
>
> Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 6/8] drivers: net: phy: fix warning same module names
2019-06-07 0:34 ` Michael Schmitz
@ 2019-06-07 1:59 ` Andrew Lunn
2019-06-07 5:38 ` Michael Schmitz
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Lunn @ 2019-06-07 1:59 UTC (permalink / raw)
To: Michael Schmitz; +Cc: Anders Roxell, f.fainelli, hkallweit1, davem, netdev
On Fri, Jun 07, 2019 at 12:34:47PM +1200, Michael Schmitz wrote:
> Hi Andew, Anders,
>
> sorry I dropped the ball on that one - I've got a patch for the ax88796b PHY
> driver that I just forgot to resend.
>
> It'll clash with your patch, Anders - are you happy to drop the
> CONFIG_ASIX_PHY from your series?
Hi Michael
Please send your patch. Anders needs to split up his patchset anyway,
so dropping one is not a problem.
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 6/8] drivers: net: phy: fix warning same module names
2019-06-07 1:59 ` Andrew Lunn
@ 2019-06-07 5:38 ` Michael Schmitz
0 siblings, 0 replies; 5+ messages in thread
From: Michael Schmitz @ 2019-06-07 5:38 UTC (permalink / raw)
To: Andrew Lunn; +Cc: Anders Roxell, f.fainelli, hkallweit1, davem, netdev
Hi Andrew,
Am 07.06.2019 um 13:59 schrieb Andrew Lunn:
> On Fri, Jun 07, 2019 at 12:34:47PM +1200, Michael Schmitz wrote:
>> Hi Andew, Anders,
>>
>> sorry I dropped the ball on that one - I've got a patch for the ax88796b PHY
>> driver that I just forgot to resend.
>>
>> It'll clash with your patch, Anders - are you happy to drop the
>> CONFIG_ASIX_PHY from your series?
>
> Hi Michael
>
> Please send your patch. Anders needs to split up his patchset anyway,
> so dropping one is not a problem.
Done, thanks for your feedback.
Cheers,
Michael
>
> Andrew
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-07 5:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-06 9:47 [PATCH 6/8] drivers: net: phy: fix warning same module names Anders Roxell
2019-06-06 12:58 ` Andrew Lunn
2019-06-07 0:34 ` Michael Schmitz
2019-06-07 1:59 ` Andrew Lunn
2019-06-07 5:38 ` Michael Schmitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).