* [PATCH net-next] net: mscc: ocelot: remove unused variable 'vcap_data_t'
@ 2019-06-06 14:46 YueHaibing
2019-06-06 18:37 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-06-06 14:46 UTC (permalink / raw)
To: alexandre.belloni, UNGLinuxDriver, davem; +Cc: linux-kernel, netdev, YueHaibing
Fix sparse warning:
drivers/net/ethernet/mscc/ocelot_ace.c:96:3:
warning: symbol 'vcap_data_t' was not declared. Should it be static?
'vcap_data_t' never used so can be removed
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/mscc/ocelot_ace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mscc/ocelot_ace.c b/drivers/net/ethernet/mscc/ocelot_ace.c
index 34d8260..f74b98f 100644
--- a/drivers/net/ethernet/mscc/ocelot_ace.c
+++ b/drivers/net/ethernet/mscc/ocelot_ace.c
@@ -93,7 +93,7 @@ struct vcap_data {
u32 counter_offset; /* Current counter offset */
u32 tg_value; /* Current type-group value */
u32 tg_mask; /* Current type-group mask */
-} vcap_data_t;
+};
static u32 vcap_s2_read_update_ctrl(struct ocelot *oc)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: mscc: ocelot: remove unused variable 'vcap_data_t'
2019-06-06 14:46 [PATCH net-next] net: mscc: ocelot: remove unused variable 'vcap_data_t' YueHaibing
@ 2019-06-06 18:37 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-06-06 18:37 UTC (permalink / raw)
To: yuehaibing; +Cc: alexandre.belloni, UNGLinuxDriver, linux-kernel, netdev
From: YueHaibing <yuehaibing@huawei.com>
Date: Thu, 6 Jun 2019 22:46:49 +0800
> Fix sparse warning:
>
> drivers/net/ethernet/mscc/ocelot_ace.c:96:3:
> warning: symbol 'vcap_data_t' was not declared. Should it be static?
>
> 'vcap_data_t' never used so can be removed
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied. I am pretty sure this was meant to be a typedef.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-06 18:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-06 14:46 [PATCH net-next] net: mscc: ocelot: remove unused variable 'vcap_data_t' YueHaibing
2019-06-06 18:37 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).