[PATCH net-next 1/1] net: phy: broadcom: Add genphy_suspend and genphy_resume for BCM5464

[PATCH net-next 1/1] net: phy: broadcom: Add genphy_suspend and genphy_resume for BCM5464

[Vladimir Oltean]

This puts the quad PHY ports in power-down mode when the PHY transitions
to the PHY_HALTED state.  It is likely that all the other PHYs support
the BMCR_PDOWN bit, but I only have the BCM5464R to test.

Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
---
 drivers/net/phy/broadcom.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c
index 67fa05d67523..937d0059e8ac 100644
--- a/drivers/net/phy/broadcom.c
+++ b/drivers/net/phy/broadcom.c
@@ -663,6 +663,8 @@ static struct phy_driver broadcom_drivers[] = {
 	.config_init	= bcm54xx_config_init,
 	.ack_interrupt	= bcm_phy_ack_intr,
 	.config_intr	= bcm_phy_config_intr,
+	.suspend	= genphy_suspend,
+	.resume		= genphy_resume,
 }, {
 	.phy_id		= PHY_ID_BCM5481,
 	.phy_id_mask	= 0xfffffff0,
-- 
2.17.1

Re: [PATCH net-next 1/1] net: phy: broadcom: Add genphy_suspend and genphy_resume for BCM5464

[Florian Fainelli]

On 6/8/2019 6:53 AM, Vladimir Oltean wrote:
> This puts the quad PHY ports in power-down mode when the PHY transitions
> to the PHY_HALTED state.  It is likely that all the other PHYs support
> the BMCR_PDOWN bit, but I only have the BCM5464R to test.

Yes, they should all support that low power mode, but like you, only
have a limited subset to work with.

> 
> Signed-off-by: Vladimir Oltean <olteanv@gmail.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Re: [PATCH net-next 1/1] net: phy: broadcom: Add genphy_suspend and genphy_resume for BCM5464

[David Miller]

From: Vladimir Oltean <olteanv@gmail.com>
Date: Sat,  8 Jun 2019 16:53:56 +0300

> This puts the quad PHY ports in power-down mode when the PHY transitions
> to the PHY_HALTED state.  It is likely that all the other PHYs support
> the BMCR_PDOWN bit, but I only have the BCM5464R to test.
> 
> Signed-off-by: Vladimir Oltean <olteanv@gmail.com>

Applied.