* [PATCH] staging: isdn: hysdn: fix symbol 'hysdn_proc_entry' was not declared.
@ 2019-06-05 13:53 Valerio Genovese
2019-06-05 14:20 ` Greg KH
2019-06-09 10:59 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Valerio Genovese @ 2019-06-05 13:53 UTC (permalink / raw)
To: isdn, gregkh; +Cc: netdev, devel, linux-kernel, Valerio Genovese
This was reported by sparse:
drivers/staging/isdn/hysdn/hysdn_procconf.c:352:23: warning: symbol 'hysdn_proc_entry' was not declared. Should it be static?
Signed-off-by: Valerio Genovese <valerio.click@gmail.com>
---
drivers/staging/isdn/hysdn/hysdn_defs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/isdn/hysdn/hysdn_defs.h b/drivers/staging/isdn/hysdn/hysdn_defs.h
index cdac46a21692..a651686b1787 100644
--- a/drivers/staging/isdn/hysdn/hysdn_defs.h
+++ b/drivers/staging/isdn/hysdn/hysdn_defs.h
@@ -221,7 +221,7 @@ typedef struct hycapictrl_info hycapictrl_info;
/* exported vars */
/*****************/
extern hysdn_card *card_root; /* pointer to first card */
-
+extern struct proc_dir_entry *hysdn_proc_entry; /* hysdn subdir in /proc/net
/*************************/
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: isdn: hysdn: fix symbol 'hysdn_proc_entry' was not declared.
2019-06-05 13:53 [PATCH] staging: isdn: hysdn: fix symbol 'hysdn_proc_entry' was not declared Valerio Genovese
@ 2019-06-05 14:20 ` Greg KH
2019-06-09 10:59 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2019-06-05 14:20 UTC (permalink / raw)
To: Valerio Genovese; +Cc: isdn, netdev, devel, linux-kernel
On Wed, Jun 05, 2019 at 03:53:49PM +0200, Valerio Genovese wrote:
> This was reported by sparse:
> drivers/staging/isdn/hysdn/hysdn_procconf.c:352:23: warning: symbol 'hysdn_proc_entry' was not declared. Should it be static?
>
> Signed-off-by: Valerio Genovese <valerio.click@gmail.com>
> ---
> drivers/staging/isdn/hysdn/hysdn_defs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/isdn/hysdn/hysdn_defs.h b/drivers/staging/isdn/hysdn/hysdn_defs.h
> index cdac46a21692..a651686b1787 100644
> --- a/drivers/staging/isdn/hysdn/hysdn_defs.h
> +++ b/drivers/staging/isdn/hysdn/hysdn_defs.h
> @@ -221,7 +221,7 @@ typedef struct hycapictrl_info hycapictrl_info;
> /* exported vars */
> /*****************/
> extern hysdn_card *card_root; /* pointer to first card */
> -
> +extern struct proc_dir_entry *hysdn_proc_entry; /* hysdn subdir in /proc/net
>
>
> /*************************/
Shouldn't you also remove it from the place it was devlared as extern?
Also, this is code on its way out of the kernel, not a big deal to leave
it alone for now.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: isdn: hysdn: fix symbol 'hysdn_proc_entry' was not declared.
2019-06-05 13:53 [PATCH] staging: isdn: hysdn: fix symbol 'hysdn_proc_entry' was not declared Valerio Genovese
2019-06-05 14:20 ` Greg KH
@ 2019-06-09 10:59 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2019-06-09 10:59 UTC (permalink / raw)
To: Valerio Genovese; +Cc: isdn, netdev, devel, linux-kernel
On Wed, Jun 05, 2019 at 03:53:49PM +0200, Valerio Genovese wrote:
> This was reported by sparse:
> drivers/staging/isdn/hysdn/hysdn_procconf.c:352:23: warning: symbol 'hysdn_proc_entry' was not declared. Should it be static?
>
> Signed-off-by: Valerio Genovese <valerio.click@gmail.com>
> ---
> drivers/staging/isdn/hysdn/hysdn_defs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/isdn/hysdn/hysdn_defs.h b/drivers/staging/isdn/hysdn/hysdn_defs.h
> index cdac46a21692..a651686b1787 100644
> --- a/drivers/staging/isdn/hysdn/hysdn_defs.h
> +++ b/drivers/staging/isdn/hysdn/hysdn_defs.h
> @@ -221,7 +221,7 @@ typedef struct hycapictrl_info hycapictrl_info;
> /* exported vars */
> /*****************/
> extern hysdn_card *card_root; /* pointer to first card */
> -
> +extern struct proc_dir_entry *hysdn_proc_entry; /* hysdn subdir in /proc/net
I can not take drivers/staging/isdn patches until 5.3-rc1.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-09 10:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-05 13:53 [PATCH] staging: isdn: hysdn: fix symbol 'hysdn_proc_entry' was not declared Valerio Genovese
2019-06-05 14:20 ` Greg KH
2019-06-09 10:59 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).