[PATCH net-next] net: dsa: sja1105: Make two functions static

[PATCH net-next] net: dsa: sja1105: Make two functions static

[YueHaibing]

Fix sparse warnings:

drivers/net/dsa/sja1105/sja1105_main.c:1848:6:
 warning: symbol 'sja1105_port_rxtstamp' was not declared. Should it be static?
drivers/net/dsa/sja1105/sja1105_main.c:1869:6:
 warning: symbol 'sja1105_port_txtstamp' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/net/dsa/sja1105/sja1105_main.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c
index 81e1ba5..9395e8f 100644
--- a/drivers/net/dsa/sja1105/sja1105_main.c
+++ b/drivers/net/dsa/sja1105/sja1105_main.c
@@ -1845,8 +1845,8 @@ static void sja1105_rxtstamp_work(struct work_struct *work)
 }
 
 /* Called from dsa_skb_defer_rx_timestamp */
-bool sja1105_port_rxtstamp(struct dsa_switch *ds, int port,
-			   struct sk_buff *skb, unsigned int type)
+static bool sja1105_port_rxtstamp(struct dsa_switch *ds, int port,
+				  struct sk_buff *skb, unsigned int type)
 {
 	struct sja1105_private *priv = ds->priv;
 	struct sja1105_tagger_data *data = &priv->tagger_data;
@@ -1866,8 +1866,8 @@ bool sja1105_port_rxtstamp(struct dsa_switch *ds, int port,
  * the skb and have it available in DSA_SKB_CB in the .port_deferred_xmit
  * callback, where we will timestamp it synchronously.
  */
-bool sja1105_port_txtstamp(struct dsa_switch *ds, int port,
-			   struct sk_buff *skb, unsigned int type)
+static bool sja1105_port_txtstamp(struct dsa_switch *ds, int port,
+				  struct sk_buff *skb, unsigned int type)
 {
 	struct sja1105_private *priv = ds->priv;
 	struct sja1105_port *sp = &priv->ports[port];
-- 
2.7.4

Re: [PATCH net-next] net: dsa: sja1105: Make two functions static

[Vladimir Oltean]

On Tue, 11 Jun 2019 at 16:59, YueHaibing <yuehaibing@huawei.com> wrote:
>
> Fix sparse warnings:
>
> drivers/net/dsa/sja1105/sja1105_main.c:1848:6:
>  warning: symbol 'sja1105_port_rxtstamp' was not declared. Should it be static?
> drivers/net/dsa/sja1105/sja1105_main.c:1869:6:
>  warning: symbol 'sja1105_port_txtstamp' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/net/dsa/sja1105/sja1105_main.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c
> index 81e1ba5..9395e8f 100644
> --- a/drivers/net/dsa/sja1105/sja1105_main.c
> +++ b/drivers/net/dsa/sja1105/sja1105_main.c
> @@ -1845,8 +1845,8 @@ static void sja1105_rxtstamp_work(struct work_struct *work)
>  }
>
>  /* Called from dsa_skb_defer_rx_timestamp */
> -bool sja1105_port_rxtstamp(struct dsa_switch *ds, int port,
> -                          struct sk_buff *skb, unsigned int type)
> +static bool sja1105_port_rxtstamp(struct dsa_switch *ds, int port,
> +                                 struct sk_buff *skb, unsigned int type)
>  {
>         struct sja1105_private *priv = ds->priv;
>         struct sja1105_tagger_data *data = &priv->tagger_data;
> @@ -1866,8 +1866,8 @@ bool sja1105_port_rxtstamp(struct dsa_switch *ds, int port,
>   * the skb and have it available in DSA_SKB_CB in the .port_deferred_xmit
>   * callback, where we will timestamp it synchronously.
>   */
> -bool sja1105_port_txtstamp(struct dsa_switch *ds, int port,
> -                          struct sk_buff *skb, unsigned int type)
> +static bool sja1105_port_txtstamp(struct dsa_switch *ds, int port,
> +                                 struct sk_buff *skb, unsigned int type)
>  {
>         struct sja1105_private *priv = ds->priv;
>         struct sja1105_port *sp = &priv->ports[port];
> --
> 2.7.4
>
>

Tested-by: Vladimir Oltean <olteanv@gmail.com>

Thanks!
-Vladimir

Re: [PATCH net-next] net: dsa: sja1105: Make two functions static

[David Miller]

From: YueHaibing <yuehaibing@huawei.com>
Date: Tue, 11 Jun 2019 21:58:34 +0800

> Fix sparse warnings:
> 
> drivers/net/dsa/sja1105/sja1105_main.c:1848:6:
>  warning: symbol 'sja1105_port_rxtstamp' was not declared. Should it be static?
> drivers/net/dsa/sja1105/sja1105_main.c:1869:6:
>  warning: symbol 'sja1105_port_txtstamp' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied.