* [PATCH net-next] qede: Make two functions static
@ 2019-06-11 14:07 YueHaibing
2019-06-13 20:59 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-06-11 14:07 UTC (permalink / raw)
To: davem, aelior, GR-everest-linux-l2; +Cc: linux-kernel, netdev, YueHaibing
Fix sparse warning:
drivers/net/ethernet/qlogic/qede/qede_main.c:963:6:
warning: symbol 'qede_lock' was not declared. Should it be static?
drivers/net/ethernet/qlogic/qede/qede_main.c:969:6:
warning: symbol 'qede_unlock' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/qlogic/qede/qede_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c
index 741377b..d4a2966 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_main.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_main.c
@@ -960,13 +960,13 @@ void __qede_unlock(struct qede_dev *edev)
/* This version of the lock should be used when acquiring the RTNL lock is also
* needed in addition to the internal qede lock.
*/
-void qede_lock(struct qede_dev *edev)
+static void qede_lock(struct qede_dev *edev)
{
rtnl_lock();
__qede_lock(edev);
}
-void qede_unlock(struct qede_dev *edev)
+static void qede_unlock(struct qede_dev *edev)
{
__qede_unlock(edev);
rtnl_unlock();
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] qede: Make two functions static
2019-06-11 14:07 [PATCH net-next] qede: Make two functions static YueHaibing
@ 2019-06-13 20:59 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-06-13 20:59 UTC (permalink / raw)
To: yuehaibing; +Cc: aelior, GR-everest-linux-l2, linux-kernel, netdev
From: YueHaibing <yuehaibing@huawei.com>
Date: Tue, 11 Jun 2019 22:07:09 +0800
> Fix sparse warning:
>
> drivers/net/ethernet/qlogic/qede/qede_main.c:963:6:
> warning: symbol 'qede_lock' was not declared. Should it be static?
> drivers/net/ethernet/qlogic/qede/qede_main.c:969:6:
> warning: symbol 'qede_unlock' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-13 20:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-11 14:07 [PATCH net-next] qede: Make two functions static YueHaibing
2019-06-13 20:59 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).