* [RFC PATCH linux-next] net: dsa: sja1105: sja1105_port_txtstamp() can be static
2019-06-12 13:32 [linux-next:master 4948/6049] drivers/net/dsa/sja1105/sja1105_main.c:1718:6: sparse: sparse: symbol 'sja1105_port_txtstamp' was not declared. Should it be static? kbuild test robot
@ 2019-06-12 13:32 ` kbuild test robot
0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2019-06-12 13:32 UTC (permalink / raw)
To: Vladimir Oltean
Cc: kbuild-all, Andrew Lunn, Vivien Didelot, Florian Fainelli,
linux-kernel, netdev
Fixes: 47ed985e97f5 ("net: dsa: sja1105: Add logic for TX timestamping")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
sja1105_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c
index 121cecc..6112ab50 100644
--- a/drivers/net/dsa/sja1105/sja1105_main.c
+++ b/drivers/net/dsa/sja1105/sja1105_main.c
@@ -1715,8 +1715,8 @@ static int sja1105_set_ageing_time(struct dsa_switch *ds,
* the skb and have it available in DSA_SKB_CB in the .port_deferred_xmit
* callback, where we will timestamp it synchronously.
*/
-bool sja1105_port_txtstamp(struct dsa_switch *ds, int port,
- struct sk_buff *skb, unsigned int type)
+static bool sja1105_port_txtstamp(struct dsa_switch *ds, int port,
+ struct sk_buff *skb, unsigned int type)
{
struct sja1105_private *priv = ds->priv;
struct sja1105_port *sp = &priv->ports[port];
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [linux-next:master 4948/6049] drivers/net/dsa/sja1105/sja1105_main.c:1718:6: sparse: sparse: symbol 'sja1105_port_txtstamp' was not declared. Should it be static?
@ 2019-06-12 13:32 kbuild test robot
2019-06-12 13:32 ` [RFC PATCH linux-next] net: dsa: sja1105: sja1105_port_txtstamp() can be static kbuild test robot
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2019-06-12 13:32 UTC (permalink / raw)
To: Vladimir Oltean
Cc: kbuild-all, Andrew Lunn, Vivien Didelot, Florian Fainelli,
linux-kernel, netdev
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 81a72c79224f83af18e26dc0c599f917312e6c78
commit: 47ed985e97f513b7746270e8c5d1f3a3f959b2da [4948/6049] net: dsa: sja1105: Add logic for TX timestamping
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-rc1-7-g2b96cd8-dirty
git checkout 47ed985e97f513b7746270e8c5d1f3a3f959b2da
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/net/dsa/sja1105/sja1105_main.c:1718:6: sparse: sparse: symbol 'sja1105_port_txtstamp' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-12 13:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-12 13:32 [linux-next:master 4948/6049] drivers/net/dsa/sja1105/sja1105_main.c:1718:6: sparse: sparse: symbol 'sja1105_port_txtstamp' was not declared. Should it be static? kbuild test robot
2019-06-12 13:32 ` [RFC PATCH linux-next] net: dsa: sja1105: sja1105_port_txtstamp() can be static kbuild test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).