* [PATCH net-next] selftests/net: fix warnings in TFO key rotation selftest
@ 2019-06-16 17:15 Willem de Bruijn
2019-06-16 21:27 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Willem de Bruijn @ 2019-06-16 17:15 UTC (permalink / raw)
To: netdev; +Cc: davem, jbaron, Willem de Bruijn
From: Willem de Bruijn <willemb@google.com>
One warning each on signedness, unused variable and return type.
Fixes: 10fbcdd12aa2 ("selftests/net: add TFO key rotation selftest")
Signed-off-by: Willem de Bruijn <willemb@google.com>
---
tools/testing/selftests/net/tcp_fastopen_backup_key.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/net/tcp_fastopen_backup_key.c b/tools/testing/selftests/net/tcp_fastopen_backup_key.c
index 58bb77d9e7e1..9c55ec44fc43 100644
--- a/tools/testing/selftests/net/tcp_fastopen_backup_key.c
+++ b/tools/testing/selftests/net/tcp_fastopen_backup_key.c
@@ -51,7 +51,7 @@ static const int PORT = 8891;
static void get_keys(int fd, uint32_t *keys)
{
char buf[128];
- int len = KEY_LENGTH * 2;
+ socklen_t len = KEY_LENGTH * 2;
if (do_sockopt) {
if (getsockopt(fd, SOL_TCP, TCP_FASTOPEN_KEY, keys, &len))
@@ -210,14 +210,13 @@ static bool is_listen_fd(int fd)
return false;
}
-static int rotate_key(int fd)
+static void rotate_key(int fd)
{
static int iter;
static uint32_t new_key[4];
uint32_t keys[8];
uint32_t tmp_key[4];
int i;
- int len = KEY_LENGTH * 2;
if (iter < N_LISTEN) {
/* first set new key as backups */
--
2.22.0.410.gd8fdbe21b5-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] selftests/net: fix warnings in TFO key rotation selftest
2019-06-16 17:15 [PATCH net-next] selftests/net: fix warnings in TFO key rotation selftest Willem de Bruijn
@ 2019-06-16 21:27 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-06-16 21:27 UTC (permalink / raw)
To: willemdebruijn.kernel; +Cc: netdev, jbaron, willemb
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: Sun, 16 Jun 2019 13:15:01 -0400
> From: Willem de Bruijn <willemb@google.com>
>
> One warning each on signedness, unused variable and return type.
>
> Fixes: 10fbcdd12aa2 ("selftests/net: add TFO key rotation selftest")
> Signed-off-by: Willem de Bruijn <willemb@google.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-16 21:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-16 17:15 [PATCH net-next] selftests/net: fix warnings in TFO key rotation selftest Willem de Bruijn
2019-06-16 21:27 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).