* Re: [PATCH] net: fddi: skfp: remove generic PCI defines from skfbi.h
2019-06-19 17:46 [PATCH] net: fddi: skfp: remove generic PCI defines from skfbi.h Puranjay Mohan
@ 2019-06-19 19:10 ` Bjorn Helgaas
2019-06-20 4:17 ` Puranjay Mohan
2019-06-21 2:35 ` kbuild test robot
2019-06-21 3:51 ` kbuild test robot
2 siblings, 1 reply; 6+ messages in thread
From: Bjorn Helgaas @ 2019-06-19 19:10 UTC (permalink / raw)
To: Puranjay Mohan
Cc: Shuah Khan, netdev, Linux Kernel Mailing List, Bjorn Helgaas,
linux-kernel-mentees
On Wed, Jun 19, 2019 at 12:48 PM Puranjay Mohan <puranjay12@gmail.com> wrote:
>
> skfbi.h defines its own copies of PCI_COMMAND, PCI_STATUS, etc.
> remove them in favor of the generic definitions in
> include/uapi/linux/pci_regs.h
1) Since you're sending several related patches, send them as a
"series" with a cover letter, e.g.,
[PATCH v2 0/2] Use PCI generic definitions instead of private duplicates
[PATCH v2 1/2] Include generic PCI definitions
[PATCH v2 2/2] Remove unused private PCI definitions
Patches 1/2 and 2/2 should be replies to the 0/2 cover letter. "git
send-email" will do this for you if you figure out the right options.
2) Make sure all your subject lines match. One started with "Include"
and the other with "remove". They should both be capitalized.
3) Start sentences with a capital letter, i.e., "Remove them" above.
4) This commit log needs to explicitly say that you're removing
*unused* symbols. Since they're unused, you don't even need to refer
to pci_regs.h.
5) "git grep PCI_ drivers/net/fddi/skfp" says there are many more
unused PCI symbols than just the ones below. I would just remove them
all at once.
6) Obviously you should compile this to make sure it builds. It must
build cleanly after every patch, not just at the end. I assume you've
done this already.
7) Please cc: linux-pci@vger.kernel.org since you're making PCI-related changes.
> Signed-off-by: Puranjay Mohan <puranjay12@gmail.com>
> ---
> drivers/net/fddi/skfp/h/skfbi.h | 23 -----------------------
> 1 file changed, 23 deletions(-)
>
> diff --git a/drivers/net/fddi/skfp/h/skfbi.h b/drivers/net/fddi/skfp/h/skfbi.h
> index 89557457b352..ed144a8e78d1 100644
> --- a/drivers/net/fddi/skfp/h/skfbi.h
> +++ b/drivers/net/fddi/skfp/h/skfbi.h
> @@ -27,29 +27,6 @@
> /*
> * Configuration Space header
> */
> -#define PCI_VENDOR_ID 0x00 /* 16 bit Vendor ID */
> -#define PCI_DEVICE_ID 0x02 /* 16 bit Device ID */
> -#define PCI_COMMAND 0x04 /* 16 bit Command */
> -#define PCI_STATUS 0x06 /* 16 bit Status */
> -#define PCI_REV_ID 0x08 /* 8 bit Revision ID */
> -#define PCI_CLASS_CODE 0x09 /* 24 bit Class Code */
> -#define PCI_CACHE_LSZ 0x0c /* 8 bit Cache Line Size */
> -#define PCI_LAT_TIM 0x0d /* 8 bit Latency Timer */
> -#define PCI_HEADER_T 0x0e /* 8 bit Header Type */
> -#define PCI_BIST 0x0f /* 8 bit Built-in selftest */
> -#define PCI_BASE_1ST 0x10 /* 32 bit 1st Base address */
> -#define PCI_BASE_2ND 0x14 /* 32 bit 2nd Base address */
> -/* Byte 18..2b: Reserved */
> -#define PCI_SUB_VID 0x2c /* 16 bit Subsystem Vendor ID */
> -#define PCI_SUB_ID 0x2e /* 16 bit Subsystem ID */
> -#define PCI_BASE_ROM 0x30 /* 32 bit Expansion ROM Base Address */
> -/* Byte 34..33: Reserved */
> -#define PCI_CAP_PTR 0x34 /* 8 bit (ML) Capabilities Ptr */
> -/* Byte 35..3b: Reserved */
> -#define PCI_IRQ_LINE 0x3c /* 8 bit Interrupt Line */
> -#define PCI_IRQ_PIN 0x3d /* 8 bit Interrupt Pin */
> -#define PCI_MIN_GNT 0x3e /* 8 bit Min_Gnt */
> -#define PCI_MAX_LAT 0x3f /* 8 bit Max_Lat */
> /* Device Dependent Region */
> #define PCI_OUR_REG 0x40 /* 32 bit (DV) Our Register */
> #define PCI_OUR_REG_1 0x40 /* 32 bit (ML) Our Register 1 */
> --
> 2.21.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net: fddi: skfp: remove generic PCI defines from skfbi.h
2019-06-19 19:10 ` Bjorn Helgaas
@ 2019-06-20 4:17 ` Puranjay Mohan
0 siblings, 0 replies; 6+ messages in thread
From: Puranjay Mohan @ 2019-06-20 4:17 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Shuah Khan, netdev, Linux Kernel Mailing List, linux-kernel-mentees
On Wed, Jun 19, 2019 at 02:10:22PM -0500, Bjorn Helgaas wrote:
> On Wed, Jun 19, 2019 at 12:48 PM Puranjay Mohan <puranjay12@gmail.com> wrote:
> >
> > skfbi.h defines its own copies of PCI_COMMAND, PCI_STATUS, etc.
> > remove them in favor of the generic definitions in
> > include/uapi/linux/pci_regs.h
>
> 1) Since you're sending several related patches, send them as a
> "series" with a cover letter, e.g.,
>
> [PATCH v2 0/2] Use PCI generic definitions instead of private duplicates
> [PATCH v2 1/2] Include generic PCI definitions
> [PATCH v2 2/2] Remove unused private PCI definitions
>
> Patches 1/2 and 2/2 should be replies to the 0/2 cover letter. "git
> send-email" will do this for you if you figure out the right options.
>
> 2) Make sure all your subject lines match. One started with "Include"
> and the other with "remove". They should both be capitalized.
>
> 3) Start sentences with a capital letter, i.e., "Remove them" above.
>
> 4) This commit log needs to explicitly say that you're removing
> *unused* symbols. Since they're unused, you don't even need to refer
> to pci_regs.h.
>
> 5) "git grep PCI_ drivers/net/fddi/skfp" says there are many more
> unused PCI symbols than just the ones below. I would just remove them
> all at once.
>
> 6) Obviously you should compile this to make sure it builds. It must
> build cleanly after every patch, not just at the end. I assume you've
> done this already.
>
Yes, I build the driver after every change and I do it again before
sending the patch to be sure that it works.
> 7) Please cc: linux-pci@vger.kernel.org since you're making PCI-related changes.
>
sure.
> > Signed-off-by: Puranjay Mohan <puranjay12@gmail.com>
> > ---
> > drivers/net/fddi/skfp/h/skfbi.h | 23 -----------------------
> > 1 file changed, 23 deletions(-)
> >
> > diff --git a/drivers/net/fddi/skfp/h/skfbi.h b/drivers/net/fddi/skfp/h/skfbi.h
> > index 89557457b352..ed144a8e78d1 100644
> > --- a/drivers/net/fddi/skfp/h/skfbi.h
> > +++ b/drivers/net/fddi/skfp/h/skfbi.h
> > @@ -27,29 +27,6 @@
> > /*
> > * Configuration Space header
> > */
> > -#define PCI_VENDOR_ID 0x00 /* 16 bit Vendor ID */
> > -#define PCI_DEVICE_ID 0x02 /* 16 bit Device ID */
> > -#define PCI_COMMAND 0x04 /* 16 bit Command */
> > -#define PCI_STATUS 0x06 /* 16 bit Status */
> > -#define PCI_REV_ID 0x08 /* 8 bit Revision ID */
> > -#define PCI_CLASS_CODE 0x09 /* 24 bit Class Code */
> > -#define PCI_CACHE_LSZ 0x0c /* 8 bit Cache Line Size */
> > -#define PCI_LAT_TIM 0x0d /* 8 bit Latency Timer */
> > -#define PCI_HEADER_T 0x0e /* 8 bit Header Type */
> > -#define PCI_BIST 0x0f /* 8 bit Built-in selftest */
> > -#define PCI_BASE_1ST 0x10 /* 32 bit 1st Base address */
> > -#define PCI_BASE_2ND 0x14 /* 32 bit 2nd Base address */
> > -/* Byte 18..2b: Reserved */
> > -#define PCI_SUB_VID 0x2c /* 16 bit Subsystem Vendor ID */
> > -#define PCI_SUB_ID 0x2e /* 16 bit Subsystem ID */
> > -#define PCI_BASE_ROM 0x30 /* 32 bit Expansion ROM Base Address */
> > -/* Byte 34..33: Reserved */
> > -#define PCI_CAP_PTR 0x34 /* 8 bit (ML) Capabilities Ptr */
> > -/* Byte 35..3b: Reserved */
> > -#define PCI_IRQ_LINE 0x3c /* 8 bit Interrupt Line */
> > -#define PCI_IRQ_PIN 0x3d /* 8 bit Interrupt Pin */
> > -#define PCI_MIN_GNT 0x3e /* 8 bit Min_Gnt */
> > -#define PCI_MAX_LAT 0x3f /* 8 bit Max_Lat */
> > /* Device Dependent Region */
> > #define PCI_OUR_REG 0x40 /* 32 bit (DV) Our Register */
> > #define PCI_OUR_REG_1 0x40 /* 32 bit (ML) Our Register 1 */
> > --
> > 2.21.0
> >
Thanks for the feedback!
I will send the patch series soon.
Thanks
--Puranjay
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net: fddi: skfp: remove generic PCI defines from skfbi.h
2019-06-19 17:46 [PATCH] net: fddi: skfp: remove generic PCI defines from skfbi.h Puranjay Mohan
2019-06-19 19:10 ` Bjorn Helgaas
@ 2019-06-21 2:35 ` kbuild test robot
2019-06-21 3:42 ` Puranjay Mohan
2019-06-21 3:51 ` kbuild test robot
2 siblings, 1 reply; 6+ messages in thread
From: kbuild test robot @ 2019-06-21 2:35 UTC (permalink / raw)
To: Puranjay Mohan
Cc: kbuild-all, Shuah Khan, Puranjay Mohan, netdev, linux-kernel,
Bjorn Helgaas, linux-kernel-mentees
[-- Attachment #1: Type: text/plain, Size: 15543 bytes --]
Hi Puranjay,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net/master]
[also build test ERROR on v5.2-rc5 next-20190620]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Puranjay-Mohan/net-fddi-skfp-remove-generic-PCI-defines-from-skfbi-h/20190621-081729
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=sparc64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
In file included from drivers/net/fddi/skfp/drvfbi.c:17:0:
drivers/net/fddi/skfp/drvfbi.c: In function 'card_start':
>> drivers/net/fddi/skfp/drvfbi.c:130:21: error: 'PCI_REV_ID' undeclared (first use in this function); did you mean 'PCI_DEVID'?
rev_id = inp(PCI_C(PCI_REV_ID)) ;
^
drivers/net/fddi/skfp/h/types.h:28:25: note: in definition of macro 'inp'
#define inp(p) ioread8(p)
^
>> drivers/net/fddi/skfp/h/skfbi.h:916:18: note: in expansion of macro 'ADDR'
#define PCI_C(a) ADDR(B3_CFG_SPC + (a)) /* PCI Config Space */
^~~~
>> drivers/net/fddi/skfp/drvfbi.c:130:15: note: in expansion of macro 'PCI_C'
rev_id = inp(PCI_C(PCI_REV_ID)) ;
^~~~~
drivers/net/fddi/skfp/drvfbi.c:130:21: note: each undeclared identifier is reported only once for each function it appears in
rev_id = inp(PCI_C(PCI_REV_ID)) ;
^
drivers/net/fddi/skfp/h/types.h:28:25: note: in definition of macro 'inp'
#define inp(p) ioread8(p)
^
>> drivers/net/fddi/skfp/h/skfbi.h:916:18: note: in expansion of macro 'ADDR'
#define PCI_C(a) ADDR(B3_CFG_SPC + (a)) /* PCI Config Space */
^~~~
>> drivers/net/fddi/skfp/drvfbi.c:130:15: note: in expansion of macro 'PCI_C'
rev_id = inp(PCI_C(PCI_REV_ID)) ;
^~~~~
vim +130 drivers/net/fddi/skfp/drvfbi.c
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 @17 #include "h/types.h"
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 18 #include "h/fddi.h"
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 19 #include "h/smc.h"
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 20 #include "h/supern_2.h"
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 21 #include "h/skfbiinc.h"
bc63eb9c drivers/net/skfp/drvfbi.c Akinobu Mita 2006-12-19 22 #include <linux/bitrev.h>
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 23
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 24 #ifndef lint
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 25 static const char ID_sccs[] = "@(#)drvfbi.c 1.63 99/02/11 (C) SK " ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 26 #endif
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 27
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 28 /*
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 29 * PCM active state
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 30 */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 31 #define PC8_ACTIVE 8
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 32
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 33 #define LED_Y_ON 0x11 /* Used for ring up/down indication */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 34 #define LED_Y_OFF 0x10
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 35
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 36
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 37 #define MS2BCLK(x) ((x)*12500L)
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 38
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 39 /*
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 40 * valid configuration values are:
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 41 */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 42
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 43 /*
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 44 * xPOS_ID:xxxx
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 45 * | \ /
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 46 * | \/
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 47 * | --------------------- the patched POS_ID of the Adapter
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 48 * | xxxx = (Vendor ID low byte,
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 49 * | Vendor ID high byte,
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 50 * | Device ID low byte,
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 51 * | Device ID high byte)
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 52 * +------------------------------ the patched oem_id must be
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 53 * 'S' for SK or 'I' for IBM
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 54 * this is a short id for the driver.
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 55 */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 56 #ifndef MULT_OEM
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 57 #ifndef OEM_CONCEPT
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 58 const u_char oem_id[] = "xPOS_ID:xxxx" ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 59 #else /* OEM_CONCEPT */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 60 const u_char oem_id[] = OEM_ID ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 61 #endif /* OEM_CONCEPT */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 62 #define ID_BYTE0 8
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 63 #define OEMID(smc,i) oem_id[ID_BYTE0 + i]
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 64 #else /* MULT_OEM */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 65 const struct s_oem_ids oem_ids[] = {
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 66 #include "oemids.h"
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 67 {0}
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 68 };
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 69 #define OEMID(smc,i) smc->hw.oem_id->oi_id[i]
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 70 #endif /* MULT_OEM */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 71
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 72 /* Prototypes of external functions */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 73 #ifdef AIX
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 74 extern int AIX_vpdReadByte() ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 75 #endif
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 76
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 77
7aa55fce drivers/net/skfp/drvfbi.c Adrian Bunk 2005-06-21 78 /* Prototype of a local function. */
7aa55fce drivers/net/skfp/drvfbi.c Adrian Bunk 2005-06-21 79 static void smt_stop_watchdog(struct s_smc *smc);
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 80
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 81 /*
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 82 * FDDI card reset
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 83 */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 84 static void card_start(struct s_smc *smc)
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 85 {
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 86 int i ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 87 #ifdef PCI
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 88 u_char rev_id ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 89 u_short word;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 90 #endif
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 91
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 92 smt_stop_watchdog(smc) ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 93
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 94 #ifdef PCI
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 95 /*
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 96 * make sure no transfer activity is pending
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 97 */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 98 outpw(FM_A(FM_MDREG1),FM_MINIT) ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 99 outp(ADDR(B0_CTRL), CTRL_HPI_SET) ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 100 hwt_wait_time(smc,hwt_quick_read(smc),MS2BCLK(10)) ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 101 /*
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 102 * now reset everything
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 103 */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 104 outp(ADDR(B0_CTRL),CTRL_RST_SET) ; /* reset for all chips */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 105 i = (int) inp(ADDR(B0_CTRL)) ; /* do dummy read */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 106 SK_UNUSED(i) ; /* Make LINT happy. */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 107 outp(ADDR(B0_CTRL), CTRL_RST_CLR) ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 108
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 109 /*
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 110 * Reset all bits in the PCI STATUS register
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 111 */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 112 outp(ADDR(B0_TST_CTRL), TST_CFG_WRITE_ON) ; /* enable for writes */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 113 word = inpw(PCI_C(PCI_STATUS)) ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 114 outpw(PCI_C(PCI_STATUS), word | PCI_ERRBITS) ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 115 outp(ADDR(B0_TST_CTRL), TST_CFG_WRITE_OFF) ; /* disable writes */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 116
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 117 /*
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 118 * Release the reset of all the State machines
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 119 * Release Master_Reset
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 120 * Release HPI_SM_Reset
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 121 */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 122 outp(ADDR(B0_CTRL), CTRL_MRST_CLR|CTRL_HPI_CLR) ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 123
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 124 /*
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 125 * determine the adapter type
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 126 * Note: Do it here, because some drivers may call card_start() once
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 127 * at very first before any other initialization functions is
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 128 * executed.
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 129 */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 @130 rev_id = inp(PCI_C(PCI_REV_ID)) ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 131 if ((rev_id & 0xf0) == SK_ML_ID_1 || (rev_id & 0xf0) == SK_ML_ID_2) {
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 132 smc->hw.hw_is_64bit = TRUE ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 133 } else {
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 134 smc->hw.hw_is_64bit = FALSE ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 135 }
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 136
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 137 /*
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 138 * Watermark initialization
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 139 */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 140 if (!smc->hw.hw_is_64bit) {
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 141 outpd(ADDR(B4_R1_F), RX_WATERMARK) ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 142 outpd(ADDR(B5_XA_F), TX_WATERMARK) ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 143 outpd(ADDR(B5_XS_F), TX_WATERMARK) ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 144 }
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 145
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 146 outp(ADDR(B0_CTRL),CTRL_RST_CLR) ; /* clear the reset chips */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 147 outp(ADDR(B0_LED),LED_GA_OFF|LED_MY_ON|LED_GB_OFF) ; /* ye LED on */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 148
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 149 /* init the timer value for the watch dog 2,5 minutes */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 150 outpd(ADDR(B2_WDOG_INI),0x6FC23AC0) ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 151
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 152 /* initialize the ISR mask */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 153 smc->hw.is_imask = ISR_MASK ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 154 smc->hw.hw_state = STOPPED ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 155 #endif
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 156 GET_PAGE(0) ; /* necessary for BOOT */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 157 }
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 158
:::::: The code at line 130 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 58075 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] net: fddi: skfp: remove generic PCI defines from skfbi.h
2019-06-21 2:35 ` kbuild test robot
@ 2019-06-21 3:42 ` Puranjay Mohan
0 siblings, 0 replies; 6+ messages in thread
From: Puranjay Mohan @ 2019-06-21 3:42 UTC (permalink / raw)
To: kbuild test robot
Cc: Shuah Khan, Puranjay Mohan, netdev, linux-kernel, Bjorn Helgaas,
linux-kernel-mentees
On Fri, Jun 21, 2019 at 10:35:04AM +0800, kbuild test robot wrote:
> Hi Puranjay,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on net/master]
> [also build test ERROR on v5.2-rc5 next-20190620]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Puranjay-Mohan/net-fddi-skfp-remove-generic-PCI-defines-from-skfbi-h/20190621-081729
> config: sparc64-allmodconfig (attached as .config)
> compiler: sparc64-linux-gcc (GCC) 7.4.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> GCC_VERSION=7.4.0 make.cross ARCH=sparc64
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All error/warnings (new ones prefixed by >>):
>
> In file included from drivers/net/fddi/skfp/drvfbi.c:17:0:
> drivers/net/fddi/skfp/drvfbi.c: In function 'card_start':
> >> drivers/net/fddi/skfp/drvfbi.c:130:21: error: 'PCI_REV_ID' undeclared (first use in this function); did you mean 'PCI_DEVID'?
> rev_id = inp(PCI_C(PCI_REV_ID)) ;
> ^
> drivers/net/fddi/skfp/h/types.h:28:25: note: in definition of macro 'inp'
> #define inp(p) ioread8(p)
> ^
> >> drivers/net/fddi/skfp/h/skfbi.h:916:18: note: in expansion of macro 'ADDR'
> #define PCI_C(a) ADDR(B3_CFG_SPC + (a)) /* PCI Config Space */
> ^~~~
> >> drivers/net/fddi/skfp/drvfbi.c:130:15: note: in expansion of macro 'PCI_C'
> rev_id = inp(PCI_C(PCI_REV_ID)) ;
> ^~~~~
> drivers/net/fddi/skfp/drvfbi.c:130:21: note: each undeclared identifier is reported only once for each function it appears in
> rev_id = inp(PCI_C(PCI_REV_ID)) ;
> ^
> drivers/net/fddi/skfp/h/types.h:28:25: note: in definition of macro 'inp'
> #define inp(p) ioread8(p)
> ^
> >> drivers/net/fddi/skfp/h/skfbi.h:916:18: note: in expansion of macro 'ADDR'
> #define PCI_C(a) ADDR(B3_CFG_SPC + (a)) /* PCI Config Space */
> ^~~~
> >> drivers/net/fddi/skfp/drvfbi.c:130:15: note: in expansion of macro 'PCI_C'
> rev_id = inp(PCI_C(PCI_REV_ID)) ;
> ^~~~~
>
> vim +130 drivers/net/fddi/skfp/drvfbi.c
>
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 @17 #include "h/types.h"
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 18 #include "h/fddi.h"
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 19 #include "h/smc.h"
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 20 #include "h/supern_2.h"
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 21 #include "h/skfbiinc.h"
> bc63eb9c drivers/net/skfp/drvfbi.c Akinobu Mita 2006-12-19 22 #include <linux/bitrev.h>
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 23
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 24 #ifndef lint
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 25 static const char ID_sccs[] = "@(#)drvfbi.c 1.63 99/02/11 (C) SK " ;
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 26 #endif
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 27
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 28 /*
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 29 * PCM active state
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 30 */
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 31 #define PC8_ACTIVE 8
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 32
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 33 #define LED_Y_ON 0x11 /* Used for ring up/down indication */
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 34 #define LED_Y_OFF 0x10
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 35
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 36
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 37 #define MS2BCLK(x) ((x)*12500L)
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 38
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 39 /*
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 40 * valid configuration values are:
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 41 */
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 42
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 43 /*
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 44 * xPOS_ID:xxxx
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 45 * | \ /
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 46 * | \/
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 47 * | --------------------- the patched POS_ID of the Adapter
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 48 * | xxxx = (Vendor ID low byte,
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 49 * | Vendor ID high byte,
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 50 * | Device ID low byte,
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 51 * | Device ID high byte)
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 52 * +------------------------------ the patched oem_id must be
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 53 * 'S' for SK or 'I' for IBM
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 54 * this is a short id for the driver.
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 55 */
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 56 #ifndef MULT_OEM
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 57 #ifndef OEM_CONCEPT
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 58 const u_char oem_id[] = "xPOS_ID:xxxx" ;
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 59 #else /* OEM_CONCEPT */
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 60 const u_char oem_id[] = OEM_ID ;
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 61 #endif /* OEM_CONCEPT */
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 62 #define ID_BYTE0 8
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 63 #define OEMID(smc,i) oem_id[ID_BYTE0 + i]
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 64 #else /* MULT_OEM */
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 65 const struct s_oem_ids oem_ids[] = {
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 66 #include "oemids.h"
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 67 {0}
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 68 };
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 69 #define OEMID(smc,i) smc->hw.oem_id->oi_id[i]
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 70 #endif /* MULT_OEM */
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 71
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 72 /* Prototypes of external functions */
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 73 #ifdef AIX
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 74 extern int AIX_vpdReadByte() ;
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 75 #endif
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 76
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 77
> 7aa55fce drivers/net/skfp/drvfbi.c Adrian Bunk 2005-06-21 78 /* Prototype of a local function. */
> 7aa55fce drivers/net/skfp/drvfbi.c Adrian Bunk 2005-06-21 79 static void smt_stop_watchdog(struct s_smc *smc);
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 80
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 81 /*
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 82 * FDDI card reset
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 83 */
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 84 static void card_start(struct s_smc *smc)
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 85 {
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 86 int i ;
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 87 #ifdef PCI
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 88 u_char rev_id ;
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 89 u_short word;
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 90 #endif
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 91
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 92 smt_stop_watchdog(smc) ;
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 93
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 94 #ifdef PCI
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 95 /*
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 96 * make sure no transfer activity is pending
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 97 */
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 98 outpw(FM_A(FM_MDREG1),FM_MINIT) ;
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 99 outp(ADDR(B0_CTRL), CTRL_HPI_SET) ;
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 100 hwt_wait_time(smc,hwt_quick_read(smc),MS2BCLK(10)) ;
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 101 /*
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 102 * now reset everything
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 103 */
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 104 outp(ADDR(B0_CTRL),CTRL_RST_SET) ; /* reset for all chips */
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 105 i = (int) inp(ADDR(B0_CTRL)) ; /* do dummy read */
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 106 SK_UNUSED(i) ; /* Make LINT happy. */
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 107 outp(ADDR(B0_CTRL), CTRL_RST_CLR) ;
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 108
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 109 /*
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 110 * Reset all bits in the PCI STATUS register
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 111 */
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 112 outp(ADDR(B0_TST_CTRL), TST_CFG_WRITE_ON) ; /* enable for writes */
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 113 word = inpw(PCI_C(PCI_STATUS)) ;
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 114 outpw(PCI_C(PCI_STATUS), word | PCI_ERRBITS) ;
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 115 outp(ADDR(B0_TST_CTRL), TST_CFG_WRITE_OFF) ; /* disable writes */
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 116
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 117 /*
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 118 * Release the reset of all the State machines
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 119 * Release Master_Reset
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 120 * Release HPI_SM_Reset
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 121 */
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 122 outp(ADDR(B0_CTRL), CTRL_MRST_CLR|CTRL_HPI_CLR) ;
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 123
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 124 /*
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 125 * determine the adapter type
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 126 * Note: Do it here, because some drivers may call card_start() once
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 127 * at very first before any other initialization functions is
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 128 * executed.
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 129 */
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 @130 rev_id = inp(PCI_C(PCI_REV_ID)) ;
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 131 if ((rev_id & 0xf0) == SK_ML_ID_1 || (rev_id & 0xf0) == SK_ML_ID_2) {
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 132 smc->hw.hw_is_64bit = TRUE ;
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 133 } else {
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 134 smc->hw.hw_is_64bit = FALSE ;
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 135 }
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 136
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 137 /*
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 138 * Watermark initialization
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 139 */
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 140 if (!smc->hw.hw_is_64bit) {
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 141 outpd(ADDR(B4_R1_F), RX_WATERMARK) ;
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 142 outpd(ADDR(B5_XA_F), TX_WATERMARK) ;
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 143 outpd(ADDR(B5_XS_F), TX_WATERMARK) ;
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 144 }
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 145
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 146 outp(ADDR(B0_CTRL),CTRL_RST_CLR) ; /* clear the reset chips */
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 147 outp(ADDR(B0_LED),LED_GA_OFF|LED_MY_ON|LED_GB_OFF) ; /* ye LED on */
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 148
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 149 /* init the timer value for the watch dog 2,5 minutes */
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 150 outpd(ADDR(B2_WDOG_INI),0x6FC23AC0) ;
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 151
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 152 /* initialize the ISR mask */
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 153 smc->hw.is_imask = ISR_MASK ;
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 154 smc->hw.hw_state = STOPPED ;
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 155 #endif
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 156 GET_PAGE(0) ; /* necessary for BOOT */
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 157 }
> ^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 158
>
> :::::: The code at line 130 was first introduced by commit
> :::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
>
> :::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
> :::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
I had sent two seperate patches where the second depended on the first,
I should have had sent them as patch series or made sure that individual
patches build by themselves. I have corrected this in V2.
My apologies for the same
--Puranjay Mohan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net: fddi: skfp: remove generic PCI defines from skfbi.h
2019-06-19 17:46 [PATCH] net: fddi: skfp: remove generic PCI defines from skfbi.h Puranjay Mohan
2019-06-19 19:10 ` Bjorn Helgaas
2019-06-21 2:35 ` kbuild test robot
@ 2019-06-21 3:51 ` kbuild test robot
2 siblings, 0 replies; 6+ messages in thread
From: kbuild test robot @ 2019-06-21 3:51 UTC (permalink / raw)
To: Puranjay Mohan
Cc: kbuild-all, Shuah Khan, Puranjay Mohan, netdev, linux-kernel,
Bjorn Helgaas, linux-kernel-mentees
[-- Attachment #1: Type: text/plain, Size: 15380 bytes --]
Hi Puranjay,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net/master]
[also build test ERROR on v5.2-rc5 next-20190620]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Puranjay-Mohan/net-fddi-skfp-remove-generic-PCI-defines-from-skfbi-h/20190621-081729
config: x86_64-randconfig-s4-06211045 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from drivers/net/fddi/skfp/drvfbi.c:17:0:
drivers/net/fddi/skfp/drvfbi.c: In function 'card_start':
>> drivers/net/fddi/skfp/drvfbi.c:130:21: error: 'PCI_REV_ID' undeclared (first use in this function); did you mean 'PCI_DEV_ID0'?
rev_id = inp(PCI_C(PCI_REV_ID)) ;
^
drivers/net/fddi/skfp/h/types.h:28:25: note: in definition of macro 'inp'
#define inp(p) ioread8(p)
^
drivers/net/fddi/skfp/h/skfbi.h:916:18: note: in expansion of macro 'ADDR'
#define PCI_C(a) ADDR(B3_CFG_SPC + (a)) /* PCI Config Space */
^~~~
drivers/net/fddi/skfp/drvfbi.c:130:15: note: in expansion of macro 'PCI_C'
rev_id = inp(PCI_C(PCI_REV_ID)) ;
^~~~~
drivers/net/fddi/skfp/drvfbi.c:130:21: note: each undeclared identifier is reported only once for each function it appears in
rev_id = inp(PCI_C(PCI_REV_ID)) ;
^
drivers/net/fddi/skfp/h/types.h:28:25: note: in definition of macro 'inp'
#define inp(p) ioread8(p)
^
drivers/net/fddi/skfp/h/skfbi.h:916:18: note: in expansion of macro 'ADDR'
#define PCI_C(a) ADDR(B3_CFG_SPC + (a)) /* PCI Config Space */
^~~~
drivers/net/fddi/skfp/drvfbi.c:130:15: note: in expansion of macro 'PCI_C'
rev_id = inp(PCI_C(PCI_REV_ID)) ;
^~~~~
vim +130 drivers/net/fddi/skfp/drvfbi.c
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 @17 #include "h/types.h"
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 18 #include "h/fddi.h"
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 19 #include "h/smc.h"
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 20 #include "h/supern_2.h"
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 21 #include "h/skfbiinc.h"
bc63eb9c drivers/net/skfp/drvfbi.c Akinobu Mita 2006-12-19 22 #include <linux/bitrev.h>
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 23
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 24 #ifndef lint
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 25 static const char ID_sccs[] = "@(#)drvfbi.c 1.63 99/02/11 (C) SK " ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 26 #endif
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 27
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 28 /*
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 29 * PCM active state
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 30 */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 31 #define PC8_ACTIVE 8
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 32
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 33 #define LED_Y_ON 0x11 /* Used for ring up/down indication */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 34 #define LED_Y_OFF 0x10
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 35
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 36
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 37 #define MS2BCLK(x) ((x)*12500L)
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 38
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 39 /*
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 40 * valid configuration values are:
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 41 */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 42
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 43 /*
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 44 * xPOS_ID:xxxx
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 45 * | \ /
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 46 * | \/
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 47 * | --------------------- the patched POS_ID of the Adapter
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 48 * | xxxx = (Vendor ID low byte,
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 49 * | Vendor ID high byte,
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 50 * | Device ID low byte,
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 51 * | Device ID high byte)
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 52 * +------------------------------ the patched oem_id must be
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 53 * 'S' for SK or 'I' for IBM
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 54 * this is a short id for the driver.
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 55 */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 56 #ifndef MULT_OEM
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 57 #ifndef OEM_CONCEPT
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 58 const u_char oem_id[] = "xPOS_ID:xxxx" ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 59 #else /* OEM_CONCEPT */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 60 const u_char oem_id[] = OEM_ID ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 61 #endif /* OEM_CONCEPT */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 62 #define ID_BYTE0 8
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 63 #define OEMID(smc,i) oem_id[ID_BYTE0 + i]
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 64 #else /* MULT_OEM */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 65 const struct s_oem_ids oem_ids[] = {
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 66 #include "oemids.h"
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 67 {0}
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 68 };
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 69 #define OEMID(smc,i) smc->hw.oem_id->oi_id[i]
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 70 #endif /* MULT_OEM */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 71
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 72 /* Prototypes of external functions */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 73 #ifdef AIX
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 74 extern int AIX_vpdReadByte() ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 75 #endif
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 76
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 77
7aa55fce drivers/net/skfp/drvfbi.c Adrian Bunk 2005-06-21 78 /* Prototype of a local function. */
7aa55fce drivers/net/skfp/drvfbi.c Adrian Bunk 2005-06-21 79 static void smt_stop_watchdog(struct s_smc *smc);
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 80
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 81 /*
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 82 * FDDI card reset
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 83 */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 84 static void card_start(struct s_smc *smc)
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 85 {
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 86 int i ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 87 #ifdef PCI
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 88 u_char rev_id ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 89 u_short word;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 90 #endif
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 91
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 92 smt_stop_watchdog(smc) ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 93
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 94 #ifdef PCI
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 95 /*
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 96 * make sure no transfer activity is pending
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 97 */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 98 outpw(FM_A(FM_MDREG1),FM_MINIT) ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 99 outp(ADDR(B0_CTRL), CTRL_HPI_SET) ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 100 hwt_wait_time(smc,hwt_quick_read(smc),MS2BCLK(10)) ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 101 /*
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 102 * now reset everything
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 103 */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 104 outp(ADDR(B0_CTRL),CTRL_RST_SET) ; /* reset for all chips */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 105 i = (int) inp(ADDR(B0_CTRL)) ; /* do dummy read */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 106 SK_UNUSED(i) ; /* Make LINT happy. */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 107 outp(ADDR(B0_CTRL), CTRL_RST_CLR) ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 108
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 109 /*
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 110 * Reset all bits in the PCI STATUS register
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 111 */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 112 outp(ADDR(B0_TST_CTRL), TST_CFG_WRITE_ON) ; /* enable for writes */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 113 word = inpw(PCI_C(PCI_STATUS)) ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 114 outpw(PCI_C(PCI_STATUS), word | PCI_ERRBITS) ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 115 outp(ADDR(B0_TST_CTRL), TST_CFG_WRITE_OFF) ; /* disable writes */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 116
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 117 /*
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 118 * Release the reset of all the State machines
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 119 * Release Master_Reset
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 120 * Release HPI_SM_Reset
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 121 */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 122 outp(ADDR(B0_CTRL), CTRL_MRST_CLR|CTRL_HPI_CLR) ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 123
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 124 /*
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 125 * determine the adapter type
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 126 * Note: Do it here, because some drivers may call card_start() once
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 127 * at very first before any other initialization functions is
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 128 * executed.
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 129 */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 @130 rev_id = inp(PCI_C(PCI_REV_ID)) ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 131 if ((rev_id & 0xf0) == SK_ML_ID_1 || (rev_id & 0xf0) == SK_ML_ID_2) {
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 132 smc->hw.hw_is_64bit = TRUE ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 133 } else {
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 134 smc->hw.hw_is_64bit = FALSE ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 135 }
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 136
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 137 /*
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 138 * Watermark initialization
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 139 */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 140 if (!smc->hw.hw_is_64bit) {
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 141 outpd(ADDR(B4_R1_F), RX_WATERMARK) ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 142 outpd(ADDR(B5_XA_F), TX_WATERMARK) ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 143 outpd(ADDR(B5_XS_F), TX_WATERMARK) ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 144 }
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 145
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 146 outp(ADDR(B0_CTRL),CTRL_RST_CLR) ; /* clear the reset chips */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 147 outp(ADDR(B0_LED),LED_GA_OFF|LED_MY_ON|LED_GB_OFF) ; /* ye LED on */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 148
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 149 /* init the timer value for the watch dog 2,5 minutes */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 150 outpd(ADDR(B2_WDOG_INI),0x6FC23AC0) ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 151
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 152 /* initialize the ISR mask */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 153 smc->hw.is_imask = ISR_MASK ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 154 smc->hw.hw_state = STOPPED ;
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 155 #endif
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 156 GET_PAGE(0) ; /* necessary for BOOT */
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 157 }
^1da177e drivers/net/skfp/drvfbi.c Linus Torvalds 2005-04-16 158
:::::: The code at line 130 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34851 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread