netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: palmer@sifive.com
Cc: nicolas.ferre@microchip.com, harinik@xilinx.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: net: macb: Fix compilation on systems without COMMON_CLK, v2
Date: Wed, 26 Jun 2019 14:09:56 -0700 (PDT)	[thread overview]
Message-ID: <20190626.140956.1543752418469724857.davem@davemloft.net> (raw)
In-Reply-To: <20190625084828.540-1-palmer@sifive.com>

From: Palmer Dabbelt <palmer@sifive.com>
Date: Tue, 25 Jun 2019 01:48:26 -0700

> Our patch to add support for the FU540-C000 broke compilation on at
> least powerpc allyesconfig, which was found as part of the linux-next
> build regression tests.  This must have somehow slipped through the
> cracks, as the patch has been reverted in linux-next for a while now.
> This patch applies on top of the offending commit, which is the only one
> I've even tried it on as I'm not sure how this subsystem makes it to
> Linus.
> 
> This patch set fixes the issue by adding a dependency of COMMON_CLK to
> the MACB Kconfig entry, which avoids the build failure by disabling MACB
> on systems where it wouldn't compile.  All known users of MACB have
> COMMON_CLK, so this shouldn't cause any issues.  This is a significantly
> simpler approach than disabling just the FU540-C000 support.
> 
> I've also included a second patch to indicate this is a driver for a
> Cadence device that was originally written by an engineer at Atmel.  The
> only relation is that I stumbled across it when writing the first patch.
> 
> Changes since v1 <20190624061603.1704-1-palmer@sifive.com>:
> 
> * Disable MACB on systems without COMMON_CLK, instead of just disabling
>   the FU540-C000 support on these systems.
> * Update the commit message to reflect the driver was written by Atmel.

Series applied, thanks.

      parent reply	other threads:[~2019-06-26 21:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-25  8:48 net: macb: Fix compilation on systems without COMMON_CLK, v2 Palmer Dabbelt
2019-06-25  8:48 ` [PATCH v2 1/2] net: macb: Kconfig: Make MACB depend on COMMON_CLK Palmer Dabbelt
2019-06-25  8:54   ` Nicolas.Ferre
2019-06-25  8:48 ` [PATCH v2 2/2] net: macb: Kconfig: Rename Atmel to Cadence Palmer Dabbelt
2019-06-25  8:54   ` Nicolas.Ferre
2019-06-26 21:09 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190626.140956.1543752418469724857.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=harinik@xilinx.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=palmer@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).