From: <Nicolas.Ferre@microchip.com>
To: <palmer@sifive.com>, <harinik@xilinx.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] net: macb: Kconfig: Make MACB depend on COMMON_CLK
Date: Tue, 25 Jun 2019 08:54:04 +0000 [thread overview]
Message-ID: <b9a01045-f43c-0b42-1859-fc37e7c6683b@microchip.com> (raw)
In-Reply-To: <20190625084828.540-2-palmer@sifive.com>
On 25/06/2019 at 10:48, Palmer Dabbelt wrote:
> commit c218ad559020 ("macb: Add support for SiFive FU540-C000") added a
> dependency on the common clock framework to the macb driver, but didn't
> express that dependency in Kconfig. As a result macb now fails to
> compile on systems without COMMON_CLK, which specifically causes a build
> failure on powerpc allyesconfig.
>
> This patch adds the dependency, which results in the macb driver no
> longer being selectable on systems without the common clock framework.
> All known systems that have this device already support the common clock
> framework, so this should not cause trouble for any uses. Supporting
> both the FU540-C000 and systems without COMMON_CLK is quite ugly.
>
> I've build tested this on powerpc allyesconfig and RISC-V defconfig
> (which selects MACB), but I have not even booted the resulting kernels.
>
> Fixes: c218ad559020 ("macb: Add support for SiFive FU540-C000")
> Signed-off-by: Palmer Dabbelt <palmer@sifive.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Thanks!
> ---
> drivers/net/ethernet/cadence/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/Kconfig b/drivers/net/ethernet/cadence/Kconfig
> index 1766697c9c5a..64d8d6ee7739 100644
> --- a/drivers/net/ethernet/cadence/Kconfig
> +++ b/drivers/net/ethernet/cadence/Kconfig
> @@ -21,7 +21,7 @@ if NET_VENDOR_CADENCE
>
> config MACB
> tristate "Cadence MACB/GEM support"
> - depends on HAS_DMA
> + depends on HAS_DMA && COMMON_CLK
> select PHYLIB
> ---help---
> The Cadence MACB ethernet interface is found on many Atmel AT32 and
> @@ -42,7 +42,7 @@ config MACB_USE_HWSTAMP
>
> config MACB_PCI
> tristate "Cadence PCI MACB/GEM support"
> - depends on MACB && PCI && COMMON_CLK
> + depends on MACB && PCI
> ---help---
> This is PCI wrapper for MACB driver.
>
>
--
Nicolas Ferre
next prev parent reply other threads:[~2019-06-25 8:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 8:48 net: macb: Fix compilation on systems without COMMON_CLK, v2 Palmer Dabbelt
2019-06-25 8:48 ` [PATCH v2 1/2] net: macb: Kconfig: Make MACB depend on COMMON_CLK Palmer Dabbelt
2019-06-25 8:54 ` Nicolas.Ferre [this message]
2019-06-25 8:48 ` [PATCH v2 2/2] net: macb: Kconfig: Rename Atmel to Cadence Palmer Dabbelt
2019-06-25 8:54 ` Nicolas.Ferre
2019-06-26 21:09 ` net: macb: Fix compilation on systems without COMMON_CLK, v2 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9a01045-f43c-0b42-1859-fc37e7c6683b@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=davem@davemloft.net \
--cc=harinik@xilinx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=palmer@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).