netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 79/87] net: vmxnet3: remove memset after dma_alloc_coherent
@ 2019-06-27 17:45 Fuqian Huang
  2019-06-27 17:47 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Fuqian Huang @ 2019-06-27 17:45 UTC (permalink / raw)
  Cc: Fuqian Huang, Ronak Doshi, VMware, Inc.,
	David S. Miller, netdev, linux-kernel

In commit af7ddd8a627c
("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
dma_alloc_coherent has already zeroed the memory.
So memset is not needed.

Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
---
 drivers/net/vmxnet3/vmxnet3_drv.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
index 89984fcab01e..a5ba7ed07e9c 100644
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -3429,7 +3429,6 @@ vmxnet3_probe_device(struct pci_dev *pdev,
 			err = -ENOMEM;
 			goto err_ver;
 		}
-		memset(adapter->coal_conf, 0, sizeof(*adapter->coal_conf));
 		adapter->coal_conf->coalMode = VMXNET3_COALESCE_DISABLED;
 		adapter->default_coal_mode = true;
 	}
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 79/87] net: vmxnet3: remove memset after dma_alloc_coherent
  2019-06-27 17:45 [PATCH 79/87] net: vmxnet3: remove memset after dma_alloc_coherent Fuqian Huang
@ 2019-06-27 17:47 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-06-27 17:47 UTC (permalink / raw)
  To: huangfq.daxian; +Cc: doshir, pv-drivers, netdev, linux-kernel


I'd kindly request that you separate these sets of changes into one
set per subsystem and submit them properly that way.

I'm really not going to sift through 87 patches and pull out the ones
individually that got to my tree(s).  That's your job to collect them
into appropriate groups properly.

Thank you.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-06-27 17:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-27 17:45 [PATCH 79/87] net: vmxnet3: remove memset after dma_alloc_coherent Fuqian Huang
2019-06-27 17:47 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).