From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Andrii Nakryiko <andriin@fb.com>
Cc: <andrii.nakryiko@gmail.com>, <ast@fb.com>, <daniel@iogearbox.net>,
<kernel-team@fb.com>, <bpf@vger.kernel.org>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH v4 bpf-next 4/4] tools/bpftool: switch map event_pipe to libbpf's perf_buffer
Date: Mon, 1 Jul 2019 15:04:43 -0700 [thread overview]
Message-ID: <20190701150443.1e43e818@cakuba.netronome.com> (raw)
In-Reply-To: <20190630065109.1794420-5-andriin@fb.com>
On Sat, 29 Jun 2019 23:51:09 -0700, Andrii Nakryiko wrote:
> Switch event_pipe implementation to rely on new libbpf perf buffer API
> (it's raw low-level variant).
>
> Signed-off-by: Andrii Nakryiko <andriin@fb.com>
> -int do_event_pipe(int argc, char **argv)
> -{
> - int i, nfds, map_fd, index = -1, cpu = -1;
> struct bpf_map_info map_info = {};
> - struct event_ring_info *rings;
> - size_t tmp_buf_sz = 0;
> - void *tmp_buf = NULL;
> - struct pollfd *pfds;
> + struct perf_buffer_raw_opts opts;
I'm slightly worried we don't init the ops, but we can wait and see if
it bites us or not.
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Thanks!
next prev parent reply other threads:[~2019-07-01 22:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-30 6:51 [PATCH v4 bpf-next 0/4] libbpf: add perf buffer abstraction and API Andrii Nakryiko
2019-06-30 6:51 ` [PATCH v4 bpf-next 1/4] libbpf: add perf buffer API Andrii Nakryiko
2019-06-30 6:51 ` [PATCH v4 bpf-next 2/4] libbpf: auto-set PERF_EVENT_ARRAY size to number of CPUs Andrii Nakryiko
2019-06-30 6:51 ` [PATCH v4 bpf-next 3/4] selftests/bpf: test perf buffer API Andrii Nakryiko
2019-06-30 6:51 ` [PATCH v4 bpf-next 4/4] tools/bpftool: switch map event_pipe to libbpf's perf_buffer Andrii Nakryiko
2019-07-01 22:04 ` Jakub Kicinski [this message]
2019-07-03 9:36 ` [PATCH v4 bpf-next 0/4] libbpf: add perf buffer abstraction and API Daniel Borkmann
2019-07-03 16:27 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190701150443.1e43e818@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).