From: Daniel Borkmann <daniel@iogearbox.net>
To: Andrii Nakryiko <andriin@fb.com>,
andrii.nakryiko@gmail.com, ast@fb.com, kernel-team@fb.com,
bpf@vger.kernel.org, netdev@vger.kernel.org,
jakub.kicinski@netronome.com
Subject: Re: [PATCH v4 bpf-next 0/4] libbpf: add perf buffer abstraction and API
Date: Wed, 3 Jul 2019 11:36:15 +0200 [thread overview]
Message-ID: <5a48c2f1-2abc-2deb-6863-c9f20e4ac03b@iogearbox.net> (raw)
In-Reply-To: <20190630065109.1794420-1-andriin@fb.com>
On 06/30/2019 08:51 AM, Andrii Nakryiko wrote:
> This patchset adds a high-level API for setting up and polling perf buffers
> associated with BPF_MAP_TYPE_PERF_EVENT_ARRAY map. Details of APIs are
> described in corresponding commit.
>
> Patch #1 adds a set of APIs to set up and work with perf buffer.
> Patch #2 enhances libbpf to support auto-setting PERF_EVENT_ARRAY map size.
> Patch #3 adds test.
> Patch #4 converts bpftool map event_pipe to new API.
>
> v3->v4:
> - fixed bpftool event_pipe cmd error handling (Jakub);
>
> v2->v3:
> - added perf_buffer__new_raw for more low-level control;
> - converted bpftool map event_pipe to new API (Daniel);
> - fixed bug with error handling in create_maps (Song);
>
> v1->v2:
> - add auto-sizing of PERF_EVENT_ARRAY maps;
>
> Andrii Nakryiko (4):
> libbpf: add perf buffer API
> libbpf: auto-set PERF_EVENT_ARRAY size to number of CPUs
> selftests/bpf: test perf buffer API
> tools/bpftool: switch map event_pipe to libbpf's perf_buffer
>
> tools/bpf/bpftool/map_perf_ring.c | 201 +++------
> tools/lib/bpf/libbpf.c | 397 +++++++++++++++++-
> tools/lib/bpf/libbpf.h | 49 +++
> tools/lib/bpf/libbpf.map | 4 +
> .../selftests/bpf/prog_tests/perf_buffer.c | 94 +++++
> .../selftests/bpf/progs/test_perf_buffer.c | 29 ++
> 6 files changed, 630 insertions(+), 144 deletions(-)
> create mode 100644 tools/testing/selftests/bpf/prog_tests/perf_buffer.c
> create mode 100644 tools/testing/selftests/bpf/progs/test_perf_buffer.c
Hm, set looks good, but this does not apply cleanly. Please rebase against
bpf-next and resubmit. Please also update tools/lib/bpf/README.rst with regards
to the perf_buffer__ prefix. While at it, you could also address Jakub's comment.
Thanks,
Daniel
next prev parent reply other threads:[~2019-07-03 9:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-30 6:51 [PATCH v4 bpf-next 0/4] libbpf: add perf buffer abstraction and API Andrii Nakryiko
2019-06-30 6:51 ` [PATCH v4 bpf-next 1/4] libbpf: add perf buffer API Andrii Nakryiko
2019-06-30 6:51 ` [PATCH v4 bpf-next 2/4] libbpf: auto-set PERF_EVENT_ARRAY size to number of CPUs Andrii Nakryiko
2019-06-30 6:51 ` [PATCH v4 bpf-next 3/4] selftests/bpf: test perf buffer API Andrii Nakryiko
2019-06-30 6:51 ` [PATCH v4 bpf-next 4/4] tools/bpftool: switch map event_pipe to libbpf's perf_buffer Andrii Nakryiko
2019-07-01 22:04 ` Jakub Kicinski
2019-07-03 9:36 ` Daniel Borkmann [this message]
2019-07-03 16:27 ` [PATCH v4 bpf-next 0/4] libbpf: add perf buffer abstraction and API Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a48c2f1-2abc-2deb-6863-c9f20e4ac03b@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=jakub.kicinski@netronome.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).