From: Matthew Wilcox <willy@infradead.org>
To: davem@davemloft.net
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
hch@lst.de, netdev@vger.kernel.org
Subject: [PATCH v3 3/7] net: Increase the size of skb_frag_t
Date: Fri, 12 Jul 2019 06:43:41 -0700 [thread overview]
Message-ID: <20190712134345.19767-4-willy@infradead.org> (raw)
In-Reply-To: <20190712134345.19767-1-willy@infradead.org>
From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To increase commonality between block and net, we are going to replace
the skb_frag_t with the bio_vec. This patch increases the size of
skb_frag_t on 32-bit machines from 8 bytes to 12 bytes. The size is
unchanged on 64-bit machines.
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
include/linux/skbuff.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index f9078e7edb53..7910935410e6 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -314,13 +314,8 @@ struct skb_frag_struct {
struct {
struct page *p;
} page;
-#if (BITS_PER_LONG > 32) || (PAGE_SIZE >= 65536)
__u32 page_offset;
__u32 size;
-#else
- __u16 page_offset;
- __u16 size;
-#endif
};
/**
--
2.20.1
next prev parent reply other threads:[~2019-07-12 13:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 13:43 [PATCH v3 0/7] Convert skb_frag_t to bio_vec Matthew Wilcox
2019-07-12 13:43 ` [PATCH v3 1/7] net: Use skb accessors in network drivers Matthew Wilcox
2019-07-12 13:43 ` [PATCH v3 2/7] net: Use skb accessors in network core Matthew Wilcox
2019-07-12 13:43 ` Matthew Wilcox [this message]
2019-07-12 13:43 ` [PATCH v3 4/7] net: Reorder the contents of skb_frag_t Matthew Wilcox
2019-07-23 22:29 ` Saeed Mahameed
2019-07-24 1:28 ` Matthew Wilcox
2019-07-24 17:55 ` Saeed Mahameed
2019-07-12 13:43 ` [PATCH v3 5/7] net: Rename skb_frag page to bv_page Matthew Wilcox
2019-07-12 13:43 ` [PATCH v3 6/7] net: Rename skb_frag_t size to bv_len Matthew Wilcox
2019-07-23 22:33 ` Saeed Mahameed
2019-07-24 1:30 ` Matthew Wilcox
2019-07-24 17:58 ` Saeed Mahameed
2019-07-12 13:43 ` [PATCH v3 7/7] net: Convert skb_frag_t to bio_vec Matthew Wilcox
2019-07-12 18:27 ` [PATCH v3 0/7] " David Miller
2019-07-22 20:39 ` Matthew Wilcox
2019-07-22 20:45 ` David Miller
2019-07-23 3:08 Matthew Wilcox
2019-07-23 3:08 ` [PATCH v3 3/7] net: Increase the size of skb_frag_t Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712134345.19767-4-willy@infradead.org \
--to=willy@infradead.org \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).