From: Matthew Wilcox <willy@infradead.org>
To: Saeed Mahameed <saeedm@mellanox.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"hch@lst.de" <hch@lst.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v3 4/7] net: Reorder the contents of skb_frag_t
Date: Tue, 23 Jul 2019 18:28:28 -0700 [thread overview]
Message-ID: <20190724012828.GQ363@bombadil.infradead.org> (raw)
In-Reply-To: <2b45504e005f88a033405225b04fba0b5dcf2e92.camel@mellanox.com>
On Tue, Jul 23, 2019 at 10:29:06PM +0000, Saeed Mahameed wrote:
> On Fri, 2019-07-12 at 06:43 -0700, Matthew Wilcox wrote:
> > From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
> >
> > Match the layout of bio_vec.
> >
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> > ---
> > include/linux/skbuff.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> > index 7910935410e6..b9dc8b4f24b1 100644
> > --- a/include/linux/skbuff.h
> > +++ b/include/linux/skbuff.h
> > @@ -314,8 +314,8 @@ struct skb_frag_struct {
> > struct {
> > struct page *p;
> > } page;
> > - __u32 page_offset;
> > __u32 size;
> > + __u32 page_offset;
> > };
> >
>
> Why do you need this patch? this struct is going to be removed
> downstream eventually ..
If there's a performance regression, this is the perfect patch to include
as part of the bisection. You'd think that this change could have no
effect, but I've seen weirder things.
next prev parent reply other threads:[~2019-07-24 1:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 13:43 [PATCH v3 0/7] Convert skb_frag_t to bio_vec Matthew Wilcox
2019-07-12 13:43 ` [PATCH v3 1/7] net: Use skb accessors in network drivers Matthew Wilcox
2019-07-12 13:43 ` [PATCH v3 2/7] net: Use skb accessors in network core Matthew Wilcox
2019-07-12 13:43 ` [PATCH v3 3/7] net: Increase the size of skb_frag_t Matthew Wilcox
2019-07-12 13:43 ` [PATCH v3 4/7] net: Reorder the contents " Matthew Wilcox
2019-07-23 22:29 ` Saeed Mahameed
2019-07-24 1:28 ` Matthew Wilcox [this message]
2019-07-24 17:55 ` Saeed Mahameed
2019-07-12 13:43 ` [PATCH v3 5/7] net: Rename skb_frag page to bv_page Matthew Wilcox
2019-07-12 13:43 ` [PATCH v3 6/7] net: Rename skb_frag_t size to bv_len Matthew Wilcox
2019-07-23 22:33 ` Saeed Mahameed
2019-07-24 1:30 ` Matthew Wilcox
2019-07-24 17:58 ` Saeed Mahameed
2019-07-12 13:43 ` [PATCH v3 7/7] net: Convert skb_frag_t to bio_vec Matthew Wilcox
2019-07-12 18:27 ` [PATCH v3 0/7] " David Miller
2019-07-22 20:39 ` Matthew Wilcox
2019-07-22 20:45 ` David Miller
2019-07-23 3:08 Matthew Wilcox
2019-07-23 3:08 ` [PATCH v3 4/7] net: Reorder the contents of skb_frag_t Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724012828.GQ363@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).