* [PATCH] net: ethernet: fix error return code in ag71xx_probe()
@ 2019-07-17 11:52 Wei Yongjun
2019-07-18 7:41 ` Oleksij Rempel
2019-07-19 1:21 ` [PATCH v2] ag71xx: " Wei Yongjun
0 siblings, 2 replies; 4+ messages in thread
From: Wei Yongjun @ 2019-07-17 11:52 UTC (permalink / raw)
To: Jay Cliburn, Chris Snook, Oleksij Rempel
Cc: Wei Yongjun, netdev, kernel-janitors
Fix to return error code -ENOMEM from the dmam_alloc_coherent() error
handling case instead of 0, as done elsewhere in this function.
Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/atheros/ag71xx.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c
index 72a57c6cd254..446d62e93439 100644
--- a/drivers/net/ethernet/atheros/ag71xx.c
+++ b/drivers/net/ethernet/atheros/ag71xx.c
@@ -1724,8 +1724,10 @@ static int ag71xx_probe(struct platform_device *pdev)
ag->stop_desc = dmam_alloc_coherent(&pdev->dev,
sizeof(struct ag71xx_desc),
&ag->stop_desc_dma, GFP_KERNEL);
- if (!ag->stop_desc)
+ if (!ag->stop_desc) {
+ err = -ENOMEM;
goto err_free;
+ }
ag->stop_desc->data = 0;
ag->stop_desc->ctrl = 0;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net: ethernet: fix error return code in ag71xx_probe()
2019-07-17 11:52 [PATCH] net: ethernet: fix error return code in ag71xx_probe() Wei Yongjun
@ 2019-07-18 7:41 ` Oleksij Rempel
2019-07-19 1:21 ` [PATCH v2] ag71xx: " Wei Yongjun
1 sibling, 0 replies; 4+ messages in thread
From: Oleksij Rempel @ 2019-07-18 7:41 UTC (permalink / raw)
To: Wei Yongjun, Jay Cliburn, Chris Snook; +Cc: netdev, kernel-janitors
On 17.07.19 13:52, Wei Yongjun wrote:
> Fix to return error code -ENOMEM from the dmam_alloc_coherent() error
> handling case instead of 0, as done elsewhere in this function.
>
> Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> drivers/net/ethernet/atheros/ag71xx.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c
> index 72a57c6cd254..446d62e93439 100644
> --- a/drivers/net/ethernet/atheros/ag71xx.c
> +++ b/drivers/net/ethernet/atheros/ag71xx.c
> @@ -1724,8 +1724,10 @@ static int ag71xx_probe(struct platform_device *pdev)
> ag->stop_desc = dmam_alloc_coherent(&pdev->dev,
> sizeof(struct ag71xx_desc),
> &ag->stop_desc_dma, GFP_KERNEL);
> - if (!ag->stop_desc)
> + if (!ag->stop_desc) {
> + err = -ENOMEM;
> goto err_free;
> + }
>
> ag->stop_desc->data = 0;
> ag->stop_desc->ctrl = 0;
>
>
>
>
Kind regards,
Oleksij Rempel
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] ag71xx: fix error return code in ag71xx_probe()
2019-07-17 11:52 [PATCH] net: ethernet: fix error return code in ag71xx_probe() Wei Yongjun
2019-07-18 7:41 ` Oleksij Rempel
@ 2019-07-19 1:21 ` Wei Yongjun
2019-07-19 3:34 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Wei Yongjun @ 2019-07-19 1:21 UTC (permalink / raw)
To: Jay Cliburn, Chris Snook, Oleksij Rempel
Cc: Wei Yongjun, netdev, kernel-janitors
Fix to return error code -ENOMEM from the dmam_alloc_coherent() error
handling case instead of 0, as done elsewhere in this function.
Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
v1 -> v2: fix subsystem prefix
---
drivers/net/ethernet/atheros/ag71xx.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c
index 72a57c6cd254..446d62e93439 100644
--- a/drivers/net/ethernet/atheros/ag71xx.c
+++ b/drivers/net/ethernet/atheros/ag71xx.c
@@ -1724,8 +1724,10 @@ static int ag71xx_probe(struct platform_device *pdev)
ag->stop_desc = dmam_alloc_coherent(&pdev->dev,
sizeof(struct ag71xx_desc),
&ag->stop_desc_dma, GFP_KERNEL);
- if (!ag->stop_desc)
+ if (!ag->stop_desc) {
+ err = -ENOMEM;
goto err_free;
+ }
ag->stop_desc->data = 0;
ag->stop_desc->ctrl = 0;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] ag71xx: fix error return code in ag71xx_probe()
2019-07-19 1:21 ` [PATCH v2] ag71xx: " Wei Yongjun
@ 2019-07-19 3:34 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2019-07-19 3:34 UTC (permalink / raw)
To: weiyongjun1; +Cc: jcliburn, chris.snook, o.rempel, netdev, kernel-janitors
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Fri, 19 Jul 2019 01:21:57 +0000
> Fix to return error code -ENOMEM from the dmam_alloc_coherent() error
> handling case instead of 0, as done elsewhere in this function.
>
> Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-19 3:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-17 11:52 [PATCH] net: ethernet: fix error return code in ag71xx_probe() Wei Yongjun
2019-07-18 7:41 ` Oleksij Rempel
2019-07-19 1:21 ` [PATCH v2] ag71xx: " Wei Yongjun
2019-07-19 3:34 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).