From: David Miller <davem@davemloft.net>
To: hayeswang@realtek.com
Cc: netdev@vger.kernel.org, nic_swsd@realtek.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] r8152: divide the tx and rx bottom functions
Date: Thu, 15 Aug 2019 13:58:51 -0700 (PDT) [thread overview]
Message-ID: <20190815.135851.1942927063321516679.davem@davemloft.net> (raw)
In-Reply-To: <1394712342-15778-301-Taiwan-albertk@realtek.com>
From: Hayes Wang <hayeswang@realtek.com>
Date: Wed, 14 Aug 2019 16:30:17 +0800
> Move the tx bottom function from NAPI to a new tasklet. Then, for
> multi-cores, the bottom functions of tx and rx may be run at same
> time with different cores. This is used to improve performance.
>
> Signed-off-by: Hayes Wang <hayeswang@realtek.com>
Theoretically, yes.
But do you have actual performance numbers showing this to be worth
the change?
Always provide performance numbers with changes that are supposed to
improve performance.
next prev parent reply other threads:[~2019-08-15 20:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 8:30 [PATCH net-next] r8152: divide the tx and rx bottom functions Hayes Wang
2019-08-15 20:58 ` David Miller [this message]
2019-08-16 2:59 ` Hayes Wang
2019-08-16 5:17 ` David Miller
2019-08-16 6:39 ` Eric Dumazet
2019-08-16 8:10 ` Hayes Wang
2019-08-16 8:19 ` Eric Dumazet
2019-08-16 9:08 ` Hayes Wang
2019-08-16 9:27 ` Eric Dumazet
2019-08-16 10:04 ` Hayes Wang
2019-08-19 6:40 ` [PATCH net-next v2] " Hayes Wang
2019-08-20 19:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815.135851.1942927063321516679.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).