From: Eric Dumazet <eric.dumazet@gmail.com>
To: Hayes Wang <hayeswang@realtek.com>, netdev@vger.kernel.org
Cc: nic_swsd@realtek.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] r8152: divide the tx and rx bottom functions
Date: Fri, 16 Aug 2019 08:39:54 +0200 [thread overview]
Message-ID: <9749764d-7815-b673-0fc4-22475601efec@gmail.com> (raw)
In-Reply-To: <1394712342-15778-301-Taiwan-albertk@realtek.com>
On 8/14/19 10:30 AM, Hayes Wang wrote:
> Move the tx bottom function from NAPI to a new tasklet. Then, for
> multi-cores, the bottom functions of tx and rx may be run at same
> time with different cores. This is used to improve performance.
>
>
tasklet and NAPI are scheduled on the same core (the current
cpu calling napi_schedule() or tasklet_schedule())
I would rather not add this dubious tasklet, and instead try to understand
what is wrong in this driver ;)
The various napi_schedule() calls are suspect IMO.
Also rtl8152_start_xmit() uses skb_queue_tail(&tp->tx_queue, skb);
But I see nothing really kicking the transmit if tx_free is empty ?
tx_bottom() is only called from bottom_half() (called from r8152_poll())
next prev parent reply other threads:[~2019-08-16 6:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 8:30 [PATCH net-next] r8152: divide the tx and rx bottom functions Hayes Wang
2019-08-15 20:58 ` David Miller
2019-08-16 2:59 ` Hayes Wang
2019-08-16 5:17 ` David Miller
2019-08-16 6:39 ` Eric Dumazet [this message]
2019-08-16 8:10 ` Hayes Wang
2019-08-16 8:19 ` Eric Dumazet
2019-08-16 9:08 ` Hayes Wang
2019-08-16 9:27 ` Eric Dumazet
2019-08-16 10:04 ` Hayes Wang
2019-08-19 6:40 ` [PATCH net-next v2] " Hayes Wang
2019-08-20 19:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9749764d-7815-b673-0fc4-22475601efec@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).