* [PATCH mlx5-next 0/5] Mellanox, Updates for mlx5-next branch 2019-08-15
@ 2019-08-15 19:46 Saeed Mahameed
2019-08-15 19:46 ` [PATCH mlx5-next 1/5] net/mlx5: Add missing include file to lib/crypto.c Saeed Mahameed
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: Saeed Mahameed @ 2019-08-15 19:46 UTC (permalink / raw)
To: Saeed Mahameed, Leon Romanovsky; +Cc: netdev, linux-rdma
Hi All,
This series includes misc updates for mlx5-next shared branch.
mlx5 HW spec and bits updates:
1) Aya exposes IP-in-IP capability in mlx5_core.
2) Maxim exposes lag tx port affinity capabilities.
3) Moshe adds VNIC_ENV internal rq counter bits.
Misc updates:
4) Saeed, two compiler warnings cleanups
In case of no objection this series will be applied to mlx5-next branch
and sent later as pull request to both rdma-next and net-next branches.
Thanks,
Saeed.
---
Aya Levin (1):
net/mlx5: Expose IP-in-IP capability bit
Maxim Mikityanskiy (1):
net/mlx5: Add lag_tx_port_affinity capability bit
Moshe Shemesh (1):
net/mlx5: Add support for VNIC_ENV internal rq counter
Saeed Mahameed (2):
net/mlx5: Add missing include file to lib/crypto.c
net/mlx5: Improve functions documentation
drivers/net/ethernet/mellanox/mlx5/core/eq.c | 22 +++++++++++--------
.../ethernet/mellanox/mlx5/core/lib/crypto.c | 1 +
include/linux/mlx5/mlx5_ifc.h | 18 +++++++++++----
3 files changed, 28 insertions(+), 13 deletions(-)
--
2.21.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH mlx5-next 1/5] net/mlx5: Add missing include file to lib/crypto.c
2019-08-15 19:46 [PATCH mlx5-next 0/5] Mellanox, Updates for mlx5-next branch 2019-08-15 Saeed Mahameed
@ 2019-08-15 19:46 ` Saeed Mahameed
2019-08-15 19:46 ` [PATCH mlx5-next 2/5] net/mlx5: Improve functions documentation Saeed Mahameed
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Saeed Mahameed @ 2019-08-15 19:46 UTC (permalink / raw)
To: Saeed Mahameed, Leon Romanovsky; +Cc: netdev, linux-rdma
Add missing include file to avoid compiler warnings:
drivers/net/ethernet/mellanox/mlx5/core//lib/crypto.c:6:5:
warning: no previous prototype for ‘mlx5_create_encryption_key’
6 | int mlx5_create_encryption_key(struct mlx5_core_dev *mdev,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx5/core//lib/crypto.c:60:6:
warning: no previous prototype for ‘mlx5_destroy_encryption_key’
60 | void mlx5_destroy_encryption_key(struct mlx5_core_dev *mdev, ...
Fixes: 45d3b55dc665 ("net/mlx5: Add crypto library to support create/destroy encryption key")
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
---
drivers/net/ethernet/mellanox/mlx5/core/lib/crypto.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/crypto.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/crypto.c
index ea9ee88491e5..22bc45c831d2 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/lib/crypto.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/crypto.c
@@ -2,6 +2,7 @@
// Copyright (c) 2019 Mellanox Technologies.
#include "mlx5_core.h"
+#include "lib/mlx5.h"
int mlx5_create_encryption_key(struct mlx5_core_dev *mdev,
void *key, u32 sz_bytes,
--
2.21.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH mlx5-next 2/5] net/mlx5: Improve functions documentation
2019-08-15 19:46 [PATCH mlx5-next 0/5] Mellanox, Updates for mlx5-next branch 2019-08-15 Saeed Mahameed
2019-08-15 19:46 ` [PATCH mlx5-next 1/5] net/mlx5: Add missing include file to lib/crypto.c Saeed Mahameed
@ 2019-08-15 19:46 ` Saeed Mahameed
2019-08-15 19:46 ` [PATCH mlx5-next 3/5] net/mlx5: Add support for VNIC_ENV internal rq counter Saeed Mahameed
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Saeed Mahameed @ 2019-08-15 19:46 UTC (permalink / raw)
To: Saeed Mahameed, Leon Romanovsky; +Cc: netdev, linux-rdma
Fix documentation of mlx5_eq_enable/disable to cleanup compiler warnings.
drivers/net/ethernet/mellanox/mlx5/core//eq.c:334:
warning: Function parameter or member 'dev' not described in 'mlx5_eq_enable'
warning: Function parameter or member 'eq' not described in 'mlx5_eq_enable'
warning: Function parameter or member 'nb' not described in 'mlx5_eq_enable'
drivers/net/ethernet/mellanox/mlx5/core//eq.c:355:
warning: Function parameter or member 'dev' not described in 'mlx5_eq_disable'
warning: Function parameter or member 'eq' not described in 'mlx5_eq_disable'
warning: Function parameter or member 'nb' not described in 'mlx5_eq_disable'
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
---
drivers/net/ethernet/mellanox/mlx5/core/eq.c | 22 ++++++++++++--------
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eq.c b/drivers/net/ethernet/mellanox/mlx5/core/eq.c
index 2df9aaa421c6..a0e78ab64618 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/eq.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/eq.c
@@ -324,10 +324,13 @@ create_map_eq(struct mlx5_core_dev *dev, struct mlx5_eq *eq,
/**
* mlx5_eq_enable - Enable EQ for receiving EQEs
- * @dev - Device which owns the eq
- * @eq - EQ to enable
- * @nb - notifier call block
- * mlx5_eq_enable - must be called after EQ is created in device.
+ * @dev : Device which owns the eq
+ * @eq : EQ to enable
+ * @nb : Notifier call block
+ *
+ * Must be called after EQ is created in device.
+ *
+ * @return: 0 if no error
*/
int mlx5_eq_enable(struct mlx5_core_dev *dev, struct mlx5_eq *eq,
struct notifier_block *nb)
@@ -344,11 +347,12 @@ int mlx5_eq_enable(struct mlx5_core_dev *dev, struct mlx5_eq *eq,
EXPORT_SYMBOL(mlx5_eq_enable);
/**
- * mlx5_eq_disable - Enable EQ for receiving EQEs
- * @dev - Device which owns the eq
- * @eq - EQ to disable
- * @nb - notifier call block
- * mlx5_eq_disable - must be called before EQ is destroyed.
+ * mlx5_eq_disable - Disable EQ for receiving EQEs
+ * @dev : Device which owns the eq
+ * @eq : EQ to disable
+ * @nb : Notifier call block
+ *
+ * Must be called before EQ is destroyed.
*/
void mlx5_eq_disable(struct mlx5_core_dev *dev, struct mlx5_eq *eq,
struct notifier_block *nb)
--
2.21.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH mlx5-next 3/5] net/mlx5: Add support for VNIC_ENV internal rq counter
2019-08-15 19:46 [PATCH mlx5-next 0/5] Mellanox, Updates for mlx5-next branch 2019-08-15 Saeed Mahameed
2019-08-15 19:46 ` [PATCH mlx5-next 1/5] net/mlx5: Add missing include file to lib/crypto.c Saeed Mahameed
2019-08-15 19:46 ` [PATCH mlx5-next 2/5] net/mlx5: Improve functions documentation Saeed Mahameed
@ 2019-08-15 19:46 ` Saeed Mahameed
2019-08-15 19:46 ` [PATCH mlx5-next 4/5] net/mlx5: Expose IP-in-IP capability bit Saeed Mahameed
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Saeed Mahameed @ 2019-08-15 19:46 UTC (permalink / raw)
To: Saeed Mahameed, Leon Romanovsky; +Cc: netdev, linux-rdma, Moshe Shemesh
From: Moshe Shemesh <moshe@mellanox.com>
Add mlx5 interface support for reading internal rq out of buffer counter
as part of QUERY_VNIC_ENV command. The command is used by the driver to
query vnic diagnostic statistics from FW.
Signed-off-by: Moshe Shemesh <moshe@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
---
include/linux/mlx5/mlx5_ifc.h | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h
index ab6ae723aae6..c788f895b350 100644
--- a/include/linux/mlx5/mlx5_ifc.h
+++ b/include/linux/mlx5/mlx5_ifc.h
@@ -1116,7 +1116,9 @@ struct mlx5_ifc_cmd_hca_cap_bits {
u8 cache_line_128byte[0x1];
u8 reserved_at_165[0x4];
u8 rts2rts_qp_counters_set_id[0x1];
- u8 reserved_at_16a[0x5];
+ u8 reserved_at_16a[0x2];
+ u8 vnic_env_int_rq_oob[0x1];
+ u8 reserved_at_16d[0x2];
u8 qcam_reg[0x1];
u8 gid_table_size[0x10];
@@ -2772,7 +2774,11 @@ struct mlx5_ifc_vnic_diagnostic_statistics_bits {
u8 transmit_discard_vport_down[0x40];
- u8 reserved_at_140[0xec0];
+ u8 reserved_at_140[0xa0];
+
+ u8 internal_rq_out_of_buffer[0x20];
+
+ u8 reserved_at_200[0xe00];
};
struct mlx5_ifc_traffic_counter_bits {
--
2.21.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH mlx5-next 4/5] net/mlx5: Expose IP-in-IP capability bit
2019-08-15 19:46 [PATCH mlx5-next 0/5] Mellanox, Updates for mlx5-next branch 2019-08-15 Saeed Mahameed
` (2 preceding siblings ...)
2019-08-15 19:46 ` [PATCH mlx5-next 3/5] net/mlx5: Add support for VNIC_ENV internal rq counter Saeed Mahameed
@ 2019-08-15 19:46 ` Saeed Mahameed
2019-08-15 19:46 ` [PATCH mlx5-next 5/5] net/mlx5: Add lag_tx_port_affinity " Saeed Mahameed
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Saeed Mahameed @ 2019-08-15 19:46 UTC (permalink / raw)
To: Saeed Mahameed, Leon Romanovsky
Cc: netdev, linux-rdma, Aya Levin, Tariq Toukan
From: Aya Levin <ayal@mellanox.com>
Expose Fw indication that it supports Stateless Offloads for IP over IP
tunneled packets. The following offloads are supported for the inner
packets: RSS, RX & TX Checksum Offloads, LSO and Flow Steering.
Signed-off-by: Aya Levin <ayal@mellanox.com>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
---
include/linux/mlx5/mlx5_ifc.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h
index c788f895b350..2837fe4d8901 100644
--- a/include/linux/mlx5/mlx5_ifc.h
+++ b/include/linux/mlx5/mlx5_ifc.h
@@ -808,7 +808,9 @@ struct mlx5_ifc_per_protocol_networking_offload_caps_bits {
u8 swp_csum[0x1];
u8 swp_lso[0x1];
u8 cqe_checksum_full[0x1];
- u8 reserved_at_24[0xc];
+ u8 reserved_at_24[0x5];
+ u8 tunnel_stateless_ip_over_ip[0x1];
+ u8 reserved_at_2a[0x6];
u8 max_vxlan_udp_ports[0x8];
u8 reserved_at_38[0x6];
u8 max_geneve_opt_len[0x1];
--
2.21.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH mlx5-next 5/5] net/mlx5: Add lag_tx_port_affinity capability bit
2019-08-15 19:46 [PATCH mlx5-next 0/5] Mellanox, Updates for mlx5-next branch 2019-08-15 Saeed Mahameed
` (3 preceding siblings ...)
2019-08-15 19:46 ` [PATCH mlx5-next 4/5] net/mlx5: Expose IP-in-IP capability bit Saeed Mahameed
@ 2019-08-15 19:46 ` Saeed Mahameed
2019-08-20 16:44 ` [PATCH mlx5-next 0/5] Mellanox, Updates for mlx5-next branch 2019-08-15 Doug Ledford
2019-08-20 20:54 ` Saeed Mahameed
6 siblings, 0 replies; 8+ messages in thread
From: Saeed Mahameed @ 2019-08-15 19:46 UTC (permalink / raw)
To: Saeed Mahameed, Leon Romanovsky
Cc: netdev, linux-rdma, Maxim Mikityanskiy, Tariq Toukan
From: Maxim Mikityanskiy <maximmi@mellanox.com>
Add the lag_tx_port_affinity HCA capability bit that indicates that
setting port affinity of TISes is supported.
Signed-off-by: Maxim Mikityanskiy <maximmi@mellanox.com>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
---
include/linux/mlx5/mlx5_ifc.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h
index 2837fe4d8901..1e55cf73e88c 100644
--- a/include/linux/mlx5/mlx5_ifc.h
+++ b/include/linux/mlx5/mlx5_ifc.h
@@ -1249,7 +1249,9 @@ struct mlx5_ifc_cmd_hca_cap_bits {
u8 reserved_at_263[0x8];
u8 log_bf_reg_size[0x5];
- u8 reserved_at_270[0xb];
+ u8 reserved_at_270[0x8];
+ u8 lag_tx_port_affinity[0x1];
+ u8 reserved_at_279[0x2];
u8 lag_master[0x1];
u8 num_lag_ports[0x4];
--
2.21.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH mlx5-next 0/5] Mellanox, Updates for mlx5-next branch 2019-08-15
2019-08-15 19:46 [PATCH mlx5-next 0/5] Mellanox, Updates for mlx5-next branch 2019-08-15 Saeed Mahameed
` (4 preceding siblings ...)
2019-08-15 19:46 ` [PATCH mlx5-next 5/5] net/mlx5: Add lag_tx_port_affinity " Saeed Mahameed
@ 2019-08-20 16:44 ` Doug Ledford
2019-08-20 20:54 ` Saeed Mahameed
6 siblings, 0 replies; 8+ messages in thread
From: Doug Ledford @ 2019-08-20 16:44 UTC (permalink / raw)
To: Saeed Mahameed, Leon Romanovsky; +Cc: netdev, linux-rdma
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
On Thu, 2019-08-15 at 19:46 +0000, Saeed Mahameed wrote:
> Hi All,
>
> This series includes misc updates for mlx5-next shared branch.
>
> mlx5 HW spec and bits updates:
> 1) Aya exposes IP-in-IP capability in mlx5_core.
> 2) Maxim exposes lag tx port affinity capabilities.
> 3) Moshe adds VNIC_ENV internal rq counter bits.
>
> Misc updates:
> 4) Saeed, two compiler warnings cleanups
>
> In case of no objection this series will be applied to mlx5-next
> branch
> and sent later as pull request to both rdma-next and net-next
> branches.
>
> Thanks,
> Saeed.
Series looks fine to me.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH mlx5-next 0/5] Mellanox, Updates for mlx5-next branch 2019-08-15
2019-08-15 19:46 [PATCH mlx5-next 0/5] Mellanox, Updates for mlx5-next branch 2019-08-15 Saeed Mahameed
` (5 preceding siblings ...)
2019-08-20 16:44 ` [PATCH mlx5-next 0/5] Mellanox, Updates for mlx5-next branch 2019-08-15 Doug Ledford
@ 2019-08-20 20:54 ` Saeed Mahameed
6 siblings, 0 replies; 8+ messages in thread
From: Saeed Mahameed @ 2019-08-20 20:54 UTC (permalink / raw)
To: Leon Romanovsky; +Cc: netdev, linux-rdma
On Thu, 2019-08-15 at 19:46 +0000, Saeed Mahameed wrote:
> Hi All,
>
> This series includes misc updates for mlx5-next shared branch.
>
> mlx5 HW spec and bits updates:
> 1) Aya exposes IP-in-IP capability in mlx5_core.
> 2) Maxim exposes lag tx port affinity capabilities.
> 3) Moshe adds VNIC_ENV internal rq counter bits.
>
> Misc updates:
> 4) Saeed, two compiler warnings cleanups
>
>
Applied to mlx5-next.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-08-20 20:54 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-15 19:46 [PATCH mlx5-next 0/5] Mellanox, Updates for mlx5-next branch 2019-08-15 Saeed Mahameed
2019-08-15 19:46 ` [PATCH mlx5-next 1/5] net/mlx5: Add missing include file to lib/crypto.c Saeed Mahameed
2019-08-15 19:46 ` [PATCH mlx5-next 2/5] net/mlx5: Improve functions documentation Saeed Mahameed
2019-08-15 19:46 ` [PATCH mlx5-next 3/5] net/mlx5: Add support for VNIC_ENV internal rq counter Saeed Mahameed
2019-08-15 19:46 ` [PATCH mlx5-next 4/5] net/mlx5: Expose IP-in-IP capability bit Saeed Mahameed
2019-08-15 19:46 ` [PATCH mlx5-next 5/5] net/mlx5: Add lag_tx_port_affinity " Saeed Mahameed
2019-08-20 16:44 ` [PATCH mlx5-next 0/5] Mellanox, Updates for mlx5-next branch 2019-08-15 Doug Ledford
2019-08-20 20:54 ` Saeed Mahameed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).