linux-next: Fixes tag needs some work in the bpf-next tree

linux-next: Fixes tag needs some work in the bpf-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 535 bytes --]

Hi all,

In commit

  ed4a3983cd3e ("tools: bpftool: fix argument for p_err() in BTF do_dump()")

Fixes tag

  Fixes: c93cc69004dt ("bpftool: add ability to dump BTF types")

has these problem(s):

  - missing space between the SHA1 and the subject

This is dues to the trailing 't' on the SHA1 :-(

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the bpf-next tree

[Quentin Monnet]

2019-08-16 23:46 UTC+1000 ~ Stephen Rothwell <sfr@canb.auug.org.au>
> Hi all,
> 
> In commit
> 
>   ed4a3983cd3e ("tools: bpftool: fix argument for p_err() in BTF do_dump()")
> 
> Fixes tag
> 
>   Fixes: c93cc69004dt ("bpftool: add ability to dump BTF types")
> 
> has these problem(s):
> 
>   - missing space between the SHA1 and the subject
> 
> This is dues to the trailing 't' on the SHA1 :-(
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").
> 

Hi Stephen,

I made that typo, please accept my apologies :(.

The correct tag should be:

  Fixes: c93cc69004df ("bpftool: add ability to dump BTF types")

Regards,
Quentin

linux-next: Fixes tag needs some work in the bpf-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

Hi all,

In commit

  1acf8f90ea7e ("libbpf: Fix register in PT_REGS MIPS macros")

Fixes tag

  Fixes: c1932cd ("bpf: Add MIPS support to samples/bpf.")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the bpf-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

Hi all,

In commit

  065485ac5e86 ("mips, bpf: Fix Makefile that referenced a removed file")

Fixes tag

  Fixes: 06b339fe5450 ("mips, bpf: Remove old BPF JIT implementations")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: ebcbacfa50ec ("mips, bpf: Remove old BPF JIT implementations")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the bpf-next tree

[Daniel Borkmann]

On 10/7/21 11:31 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>    065485ac5e86 ("mips, bpf: Fix Makefile that referenced a removed file")
> 
> Fixes tag
> 
>    Fixes: 06b339fe5450 ("mips, bpf: Remove old BPF JIT implementations")
> 
> has these problem(s):
> 
>    - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: ebcbacfa50ec ("mips, bpf: Remove old BPF JIT implementations")

Yeah, Fixes tag was incorrect. Fixed up now, thanks for the heads up!

linux-next: Fixes tag needs some work in the bpf-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

Hi all,

In commit

  a50cbac6d81a ("selftests/bpf: Fix tunnel remote IP comments")

Fixes tag

  Fixes: 933a741e ("selftests/bpf: bpf tunnel test.")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the bpf-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

Hi all,

In commit

  2e5e0e8ede02 ("bpf: Fix reference state management for synchronous callbacks")

Fixes tag

  Fixes: 69c87ba6225 ("bpf: Add bpf_for_each_map_elem() helper")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 69c087ba6225 ("bpf: Add bpf_for_each_map_elem() helper")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the bpf-next tree

[Kumar Kartikeya Dwivedi]

On Wed, 24 Aug 2022 at 07:00, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   2e5e0e8ede02 ("bpf: Fix reference state management for synchronous callbacks")
>
> Fixes tag
>
>   Fixes: 69c87ba6225 ("bpf: Add bpf_for_each_map_elem() helper")
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: 69c087ba6225 ("bpf: Add bpf_for_each_map_elem() helper")
>

Ugh, really sorry, I must have fat fingered and pressed 'x' in vim
while editing the commit message. I always generate these using a git
fixes alias.

> --
> Cheers,
> Stephen Rothwell

Re: linux-next: Fixes tag needs some work in the bpf-next tree

[Alexei Starovoitov]

On Wed, Aug 24, 2022 at 10:05 AM Kumar Kartikeya Dwivedi
<memxor@gmail.com> wrote:
>
> On Wed, 24 Aug 2022 at 07:00, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > In commit
> >
> >   2e5e0e8ede02 ("bpf: Fix reference state management for synchronous callbacks")
> >
> > Fixes tag
> >
> >   Fixes: 69c87ba6225 ("bpf: Add bpf_for_each_map_elem() helper")
> >
> > has these problem(s):
> >
> >   - Target SHA1 does not exist
> >
> > Maybe you meant
> >
> > Fixes: 69c087ba6225 ("bpf: Add bpf_for_each_map_elem() helper")
> >
>
> Ugh, really sorry, I must have fat fingered and pressed 'x' in vim
> while editing the commit message. I always generate these using a git
> fixes alias.

Since that was caught quickly there weren't that many commits on top.
Fixed and force pushed bpf-next.

We actually have a script that checks such sha-s. Not sure how we missed it.