* [v3] ocelot_ace: fix action of trap
@ 2019-08-20 4:20 Yangbo Lu
2019-08-20 7:05 ` Allan W . Nielsen
0 siblings, 1 reply; 3+ messages in thread
From: Yangbo Lu @ 2019-08-20 4:20 UTC (permalink / raw)
To: netdev, David S . Miller, Allan W . Nielsen, Alexandre Belloni,
Microchip Linux Driver Support, Andrew Lunn
Cc: Yangbo Lu
The trap action should be copying the frame to CPU and
dropping it for forwarding, but current setting was just
copying frame to CPU.
Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
---
drivers/net/ethernet/mscc/ocelot_ace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mscc/ocelot_ace.c b/drivers/net/ethernet/mscc/ocelot_ace.c
index 39aca1a..86fc6e6 100644
--- a/drivers/net/ethernet/mscc/ocelot_ace.c
+++ b/drivers/net/ethernet/mscc/ocelot_ace.c
@@ -317,7 +317,7 @@ static void is2_action_set(struct vcap_data *data,
break;
case OCELOT_ACL_ACTION_TRAP:
VCAP_ACT_SET(PORT_MASK, 0x0);
- VCAP_ACT_SET(MASK_MODE, 0x0);
+ VCAP_ACT_SET(MASK_MODE, 0x1);
VCAP_ACT_SET(POLICE_ENA, 0x0);
VCAP_ACT_SET(POLICE_IDX, 0x0);
VCAP_ACT_SET(CPU_QU_NUM, 0x0);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [v3] ocelot_ace: fix action of trap
2019-08-20 4:20 [v3] ocelot_ace: fix action of trap Yangbo Lu
@ 2019-08-20 7:05 ` Allan W . Nielsen
2019-08-20 15:45 ` Andrew Lunn
0 siblings, 1 reply; 3+ messages in thread
From: Allan W . Nielsen @ 2019-08-20 7:05 UTC (permalink / raw)
To: Yangbo Lu
Cc: netdev, David S . Miller, Alexandre Belloni,
Microchip Linux Driver Support, Andrew Lunn
Hi,
This is fixing a bug introduced in b596229448dd2
Acked-by: Allan W. Nielsen <allan.nielsen@microchip.com>
/Allan
The 08/20/2019 12:20, Yangbo Lu wrote:
> External E-Mail
>
>
> The trap action should be copying the frame to CPU and
> dropping it for forwarding, but current setting was just
> copying frame to CPU.
>
> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
> ---
> drivers/net/ethernet/mscc/ocelot_ace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mscc/ocelot_ace.c b/drivers/net/ethernet/mscc/ocelot_ace.c
> index 39aca1a..86fc6e6 100644
> --- a/drivers/net/ethernet/mscc/ocelot_ace.c
> +++ b/drivers/net/ethernet/mscc/ocelot_ace.c
> @@ -317,7 +317,7 @@ static void is2_action_set(struct vcap_data *data,
> break;
> case OCELOT_ACL_ACTION_TRAP:
> VCAP_ACT_SET(PORT_MASK, 0x0);
> - VCAP_ACT_SET(MASK_MODE, 0x0);
> + VCAP_ACT_SET(MASK_MODE, 0x1);
> VCAP_ACT_SET(POLICE_ENA, 0x0);
> VCAP_ACT_SET(POLICE_IDX, 0x0);
> VCAP_ACT_SET(CPU_QU_NUM, 0x0);
> --
> 2.7.4
>
>
--
/Allan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [v3] ocelot_ace: fix action of trap
2019-08-20 7:05 ` Allan W . Nielsen
@ 2019-08-20 15:45 ` Andrew Lunn
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2019-08-20 15:45 UTC (permalink / raw)
To: Allan W . Nielsen
Cc: Yangbo Lu, netdev, David S . Miller, Alexandre Belloni,
Microchip Linux Driver Support
On Tue, Aug 20, 2019 at 09:05:20AM +0200, Allan W . Nielsen wrote:
> Hi,
>
> This is fixing a bug introduced in b596229448dd2
Hi Allan
You should express that as:
Fixes: b596229448dd ("net: mscc: ocelot: Add support for tcam")
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-20 15:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-20 4:20 [v3] ocelot_ace: fix action of trap Yangbo Lu
2019-08-20 7:05 ` Allan W . Nielsen
2019-08-20 15:45 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).