From: David Miller <davem@davemloft.net>
To: marek.behun@nic.cz
Cc: vivien.didelot@gmail.com, netdev@vger.kernel.org, andrew@lunn.ch,
f.fainelli@gmail.com, olteanv@gmail.com
Subject: Re: [PATCH net-next v5 0/6] net: dsa: mv88e6xxx: Peridot/Topaz SERDES changes
Date: Tue, 27 Aug 2019 21:42:34 -0700 (PDT) [thread overview]
Message-ID: <20190827.214234.1744683677161165998.davem@davemloft.net> (raw)
In-Reply-To: <20190826213155.14685-1-marek.behun@nic.cz>
From: Marek Behún <marek.behun@nic.cz>
Date: Mon, 26 Aug 2019 23:31:49 +0200
> this is the fifth version of changes for the Topaz/Peridot family of
> switches. The patches apply on net-next.
> Changes since v4:
> - added Reviewed-by and Tested-by tags on first 2 patches, the others
> are changed are affected by changes in patch 3/6, so I did not add
> the tags, except for 5/6, which is just macro renaming
> - patch 3 was changed: the serdes_get_lane returns 0 on success (lane
> was discovered), -ENODEV if not lane is present on the port, and
> other error if other error occured. Lane is put into a pointer of
> type u8
> - patches 4 and 6 were affected by this (error detecting from
> serdes_get_lane)
> - Andrew's complaint about the two additional parameters
> (allow_over_2500 and make_cmode_writable) was addressed, by Vivien's
> advice: I put a new method into chip operations structure, named
> port_set_cmode_writable. This is called from mv88e6xxx_port_setup_mac
> just before port_set_cmode. The method is implemented for Topaz.
> The check if cmodes over 2500 should be allowed on given port is now
> done in the specific port_set_cmode() that requires it, thus the
> allow_over_2500 argument is not needed
>
> Again, tested on Turris Mox with Peridot, Topaz, and Peridot + Topaz.
Series applied, thank you.
prev parent reply other threads:[~2019-08-28 4:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 21:31 [PATCH net-next v5 0/6] net: dsa: mv88e6xxx: Peridot/Topaz SERDES changes Marek Behún
2019-08-26 21:31 ` [PATCH net-next v5 1/6] net: dsa: mv88e6xxx: support 2500base-x in SGMII IRQ handler Marek Behún
2019-08-26 21:31 ` [PATCH net-next v5 2/6] net: dsa: mv88e6xxx: update code operating on hidden registers Marek Behún
2019-08-26 21:31 ` [PATCH net-next v5 3/6] net: dsa: mv88e6xxx: create serdes_get_lane chip operation Marek Behún
2019-08-26 22:17 ` Vivien Didelot
2019-08-27 13:52 ` Andrew Lunn
2019-08-26 21:31 ` [PATCH net-next v5 4/6] net: dsa: mv88e6xxx: simplify SERDES code for Topaz and Peridot Marek Behún
2019-08-27 13:54 ` Andrew Lunn
2019-08-26 21:31 ` [PATCH net-next v5 5/6] net: dsa: mv88e6xxx: rename port cmode macro Marek Behún
2019-08-26 21:31 ` [PATCH net-next v5 6/6] net: dsa: mv88e6xxx: fully support SERDES on Topaz family Marek Behún
2019-08-26 22:05 ` Vivien Didelot
2019-08-27 13:57 ` Andrew Lunn
2019-08-28 4:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827.214234.1744683677161165998.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=marek.behun@nic.cz \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).