netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vivien Didelot <vivien.didelot@gmail.com>
To: "Marek Behún" <marek.behun@nic.cz>
Cc: netdev@vger.kernel.org, "Andrew Lunn" <andrew@lunn.ch>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Vladimir Oltean" <olteanv@gmail.com>,
	"Marek Behún" <marek.behun@nic.cz>
Subject: Re: [PATCH net-next v5 3/6] net: dsa: mv88e6xxx: create serdes_get_lane chip operation
Date: Mon, 26 Aug 2019 18:17:22 -0400	[thread overview]
Message-ID: <20190826181722.GD27244@t480s.localdomain> (raw)
In-Reply-To: <20190826213155.14685-4-marek.behun@nic.cz>

Hi Marek,

On Mon, 26 Aug 2019 23:31:52 +0200, Marek Behún <marek.behun@nic.cz> wrote:
> @@ -635,10 +660,10 @@ static irqreturn_t mv88e6390_serdes_thread_fn(int irq, void *dev_id)
>  	irqreturn_t ret = IRQ_NONE;
>  	u8 cmode = port->cmode;
>  	u16 status;
> -	int lane;
>  	int err;
> +	u8 lane;
>  
> -	lane = mv88e6390x_serdes_get_lane(chip, port->port);
> +	mv88e6xxx_serdes_get_lane(chip, port->port, &lane);

I don't like when errors aren't always checked, but the code was already
like this, so this can be addressed in a follow-up patch:

Reviewed-by: Vivien Didelot <vivien.didelot@gmail.com>


Thanks,

	Vivien

  reply	other threads:[~2019-08-26 22:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-26 21:31 [PATCH net-next v5 0/6] net: dsa: mv88e6xxx: Peridot/Topaz SERDES changes Marek Behún
2019-08-26 21:31 ` [PATCH net-next v5 1/6] net: dsa: mv88e6xxx: support 2500base-x in SGMII IRQ handler Marek Behún
2019-08-26 21:31 ` [PATCH net-next v5 2/6] net: dsa: mv88e6xxx: update code operating on hidden registers Marek Behún
2019-08-26 21:31 ` [PATCH net-next v5 3/6] net: dsa: mv88e6xxx: create serdes_get_lane chip operation Marek Behún
2019-08-26 22:17   ` Vivien Didelot [this message]
2019-08-27 13:52   ` Andrew Lunn
2019-08-26 21:31 ` [PATCH net-next v5 4/6] net: dsa: mv88e6xxx: simplify SERDES code for Topaz and Peridot Marek Behún
2019-08-27 13:54   ` Andrew Lunn
2019-08-26 21:31 ` [PATCH net-next v5 5/6] net: dsa: mv88e6xxx: rename port cmode macro Marek Behún
2019-08-26 21:31 ` [PATCH net-next v5 6/6] net: dsa: mv88e6xxx: fully support SERDES on Topaz family Marek Behún
2019-08-26 22:05   ` Vivien Didelot
2019-08-27 13:57   ` Andrew Lunn
2019-08-28  4:42 ` [PATCH net-next v5 0/6] net: dsa: mv88e6xxx: Peridot/Topaz SERDES changes David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190826181722.GD27244@t480s.localdomain \
    --to=vivien.didelot@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=marek.behun@nic.cz \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).