* [patch net-next] sched: act_vlan: implement stats_update callback
@ 2019-08-29 13:38 Jiri Pirko
2019-08-30 22:10 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Pirko @ 2019-08-29 13:38 UTC (permalink / raw)
To: netdev; +Cc: davem, mlxsw, pengfeil, jhs, xiyou.wangcong
From: Jiri Pirko <jiri@mellanox.com>
Implement this callback in order to get the offloaded stats added to the
kernel stats.
Reported-by: Pengfei Liu <pengfeil@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
net/sched/act_vlan.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/net/sched/act_vlan.c b/net/sched/act_vlan.c
index a3c9eea1ee8a..216b75709875 100644
--- a/net/sched/act_vlan.c
+++ b/net/sched/act_vlan.c
@@ -301,6 +301,19 @@ static int tcf_vlan_walker(struct net *net, struct sk_buff *skb,
return tcf_generic_walker(tn, skb, cb, type, ops, extack);
}
+static void tcf_vlan_stats_update(struct tc_action *a, u64 bytes, u32 packets,
+ u64 lastuse, bool hw)
+{
+ struct tcf_vlan *v = to_vlan(a);
+ struct tcf_t *tm = &v->tcf_tm;
+
+ _bstats_cpu_update(this_cpu_ptr(a->cpu_bstats), bytes, packets);
+ if (hw)
+ _bstats_cpu_update(this_cpu_ptr(a->cpu_bstats_hw),
+ bytes, packets);
+ tm->lastuse = max_t(u64, tm->lastuse, lastuse);
+}
+
static int tcf_vlan_search(struct net *net, struct tc_action **a, u32 index)
{
struct tc_action_net *tn = net_generic(net, vlan_net_id);
@@ -325,6 +338,7 @@ static struct tc_action_ops act_vlan_ops = {
.init = tcf_vlan_init,
.cleanup = tcf_vlan_cleanup,
.walk = tcf_vlan_walker,
+ .stats_update = tcf_vlan_stats_update,
.get_fill_size = tcf_vlan_get_fill_size,
.lookup = tcf_vlan_search,
.size = sizeof(struct tcf_vlan),
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch net-next] sched: act_vlan: implement stats_update callback
2019-08-29 13:38 [patch net-next] sched: act_vlan: implement stats_update callback Jiri Pirko
@ 2019-08-30 22:10 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-08-30 22:10 UTC (permalink / raw)
To: jiri; +Cc: netdev, mlxsw, pengfeil, jhs, xiyou.wangcong
From: Jiri Pirko <jiri@resnulli.us>
Date: Thu, 29 Aug 2019 15:38:42 +0200
> From: Jiri Pirko <jiri@mellanox.com>
>
> Implement this callback in order to get the offloaded stats added to the
> kernel stats.
>
> Reported-by: Pengfei Liu <pengfeil@mellanox.com>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-30 22:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-29 13:38 [patch net-next] sched: act_vlan: implement stats_update callback Jiri Pirko
2019-08-30 22:10 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).