* [PATCH] net: bcmgenet: use ethtool_op_get_ts_info()
@ 2019-08-30 18:49 Ryan M. Collins
2019-08-30 18:51 ` Florian Fainelli
2019-09-01 6:51 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Ryan M. Collins @ 2019-08-30 18:49 UTC (permalink / raw)
To: Doug Berger, Florian Fainelli, David S. Miller
Cc: bcm-kernel-feedback-list, netdev, linux-kernel
This change enables the use of SW timestamping on the Raspberry Pi 4.
bcmgenet's transmit function bcmgenet_xmit() implements software
timestamping. However the SOF_TIMESTAMPING_TX_SOFTWARE capability was
missing and only SOF_TIMESTAMPING_RX_SOFTWARE was announced. By using
ethtool_ops bcmgenet_ethtool_ops() as get_ts_info(), the
SOF_TIMESTAMPING_TX_SOFTWARE capability is announced.
Similar to commit a8f5cb9e7991 ("smsc95xx: use ethtool_op_get_ts_info()")
Signed-off-by: Ryan M. Collins <rmc032@bucknell.edu>
---
drivers/net/ethernet/broadcom/genet/bcmgenet.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
index 1586316eb6f1..12cb77ef1081 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
@@ -1124,6 +1124,7 @@ static const struct ethtool_ops bcmgenet_ethtool_ops = {
.set_coalesce = bcmgenet_set_coalesce,
.get_link_ksettings = bcmgenet_get_link_ksettings,
.set_link_ksettings = bcmgenet_set_link_ksettings,
+ .get_ts_info = ethtool_op_get_ts_info,
};
/* Power down the unimac, based on mode. */
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net: bcmgenet: use ethtool_op_get_ts_info()
2019-08-30 18:49 [PATCH] net: bcmgenet: use ethtool_op_get_ts_info() Ryan M. Collins
@ 2019-08-30 18:51 ` Florian Fainelli
2019-08-30 23:52 ` Doug Berger
2019-09-01 6:51 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Florian Fainelli @ 2019-08-30 18:51 UTC (permalink / raw)
To: Ryan M. Collins, Doug Berger, David S. Miller
Cc: bcm-kernel-feedback-list, netdev, linux-kernel
On 8/30/19 11:49 AM, Ryan M. Collins wrote:
> This change enables the use of SW timestamping on the Raspberry Pi 4.
Finally the first bcmgenet patch that was tested on the Pi 4!
>
> bcmgenet's transmit function bcmgenet_xmit() implements software
> timestamping. However the SOF_TIMESTAMPING_TX_SOFTWARE capability was
> missing and only SOF_TIMESTAMPING_RX_SOFTWARE was announced. By using
> ethtool_ops bcmgenet_ethtool_ops() as get_ts_info(), the
> SOF_TIMESTAMPING_TX_SOFTWARE capability is announced.
>
> Similar to commit a8f5cb9e7991 ("smsc95xx: use ethtool_op_get_ts_info()")
>
> Signed-off-by: Ryan M. Collins <rmc032@bucknell.edu>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: bcmgenet: use ethtool_op_get_ts_info()
2019-08-30 18:51 ` Florian Fainelli
@ 2019-08-30 23:52 ` Doug Berger
0 siblings, 0 replies; 4+ messages in thread
From: Doug Berger @ 2019-08-30 23:52 UTC (permalink / raw)
To: Florian Fainelli, Ryan M. Collins, David S. Miller
Cc: bcm-kernel-feedback-list, netdev, linux-kernel
On 8/30/19 11:51 AM, Florian Fainelli wrote:
> On 8/30/19 11:49 AM, Ryan M. Collins wrote:
>> This change enables the use of SW timestamping on the Raspberry Pi 4.
>
> Finally the first bcmgenet patch that was tested on the Pi 4!
>
>>
>> bcmgenet's transmit function bcmgenet_xmit() implements software
>> timestamping. However the SOF_TIMESTAMPING_TX_SOFTWARE capability was
>> missing and only SOF_TIMESTAMPING_RX_SOFTWARE was announced. By using
>> ethtool_ops bcmgenet_ethtool_ops() as get_ts_info(), the
>> SOF_TIMESTAMPING_TX_SOFTWARE capability is announced.
>>
>> Similar to commit a8f5cb9e7991 ("smsc95xx: use ethtool_op_get_ts_info()")
>>
>> Signed-off-by: Ryan M. Collins <rmc032@bucknell.edu>
>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
>
Thanks Ryan!
Acked-by: Doug Berger <opendmb@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: bcmgenet: use ethtool_op_get_ts_info()
2019-08-30 18:49 [PATCH] net: bcmgenet: use ethtool_op_get_ts_info() Ryan M. Collins
2019-08-30 18:51 ` Florian Fainelli
@ 2019-09-01 6:51 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2019-09-01 6:51 UTC (permalink / raw)
To: rmc032
Cc: opendmb, f.fainelli, bcm-kernel-feedback-list, netdev, linux-kernel
From: "Ryan M. Collins" <rmc032@bucknell.edu>
Date: Fri, 30 Aug 2019 14:49:55 -0400
> This change enables the use of SW timestamping on the Raspberry Pi 4.
>
> bcmgenet's transmit function bcmgenet_xmit() implements software
> timestamping. However the SOF_TIMESTAMPING_TX_SOFTWARE capability was
> missing and only SOF_TIMESTAMPING_RX_SOFTWARE was announced. By using
> ethtool_ops bcmgenet_ethtool_ops() as get_ts_info(), the
> SOF_TIMESTAMPING_TX_SOFTWARE capability is announced.
>
> Similar to commit a8f5cb9e7991 ("smsc95xx: use ethtool_op_get_ts_info()")
>
> Signed-off-by: Ryan M. Collins <rmc032@bucknell.edu>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-01 6:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-30 18:49 [PATCH] net: bcmgenet: use ethtool_op_get_ts_info() Ryan M. Collins
2019-08-30 18:51 ` Florian Fainelli
2019-08-30 23:52 ` Doug Berger
2019-09-01 6:51 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).