[PATCH net-next] net_failover: get rid of the limitaion receive packet from standy dev when primary exist

[PATCH net-next] net_failover: get rid of the limitaion receive packet from standy dev when primary exist

[wenxu]

From: wenxu <wenxu@ucloud.cn>

For receive side the standby, primary and failover is the same one,
If the packet receive from standby or primary should can be deliver
to failover dev.

For example: there are VF and virtio device failover together.
When live migration the VF detached and send/recv packet through
virtio device. When VF attached again some ingress traffic may
receive from virtio device for cache reason(TC flower offload in
sw mode).

Signed-off-by: wenxu <wenxu@ucloud.cn>
---
 drivers/net/net_failover.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/net/net_failover.c b/drivers/net/net_failover.c
index b16a122..da3beb5 100644
--- a/drivers/net/net_failover.c
+++ b/drivers/net/net_failover.c
@@ -362,14 +362,6 @@ static rx_handler_result_t net_failover_handle_frame(struct sk_buff **pskb)
 {
 	struct sk_buff *skb = *pskb;
 	struct net_device *dev = rcu_dereference(skb->dev->rx_handler_data);
-	struct net_failover_info *nfo_info = netdev_priv(dev);
-	struct net_device *primary_dev, *standby_dev;
-
-	primary_dev = rcu_dereference(nfo_info->primary_dev);
-	standby_dev = rcu_dereference(nfo_info->standby_dev);
-
-	if (primary_dev && skb->dev == standby_dev)
-		return RX_HANDLER_EXACT;
 
 	skb->dev = dev;
 
-- 
1.8.3.1

Re: [PATCH net-next] net_failover: get rid of the limitaion receive packet from standy dev when primary exist

[David Miller]

From: wenxu@ucloud.cn
Date: Fri, 30 Aug 2019 13:07:48 +0800

> From: wenxu <wenxu@ucloud.cn>
> 
> For receive side the standby, primary and failover is the same one,
> If the packet receive from standby or primary should can be deliver
> to failover dev.
> 
> For example: there are VF and virtio device failover together.
> When live migration the VF detached and send/recv packet through
> virtio device. When VF attached again some ingress traffic may
> receive from virtio device for cache reason(TC flower offload in
> sw mode).
> 
> Signed-off-by: wenxu <wenxu@ucloud.cn>

I don't understand, the device logic guarding the device rewriting in
this handler looks very much intentional.

After your changes we have no logic at all, we just unconditionally
always rewrite.