[PATCH] net: fixed_phy: Add forward declaration for struct gpio_desc;

[PATCH] net: fixed_phy: Add forward declaration for struct gpio_desc;

[Moritz Fischer]

Add forward declaration for struct gpio_desc in order to address
the following:

./include/linux/phy_fixed.h:48:17: error: 'struct gpio_desc' declared inside parameter list [-Werror]
./include/linux/phy_fixed.h:48:17: error: its scope is only this definition or declaration, which is probably not what you want [-Werror]

Fixes commit 71bd106d2567 ("net: fixed-phy: Add
fixed_phy_register_with_gpiod() API")
Signed-off-by: Moritz Fischer <mdf@kernel.org>
---
 include/linux/phy_fixed.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/phy_fixed.h b/include/linux/phy_fixed.h
index 1e5d86ebdaeb..52bc8e487ef7 100644
--- a/include/linux/phy_fixed.h
+++ b/include/linux/phy_fixed.h
@@ -11,6 +11,7 @@ struct fixed_phy_status {
 };
 
 struct device_node;
+struct gpio_desc;
 
 #if IS_ENABLED(CONFIG_FIXED_PHY)
 extern int fixed_phy_change_carrier(struct net_device *dev, bool new_carrier);
-- 
2.23.0.187.g17f5b7556c-goog

Re: [PATCH] net: fixed_phy: Add forward declaration for struct gpio_desc;

[Florian Fainelli]

On 9/3/19 11:46 AM, Moritz Fischer wrote:
> Add forward declaration for struct gpio_desc in order to address
> the following:
> 
> ./include/linux/phy_fixed.h:48:17: error: 'struct gpio_desc' declared inside parameter list [-Werror]
> ./include/linux/phy_fixed.h:48:17: error: its scope is only this definition or declaration, which is probably not what you want [-Werror]
> 
> Fixes commit 71bd106d2567 ("net: fixed-phy: Add
> fixed_phy_register_with_gpiod() API")

There is a standardized tag for that which is:

Fixes: 71bd106d2567 ("net: fixed-phy: Add
fixed_phy_register_with_gpiod() API")

Other than that:

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> ---
>  include/linux/phy_fixed.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/phy_fixed.h b/include/linux/phy_fixed.h
> index 1e5d86ebdaeb..52bc8e487ef7 100644
> --- a/include/linux/phy_fixed.h
> +++ b/include/linux/phy_fixed.h
> @@ -11,6 +11,7 @@ struct fixed_phy_status {
>  };
>  
>  struct device_node;
> +struct gpio_desc;
>  
>  #if IS_ENABLED(CONFIG_FIXED_PHY)
>  extern int fixed_phy_change_carrier(struct net_device *dev, bool new_carrier);
> 


-- 
Florian

Re: [PATCH] net: fixed_phy: Add forward declaration for struct gpio_desc;

[David Miller]

From: Moritz Fischer <mdf@kernel.org>
Date: Tue,  3 Sep 2019 11:46:52 -0700

> Add forward declaration for struct gpio_desc in order to address
> the following:
> 
> ./include/linux/phy_fixed.h:48:17: error: 'struct gpio_desc' declared inside parameter list [-Werror]
> ./include/linux/phy_fixed.h:48:17: error: its scope is only this definition or declaration, which is probably not what you want [-Werror]
> 
> Fixes commit 71bd106d2567 ("net: fixed-phy: Add
> fixed_phy_register_with_gpiod() API")
> Signed-off-by: Moritz Fischer <mdf@kernel.org>

Applied with Fixes tag fixed up.