* [PATCH] net: hns: Move static keyword to the front of declaration
@ 2019-09-04 14:21 Krzysztof Wilczynski
2019-09-05 10:39 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Wilczynski @ 2019-09-04 14:21 UTC (permalink / raw)
To: Yisen Zhuang, Salil Mehta, David S. Miller, Yonglong Liu,
Peng Li, Greg Kroah-Hartman, Colin Ian King, Huang Zijiang,
Thomas Gleixner
Cc: netdev, linux-kernel
Move the static keyword to the front of declaration of g_dsaf_mode_match,
and resolve the following compiler warning that can be seen when building
with warnings enabled (W=1):
drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:27:1: warning:
‘static’ is not at beginning of declaration [-Wold-style-declaration]
Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
---
Related: https://lore.kernel.org/r/20190827233017.GK9987@google.com
drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c
index c1eba421ba82..3a14bbc26ea2 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c
@@ -24,7 +24,7 @@
#include "hns_dsaf_rcb.h"
#include "hns_dsaf_misc.h"
-const static char *g_dsaf_mode_match[DSAF_MODE_MAX] = {
+static const char *g_dsaf_mode_match[DSAF_MODE_MAX] = {
[DSAF_MODE_DISABLE_2PORT_64VM] = "2port-64vf",
[DSAF_MODE_DISABLE_6PORT_0VM] = "6port-16rss",
[DSAF_MODE_DISABLE_6PORT_16VM] = "6port-16vf",
--
2.22.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: hns: Move static keyword to the front of declaration
2019-09-04 14:21 [PATCH] net: hns: Move static keyword to the front of declaration Krzysztof Wilczynski
@ 2019-09-05 10:39 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-09-05 10:39 UTC (permalink / raw)
To: kw
Cc: yisen.zhuang, salil.mehta, liuyonglong, lipeng321, gregkh,
colin.king, huang.zijiang, tglx, netdev, linux-kernel
From: Krzysztof Wilczynski <kw@linux.com>
Date: Wed, 4 Sep 2019 16:21:16 +0200
> Move the static keyword to the front of declaration of g_dsaf_mode_match,
> and resolve the following compiler warning that can be seen when building
> with warnings enabled (W=1):
>
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:27:1: warning:
> ‘static’ is not at beginning of declaration [-Wold-style-declaration]
>
> Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
Applied to net-next.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-05 10:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-04 14:21 [PATCH] net: hns: Move static keyword to the front of declaration Krzysztof Wilczynski
2019-09-05 10:39 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).