Netdev Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] sctp: Fix the link time qualifier of 'sctp_ctrlsock_exit()'
@ 2019-09-11 16:02 Christophe JAILLET
  2019-09-11 16:23 ` Marcelo Ricardo Leitner
  2019-09-12 11:56 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2019-09-11 16:02 UTC (permalink / raw)
  To: davem, vyasevich, nhorman, marcelo.leitner
  Cc: linux-sctp, netdev, linux-kernel, kernel-janitors, Christophe JAILLET

The '.exit' functions from 'pernet_operations' structure should be marked
as __net_exit, not __net_init.

Fixes: 8e2d61e0aed2 ("sctp: fix race on protocol/netns initialization")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 net/sctp/protocol.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c
index 2d47adcb4cbe..53746ffeeca3 100644
--- a/net/sctp/protocol.c
+++ b/net/sctp/protocol.c
@@ -1336,7 +1336,7 @@ static int __net_init sctp_ctrlsock_init(struct net *net)
 	return status;
 }
 
-static void __net_init sctp_ctrlsock_exit(struct net *net)
+static void __net_exit sctp_ctrlsock_exit(struct net *net)
 {
 	/* Free the control endpoint.  */
 	inet_ctl_sock_destroy(net->sctp.ctl_sock);
-- 
2.20.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] sctp: Fix the link time qualifier of 'sctp_ctrlsock_exit()'
  2019-09-11 16:02 [PATCH] sctp: Fix the link time qualifier of 'sctp_ctrlsock_exit()' Christophe JAILLET
@ 2019-09-11 16:23 ` Marcelo Ricardo Leitner
  2019-09-12 11:56 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Marcelo Ricardo Leitner @ 2019-09-11 16:23 UTC (permalink / raw)
  To: Christophe JAILLET
  Cc: davem, vyasevich, nhorman, linux-sctp, netdev, linux-kernel,
	kernel-janitors

On Wed, Sep 11, 2019 at 06:02:39PM +0200, Christophe JAILLET wrote:
> The '.exit' functions from 'pernet_operations' structure should be marked
> as __net_exit, not __net_init.
> 
> Fixes: 8e2d61e0aed2 ("sctp: fix race on protocol/netns initialization")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] sctp: Fix the link time qualifier of 'sctp_ctrlsock_exit()'
  2019-09-11 16:02 [PATCH] sctp: Fix the link time qualifier of 'sctp_ctrlsock_exit()' Christophe JAILLET
  2019-09-11 16:23 ` Marcelo Ricardo Leitner
@ 2019-09-12 11:56 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-09-12 11:56 UTC (permalink / raw)
  To: christophe.jaillet
  Cc: vyasevich, nhorman, marcelo.leitner, linux-sctp, netdev,
	linux-kernel, kernel-janitors

From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Date: Wed, 11 Sep 2019 18:02:39 +0200

> The '.exit' functions from 'pernet_operations' structure should be marked
> as __net_exit, not __net_init.
> 
> Fixes: 8e2d61e0aed2 ("sctp: fix race on protocol/netns initialization")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Applied and queued up for -stable.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-11 16:02 [PATCH] sctp: Fix the link time qualifier of 'sctp_ctrlsock_exit()' Christophe JAILLET
2019-09-11 16:23 ` Marcelo Ricardo Leitner
2019-09-12 11:56 ` David Miller

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org netdev@archiver.kernel.org
	public-inbox-index netdev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox