* [PATCH v7 1/7] nfc: pn533: i2c: "pn532" as dt compatible string
@ 2019-09-10 9:31 Lars Poeschel
2019-09-18 12:34 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: Lars Poeschel @ 2019-09-10 9:31 UTC (permalink / raw)
To: Allison Randal, Greg Kroah-Hartman, Jilayne Lovejoy,
Kate Stewart, Thomas Gleixner, Lars Poeschel,
open list:NFC SUBSYSTEM, open list
Cc: Johan Hovold
It is favourable to have one unified compatible string for devices that
have multiple interfaces. So this adds simply "pn532" as the devicetree
binding compatible string and makes a note that the old ones are
deprecated.
Cc: Johan Hovold <johan@kernel.org>
Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
---
Changes in v6:
- Rebased the patch series on v5.3-rc5
Changes in v3:
- This patch is new in v3
drivers/nfc/pn533/i2c.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/nfc/pn533/i2c.c b/drivers/nfc/pn533/i2c.c
index 1832cd921ea7..1abd40398a5a 100644
--- a/drivers/nfc/pn533/i2c.c
+++ b/drivers/nfc/pn533/i2c.c
@@ -245,6 +245,11 @@ static int pn533_i2c_remove(struct i2c_client *client)
}
static const struct of_device_id of_pn533_i2c_match[] = {
+ { .compatible = "nxp,pn532", },
+ /*
+ * NOTE: The use of the compatibles with the trailing "...-i2c" is
+ * deprecated and will be removed.
+ */
{ .compatible = "nxp,pn533-i2c", },
{ .compatible = "nxp,pn532-i2c", },
{},
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v7 1/7] nfc: pn533: i2c: "pn532" as dt compatible string
2019-09-10 9:31 [PATCH v7 1/7] nfc: pn533: i2c: "pn532" as dt compatible string Lars Poeschel
@ 2019-09-18 12:34 ` Simon Horman
2019-09-19 7:36 ` Lars Poeschel
0 siblings, 1 reply; 3+ messages in thread
From: Simon Horman @ 2019-09-18 12:34 UTC (permalink / raw)
To: Lars Poeschel
Cc: Allison Randal, Greg Kroah-Hartman, Jilayne Lovejoy,
Kate Stewart, Thomas Gleixner, open list:NFC SUBSYSTEM,
open list, Johan Hovold
On Tue, Sep 10, 2019 at 11:31:21AM +0200, Lars Poeschel wrote:
> It is favourable to have one unified compatible string for devices that
> have multiple interfaces. So this adds simply "pn532" as the devicetree
> binding compatible string and makes a note that the old ones are
> deprecated.
Do you also need to update
Documentation/devicetree/bindings/net/nfc/pn533-i2c.txt
to both document the new compat string and deprecate the old ones?
> Cc: Johan Hovold <johan@kernel.org>
> Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
> ---
> Changes in v6:
> - Rebased the patch series on v5.3-rc5
>
> Changes in v3:
> - This patch is new in v3
>
> drivers/nfc/pn533/i2c.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/nfc/pn533/i2c.c b/drivers/nfc/pn533/i2c.c
> index 1832cd921ea7..1abd40398a5a 100644
> --- a/drivers/nfc/pn533/i2c.c
> +++ b/drivers/nfc/pn533/i2c.c
> @@ -245,6 +245,11 @@ static int pn533_i2c_remove(struct i2c_client *client)
> }
>
> static const struct of_device_id of_pn533_i2c_match[] = {
> + { .compatible = "nxp,pn532", },
> + /*
> + * NOTE: The use of the compatibles with the trailing "...-i2c" is
> + * deprecated and will be removed.
> + */
> { .compatible = "nxp,pn533-i2c", },
> { .compatible = "nxp,pn532-i2c", },
> {},
> --
> 2.23.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v7 1/7] nfc: pn533: i2c: "pn532" as dt compatible string
2019-09-18 12:34 ` Simon Horman
@ 2019-09-19 7:36 ` Lars Poeschel
0 siblings, 0 replies; 3+ messages in thread
From: Lars Poeschel @ 2019-09-19 7:36 UTC (permalink / raw)
To: Simon Horman
Cc: Allison Randal, Greg Kroah-Hartman, Jilayne Lovejoy,
Kate Stewart, Thomas Gleixner, open list:NFC SUBSYSTEM,
open list, Johan Hovold
On Wed, Sep 18, 2019 at 02:34:57PM +0200, Simon Horman wrote:
> On Tue, Sep 10, 2019 at 11:31:21AM +0200, Lars Poeschel wrote:
> > It is favourable to have one unified compatible string for devices that
> > have multiple interfaces. So this adds simply "pn532" as the devicetree
> > binding compatible string and makes a note that the old ones are
> > deprecated.
>
> Do you also need to update
> Documentation/devicetree/bindings/net/nfc/pn533-i2c.txt
> to both document the new compat string and deprecate the old ones?
Simon, thank you for this hint.
The patch 2/7 adds a seperate binding doc, that contains the info about
the deprecated compat strings. But I think this is not the way to go. I
will change the patch 2/7 to update the info
Documentation/devicetree/bindings/net/nfc/pn533-i2c.txt
instead, rename it to pn532.txt and do not add a new binding doc.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-19 7:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-10 9:31 [PATCH v7 1/7] nfc: pn533: i2c: "pn532" as dt compatible string Lars Poeschel
2019-09-18 12:34 ` Simon Horman
2019-09-19 7:36 ` Lars Poeschel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).