From: David Miller <davem@davemloft.net>
To: o.rempel@pengutronix.de
Cc: jcliburn@gmail.com, chris.snook@gmail.com, andrew@lunn.ch,
kernel@pengutronix.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] net: ag71xx: fix mdio subnode support
Date: Tue, 01 Oct 2019 09:03:20 -0700 (PDT) [thread overview]
Message-ID: <20191001.090320.1192378852987776883.davem@davemloft.net> (raw)
In-Reply-To: <20191001064147.23633-1-o.rempel@pengutronix.de>
From: Oleksij Rempel <o.rempel@pengutronix.de>
Date: Tue, 1 Oct 2019 08:41:47 +0200
> @@ -571,7 +571,9 @@ static int ag71xx_mdio_probe(struct ag71xx *ag)
> msleep(200);
> }
>
> - err = of_mdiobus_register(mii_bus, np);
> + mnp = of_get_child_by_name(np, "mdio");
> + err = of_mdiobus_register(mii_bus, mnp);
of_get_child_by_name() can fail, so error checking is necessary
before you pass mnp into of_mdiobus_register().
next prev parent reply other threads:[~2019-10-01 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 6:41 [PATCH net v2] net: ag71xx: fix mdio subnode support Oleksij Rempel
2019-10-01 16:03 ` David Miller [this message]
2019-10-01 16:43 ` Andrew Lunn
2019-10-01 17:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001.090320.1192378852987776883.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=chris.snook@gmail.com \
--cc=jcliburn@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).