* [PATCH] ionic: select CONFIG_NET_DEVLINK
@ 2019-10-01 14:21 Arnd Bergmann
2019-10-01 16:01 ` Shannon Nelson
2019-10-01 16:24 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2019-10-01 14:21 UTC (permalink / raw)
To: Shannon Nelson, Pensando Drivers, David S. Miller
Cc: Arnd Bergmann, Krzysztof Kozlowski, Leon Romanovsky, Kalle Valo,
netdev, linux-kernel
When no other driver selects the devlink library code, ionic
produces a link failure:
drivers/net/ethernet/pensando/ionic/ionic_devlink.o: In function `ionic_devlink_alloc':
ionic_devlink.c:(.text+0xd): undefined reference to `devlink_alloc'
drivers/net/ethernet/pensando/ionic/ionic_devlink.o: In function `ionic_devlink_register':
ionic_devlink.c:(.text+0x71): undefined reference to `devlink_register'
Add the same 'select' statement that the other drivers use here.
Fixes: fbfb8031533c ("ionic: Add hardware init and device commands")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ethernet/pensando/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/pensando/Kconfig b/drivers/net/ethernet/pensando/Kconfig
index bd0583e409df..d25b88f53de4 100644
--- a/drivers/net/ethernet/pensando/Kconfig
+++ b/drivers/net/ethernet/pensando/Kconfig
@@ -20,6 +20,7 @@ if NET_VENDOR_PENSANDO
config IONIC
tristate "Pensando Ethernet IONIC Support"
depends on 64BIT && PCI
+ select NET_DEVLINK
help
This enables the support for the Pensando family of Ethernet
adapters. More specific information on this driver can be
--
2.20.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ionic: select CONFIG_NET_DEVLINK
2019-10-01 14:21 [PATCH] ionic: select CONFIG_NET_DEVLINK Arnd Bergmann
@ 2019-10-01 16:01 ` Shannon Nelson
2019-10-01 16:24 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Shannon Nelson @ 2019-10-01 16:01 UTC (permalink / raw)
To: Arnd Bergmann, Pensando Drivers, David S. Miller
Cc: Krzysztof Kozlowski, Leon Romanovsky, Kalle Valo, netdev, linux-kernel
On 10/1/19 7:21 AM, Arnd Bergmann wrote:
> When no other driver selects the devlink library code, ionic
> produces a link failure:
>
> drivers/net/ethernet/pensando/ionic/ionic_devlink.o: In function `ionic_devlink_alloc':
> ionic_devlink.c:(.text+0xd): undefined reference to `devlink_alloc'
> drivers/net/ethernet/pensando/ionic/ionic_devlink.o: In function `ionic_devlink_register':
> ionic_devlink.c:(.text+0x71): undefined reference to `devlink_register'
>
> Add the same 'select' statement that the other drivers use here.
>
> Fixes: fbfb8031533c ("ionic: Add hardware init and device commands")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/ethernet/pensando/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/pensando/Kconfig b/drivers/net/ethernet/pensando/Kconfig
> index bd0583e409df..d25b88f53de4 100644
> --- a/drivers/net/ethernet/pensando/Kconfig
> +++ b/drivers/net/ethernet/pensando/Kconfig
> @@ -20,6 +20,7 @@ if NET_VENDOR_PENSANDO
> config IONIC
> tristate "Pensando Ethernet IONIC Support"
> depends on 64BIT && PCI
> + select NET_DEVLINK
> help
> This enables the support for the Pensando family of Ethernet
> adapters. More specific information on this driver can be
Thanks!
Acked-by: Shannon Nelson <snelson@pensando.io>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ionic: select CONFIG_NET_DEVLINK
2019-10-01 14:21 [PATCH] ionic: select CONFIG_NET_DEVLINK Arnd Bergmann
2019-10-01 16:01 ` Shannon Nelson
@ 2019-10-01 16:24 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-10-01 16:24 UTC (permalink / raw)
To: arnd; +Cc: snelson, drivers, krzk, leon, kvalo, netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 1 Oct 2019 16:21:40 +0200
> When no other driver selects the devlink library code, ionic
> produces a link failure:
>
> drivers/net/ethernet/pensando/ionic/ionic_devlink.o: In function `ionic_devlink_alloc':
> ionic_devlink.c:(.text+0xd): undefined reference to `devlink_alloc'
> drivers/net/ethernet/pensando/ionic/ionic_devlink.o: In function `ionic_devlink_register':
> ionic_devlink.c:(.text+0x71): undefined reference to `devlink_register'
>
> Add the same 'select' statement that the other drivers use here.
>
> Fixes: fbfb8031533c ("ionic: Add hardware init and device commands")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-01 16:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-01 14:21 [PATCH] ionic: select CONFIG_NET_DEVLINK Arnd Bergmann
2019-10-01 16:01 ` Shannon Nelson
2019-10-01 16:24 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).