From: Stephen Hemminger <stephen@networkplumber.org>
To: Roopa Prabhu <roopa@cumulusnetworks.com>
Cc: dsahern@gmail.com, netdev@vger.kernel.org, ivecera@redhat.com,
nikolay@cumulusnetworks.com
Subject: Re: [PATCH iproute2 net-next v3 1/2] bridge: fdb get support
Date: Tue, 1 Oct 2019 07:59:28 -0700 [thread overview]
Message-ID: <20191001075928.26f1dd43@hermes.lan> (raw)
In-Reply-To: <1569905543-33478-2-git-send-email-roopa@cumulusnetworks.com>
On Mon, 30 Sep 2019 21:52:22 -0700
Roopa Prabhu <roopa@cumulusnetworks.com> wrote:
> +
> + if (sscanf(addr, "%hhx:%hhx:%hhx:%hhx:%hhx:%hhx",
> + abuf, abuf+1, abuf+2,
> + abuf+3, abuf+4, abuf+5) != 6) {
> + fprintf(stderr, "Invalid mac address %s\n", addr);
> + return -1;
> + }
You could use ether_aton here if that would help.
Not required, but ether_ntoa already used in iplink_bridge.c
next prev parent reply other threads:[~2019-10-01 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 4:52 [PATCH iproute2 net-next v3 0/2] support for bridge fdb and neigh get Roopa Prabhu
2019-10-01 4:52 ` [PATCH iproute2 net-next v3 1/2] bridge: fdb get support Roopa Prabhu
2019-10-01 14:59 ` Stephen Hemminger [this message]
2019-10-02 16:07 ` Roopa Prabhu
2019-10-01 4:52 ` [PATCH iproute2 net-next v3 2/2] ipneigh: neigh " Roopa Prabhu
2019-10-01 15:30 ` [PATCH iproute2 net-next v3 0/2] support for bridge fdb and neigh get David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001075928.26f1dd43@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=ivecera@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).