From: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
To: Jeroen Hofstee <jhofstee@victronenergy.com>
Cc: "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] can: D_CAN: perform a sofware reset on open
Date: Tue, 1 Oct 2019 15:39:56 +0200 [thread overview]
Message-ID: <20191001133956.GB32369@x1.vandijck-laurijssen.be> (raw)
In-Reply-To: <20190926085005.24805-2-jhofstee@victronenergy.com>
On do, 26 sep 2019 08:50:44 +0000, Jeroen Hofstee wrote:
> When the C_CAN interface is closed it is put in power down mode, but
> does not reset the error counters / state. So reset the D_CAN on open,
> so the reported state and the actual state match.
>
> According to [1], the C_CAN module doesn't have the software reset.
>
> [1] http://www.bosch-semiconductors.com/media/ip_modules/pdf_2/c_can_fd8/users_manual_c_can_fd8_r210_1.pdf
>
> Signed-off-by: Jeroen Hofstee <jhofstee@victronenergy.com>
I observed no problems after applying the patch.
Tested-by: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
next prev parent reply other threads:[~2019-10-01 13:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190926085005.24805-1-jhofstee@victronenergy.com>
2019-09-26 8:50 ` [PATCH 1/2] can: D_CAN: perform a sofware reset on open Jeroen Hofstee
2019-10-01 13:39 ` Kurt Van Dijck [this message]
2019-10-01 14:32 ` Marc Kleine-Budde
2019-10-01 21:17 ` Jeroen Hofstee
2019-09-26 8:50 ` [PATCH 2/2] can: C_CAN: add bus recovery events Jeroen Hofstee
2019-10-01 7:40 ` Kurt Van Dijck
2019-10-01 13:37 ` Kurt Van Dijck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001133956.GB32369@x1.vandijck-laurijssen.be \
--to=dev.kurt@vandijck-laurijssen.be \
--cc=davem@davemloft.net \
--cc=jhofstee@victronenergy.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).