netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next v2] net/rds: Log vendor error if send/recv Work requests fail
@ 2019-10-01 23:33 Sudhakar Dindukurti
  2019-10-02 23:26 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Sudhakar Dindukurti @ 2019-10-01 23:33 UTC (permalink / raw)
  To: netdev, davem, santosh.shilimkar, rds-devel; +Cc: Sudhakar Dindukurti

Log vendor error if work requests fail. Vendor error provides
more information that is used for debugging the issue.

Signed-off-by: Sudhakar Dindukurti <sudhakar.dindukurti@oracle.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>

---
 net/rds/ib_recv.c | 5 +++--
 net/rds/ib_send.c | 4 ++--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/net/rds/ib_recv.c b/net/rds/ib_recv.c
index 3cae88c..e668bac 100644
--- a/net/rds/ib_recv.c
+++ b/net/rds/ib_recv.c
@@ -983,10 +983,11 @@ void rds_ib_recv_cqe_handler(struct rds_ib_connection *ic,
 	} else {
 		/* We expect errors as the qp is drained during shutdown */
 		if (rds_conn_up(conn) || rds_conn_connecting(conn))
-			rds_ib_conn_error(conn, "recv completion on <%pI6c,%pI6c, %d> had status %u (%s), disconnecting and reconnecting\n",
+			rds_ib_conn_error(conn, "recv completion on <%pI6c,%pI6c, %d> had status %u (%s), vendor err 0x%x, disconnecting and reconnecting\n",
 					  &conn->c_laddr, &conn->c_faddr,
 					  conn->c_tos, wc->status,
-					  ib_wc_status_msg(wc->status));
+					  ib_wc_status_msg(wc->status),
+					  wc->vendor_err);
 	}
 
 	/* rds_ib_process_recv() doesn't always consume the frag, and
diff --git a/net/rds/ib_send.c b/net/rds/ib_send.c
index dfe6237..102c5c5 100644
--- a/net/rds/ib_send.c
+++ b/net/rds/ib_send.c
@@ -300,10 +300,10 @@ void rds_ib_send_cqe_handler(struct rds_ib_connection *ic, struct ib_wc *wc)
 
 	/* We expect errors as the qp is drained during shutdown */
 	if (wc->status != IB_WC_SUCCESS && rds_conn_up(conn)) {
-		rds_ib_conn_error(conn, "send completion on <%pI6c,%pI6c,%d> had status %u (%s), disconnecting and reconnecting\n",
+		rds_ib_conn_error(conn, "send completion on <%pI6c,%pI6c,%d> had status %u (%s), vendor err 0x%x, disconnecting and reconnecting\n",
 				  &conn->c_laddr, &conn->c_faddr,
 				  conn->c_tos, wc->status,
-				  ib_wc_status_msg(wc->status));
+				  ib_wc_status_msg(wc->status), wc->vendor_err);
 	}
 }
 
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next v2] net/rds: Log vendor error if send/recv Work requests fail
  2019-10-01 23:33 [PATCH net-next v2] net/rds: Log vendor error if send/recv Work requests fail Sudhakar Dindukurti
@ 2019-10-02 23:26 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-10-02 23:26 UTC (permalink / raw)
  To: sudhakar.dindukurti; +Cc: netdev, santosh.shilimkar, rds-devel

From: Sudhakar Dindukurti <sudhakar.dindukurti@oracle.com>
Date: Tue,  1 Oct 2019 16:33:14 -0700

> Log vendor error if work requests fail. Vendor error provides
> more information that is used for debugging the issue.
> 
> Signed-off-by: Sudhakar Dindukurti <sudhakar.dindukurti@oracle.com>
> Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-10-02 23:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-01 23:33 [PATCH net-next v2] net/rds: Log vendor error if send/recv Work requests fail Sudhakar Dindukurti
2019-10-02 23:26 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).