* [PATCH 0/6] rtlwifi: Remove a bunch of set but not used variables
@ 2019-09-30 8:54 zhengbin
2019-09-30 8:54 ` [PATCH 1/6] rtlwifi: Remove set but not used variable 'rtstate' zhengbin
` (5 more replies)
0 siblings, 6 replies; 10+ messages in thread
From: zhengbin @ 2019-09-30 8:54 UTC (permalink / raw)
To: pkshih, kvalo, davem, linux-wireless, netdev; +Cc: zhengbin13
zhengbin (6):
rtlwifi: Remove set but not used variable 'rtstate'
rtlwifi: Remove set but not used variables 'dataempty','hoffset'
rtlwifi: rtl8192ee: Remove set but not used variable 'err'
rtlwifi: rtl8192ee: Remove set but not used variables
'short_gi','buf_len'
rtlwifi: rtl8192ee: Remove set but not used variables
'reg_ecc','reg_eac'
rtlwifi: rtl8723be: Remove set but not used variables
'reg_ecc','reg_eac'
drivers/net/wireless/realtek/rtlwifi/efuse.c | 6 ++----
drivers/net/wireless/realtek/rtlwifi/ps.c | 3 ---
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c | 3 +--
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c | 8 ++------
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c | 8 --------
drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c | 8 ++------
6 files changed, 7 insertions(+), 29 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/6] rtlwifi: Remove set but not used variable 'rtstate'
2019-09-30 8:54 [PATCH 0/6] rtlwifi: Remove a bunch of set but not used variables zhengbin
@ 2019-09-30 8:54 ` zhengbin
2019-10-02 4:33 ` Kalle Valo
2019-09-30 8:54 ` [PATCH 2/6] rtlwifi: Remove set but not used variables 'dataempty','hoffset' zhengbin
` (4 subsequent siblings)
5 siblings, 1 reply; 10+ messages in thread
From: zhengbin @ 2019-09-30 8:54 UTC (permalink / raw)
To: pkshih, kvalo, davem, linux-wireless, netdev; +Cc: zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/realtek/rtlwifi/ps.c: In function rtl_ps_set_rf_state:
drivers/net/wireless/realtek/rtlwifi/ps.c:71:19: warning: variable rtstate set but not used [-Wunused-but-set-variable]
It is not used since commit f1d2b4d338bf ("rtlwifi:
rtl818x: Move drivers into new realtek directory")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/net/wireless/realtek/rtlwifi/ps.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/ps.c b/drivers/net/wireless/realtek/rtlwifi/ps.c
index 70f04c2..e13913a 100644
--- a/drivers/net/wireless/realtek/rtlwifi/ps.c
+++ b/drivers/net/wireless/realtek/rtlwifi/ps.c
@@ -68,7 +68,6 @@ static bool rtl_ps_set_rf_state(struct ieee80211_hw *hw,
{
struct rtl_priv *rtlpriv = rtl_priv(hw);
struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
- enum rf_pwrstate rtstate;
bool actionallowed = false;
u16 rfwait_cnt = 0;
@@ -102,8 +101,6 @@ static bool rtl_ps_set_rf_state(struct ieee80211_hw *hw,
}
}
- rtstate = ppsc->rfpwr_state;
-
switch (state_toset) {
case ERFON:
ppsc->rfoff_reason &= (~changesource);
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/6] rtlwifi: Remove set but not used variables 'dataempty','hoffset'
2019-09-30 8:54 [PATCH 0/6] rtlwifi: Remove a bunch of set but not used variables zhengbin
2019-09-30 8:54 ` [PATCH 1/6] rtlwifi: Remove set but not used variable 'rtstate' zhengbin
@ 2019-09-30 8:54 ` zhengbin
2019-09-30 8:54 ` [PATCH 3/6] rtlwifi: rtl8192ee: Remove set but not used variable 'err' zhengbin
` (3 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: zhengbin @ 2019-09-30 8:54 UTC (permalink / raw)
To: pkshih, kvalo, davem, linux-wireless, netdev; +Cc: zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/realtek/rtlwifi/efuse.c: In function efuse_pg_packet_write:
drivers/net/wireless/realtek/rtlwifi/efuse.c:937:24: warning: variable dataempty set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtlwifi/efuse.c: In function efuse_get_current_size:
drivers/net/wireless/realtek/rtlwifi/efuse.c:1202:5: warning: variable hoffset set but not used [-Wunused-but-set-variable]
They are not used since commit f1d2b4d338bf ("rtlwifi:
rtl818x: Move drivers into new realtek directory")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/net/wireless/realtek/rtlwifi/efuse.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/efuse.c b/drivers/net/wireless/realtek/rtlwifi/efuse.c
index 2646672..cef9f2a 100644
--- a/drivers/net/wireless/realtek/rtlwifi/efuse.c
+++ b/drivers/net/wireless/realtek/rtlwifi/efuse.c
@@ -915,7 +915,7 @@ static int efuse_pg_packet_write(struct ieee80211_hw *hw,
struct rtl_priv *rtlpriv = rtl_priv(hw);
struct pgpkt_struct target_pkt;
u8 write_state = PG_STATE_HEADER;
- int continual = true, dataempty = true, result = true;
+ int continual = true, result = true;
u16 efuse_addr = 0;
u8 efuse_data;
u8 target_word_cnts = 0;
@@ -942,7 +942,6 @@ static int efuse_pg_packet_write(struct ieee80211_hw *hw,
while (continual && (efuse_addr < (EFUSE_MAX_SIZE -
rtlpriv->cfg->maps[EFUSE_OOB_PROTECT_BYTES_LEN]))) {
if (write_state == PG_STATE_HEADER) {
- dataempty = true;
badworden = 0x0F;
RTPRINT(rtlpriv, FEEPROM, EFUSE_PG,
"efuse PG_STATE_HEADER\n");
@@ -1179,13 +1178,12 @@ static u16 efuse_get_current_size(struct ieee80211_hw *hw)
{
int continual = true;
u16 efuse_addr = 0;
- u8 hoffset, hworden;
+ u8 hworden;
u8 efuse_data, word_cnts;
while (continual && efuse_one_byte_read(hw, efuse_addr, &efuse_data) &&
(efuse_addr < EFUSE_MAX_SIZE)) {
if (efuse_data != 0xFF) {
- hoffset = (efuse_data >> 4) & 0x0F;
hworden = efuse_data & 0x0F;
word_cnts = efuse_calculate_word_cnts(hworden);
efuse_addr = efuse_addr + (word_cnts * 2) + 1;
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/6] rtlwifi: rtl8192ee: Remove set but not used variable 'err'
2019-09-30 8:54 [PATCH 0/6] rtlwifi: Remove a bunch of set but not used variables zhengbin
2019-09-30 8:54 ` [PATCH 1/6] rtlwifi: Remove set but not used variable 'rtstate' zhengbin
2019-09-30 8:54 ` [PATCH 2/6] rtlwifi: Remove set but not used variables 'dataempty','hoffset' zhengbin
@ 2019-09-30 8:54 ` zhengbin
2019-10-01 9:38 ` Pkshih
2019-10-02 4:26 ` Kalle Valo
2019-09-30 8:54 ` [PATCH 4/6] rtlwifi: rtl8192ee: Remove set but not used variables 'short_gi','buf_len' zhengbin
` (2 subsequent siblings)
5 siblings, 2 replies; 10+ messages in thread
From: zhengbin @ 2019-09-30 8:54 UTC (permalink / raw)
To: pkshih, kvalo, davem, linux-wireless, netdev; +Cc: zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c: In function rtl92ee_download_fw:
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c:111:6: warning: variable err set but not used [-Wunused-but-set-variable]
It is not used since commit c93ac39da006 ("rtlwifi:
Remove some redundant code")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c
index 67305ce..322798c 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c
@@ -108,7 +108,6 @@ int rtl92ee_download_fw(struct ieee80211_hw *hw, bool buse_wake_on_wlan_fw)
struct rtlwifi_firmware_header *pfwheader;
u8 *pfwdata;
u32 fwsize;
- int err;
enum version_8192e version = rtlhal->version;
if (!rtlhal->pfirmware)
@@ -146,7 +145,7 @@ int rtl92ee_download_fw(struct ieee80211_hw *hw, bool buse_wake_on_wlan_fw)
_rtl92ee_write_fw(hw, version, pfwdata, fwsize);
_rtl92ee_enable_fw_download(hw, false);
- err = _rtl92ee_fw_free_to_go(hw);
+ (void)_rtl92ee_fw_free_to_go(hw);
return 0;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 4/6] rtlwifi: rtl8192ee: Remove set but not used variables 'short_gi','buf_len'
2019-09-30 8:54 [PATCH 0/6] rtlwifi: Remove a bunch of set but not used variables zhengbin
` (2 preceding siblings ...)
2019-09-30 8:54 ` [PATCH 3/6] rtlwifi: rtl8192ee: Remove set but not used variable 'err' zhengbin
@ 2019-09-30 8:54 ` zhengbin
2019-09-30 8:54 ` [PATCH 5/6] rtlwifi: rtl8192ee: Remove set but not used variables 'reg_ecc','reg_eac' zhengbin
2019-09-30 8:54 ` [PATCH 6/6] rtlwifi: rtl8723be: " zhengbin
5 siblings, 0 replies; 10+ messages in thread
From: zhengbin @ 2019-09-30 8:54 UTC (permalink / raw)
To: pkshih, kvalo, davem, linux-wireless, netdev; +Cc: zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c: In function rtl92ee_tx_fill_desc:
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c:656:5: warning: variable short_gi set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c: In function rtl92ee_tx_fill_desc:
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c:648:15: warning: variable buf_len set but not used [-Wunused-but-set-variable]
They are not used since commit f1d2b4d338bf ("rtlwifi:
rtl818x: Move drivers into new realtek directory")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
index 27f1a63..36a8a51 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c
@@ -651,7 +651,6 @@ void rtl92ee_tx_fill_desc(struct ieee80211_hw *hw,
struct rtlwifi_tx_info *tx_info = rtl_tx_skb_cb_info(skb);
u16 seq_number;
__le16 fc = hdr->frame_control;
- unsigned int buf_len;
u8 fw_qsel = _rtl92ee_map_hwqueue_to_fwqueue(skb, hw_queue);
bool firstseg = ((hdr->seq_ctrl &
cpu_to_le16(IEEE80211_SCTL_FRAG)) == 0);
@@ -659,7 +658,6 @@ void rtl92ee_tx_fill_desc(struct ieee80211_hw *hw,
cpu_to_le16(IEEE80211_FCTL_MOREFRAGS)) == 0);
dma_addr_t mapping;
u8 bw_40 = 0;
- u8 short_gi;
__le32 *pdesc = (__le32 *)pdesc8;
if (mac->opmode == NL80211_IFTYPE_STATION) {
@@ -677,7 +675,6 @@ void rtl92ee_tx_fill_desc(struct ieee80211_hw *hw,
skb_push(skb, EM_HDR_LEN);
memset(skb->data, 0, EM_HDR_LEN);
}
- buf_len = skb->len;
mapping = pci_map_single(rtlpci->pdev, skb->data, skb->len,
PCI_DMA_TODEVICE);
if (pci_dma_mapping_error(rtlpci->pdev, mapping)) {
@@ -724,11 +721,6 @@ void rtl92ee_tx_fill_desc(struct ieee80211_hw *hw,
}
}
- if (ptcb_desc->hw_rate > DESC_RATEMCS0)
- short_gi = (ptcb_desc->use_shortgi) ? 1 : 0;
- else
- short_gi = (ptcb_desc->use_shortpreamble) ? 1 : 0;
-
if (info->flags & IEEE80211_TX_CTL_AMPDU) {
set_tx_desc_agg_enable(pdesc, 1);
set_tx_desc_max_agg_num(pdesc, 0x14);
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 5/6] rtlwifi: rtl8192ee: Remove set but not used variables 'reg_ecc','reg_eac'
2019-09-30 8:54 [PATCH 0/6] rtlwifi: Remove a bunch of set but not used variables zhengbin
` (3 preceding siblings ...)
2019-09-30 8:54 ` [PATCH 4/6] rtlwifi: rtl8192ee: Remove set but not used variables 'short_gi','buf_len' zhengbin
@ 2019-09-30 8:54 ` zhengbin
2019-09-30 8:54 ` [PATCH 6/6] rtlwifi: rtl8723be: " zhengbin
5 siblings, 0 replies; 10+ messages in thread
From: zhengbin @ 2019-09-30 8:54 UTC (permalink / raw)
To: pkshih, kvalo, davem, linux-wireless, netdev; +Cc: zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c: In function rtl92ee_phy_iq_calibrate:
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c:2805:34: warning: variable reg_ecc set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c: In function rtl92ee_phy_iq_calibrate:
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c:2804:34: warning: variable reg_eac set but not used [-Wunused-but-set-variable]
They are not used since commit b1a3bfc97cd9 ("rtlwifi:
rtl8192ee: Move driver from staging to the regular tree")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c
index 222abc4..f03de8b 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c
@@ -2801,8 +2801,8 @@ void rtl92ee_phy_iq_calibrate(struct ieee80211_hw *hw, bool b_recovery)
long result[4][8];
u8 i, final_candidate;
bool b_patha_ok, b_pathb_ok;
- long reg_e94, reg_e9c, reg_ea4, reg_eac;
- long reg_eb4, reg_ebc, reg_ec4, reg_ecc;
+ long reg_e94, reg_e9c, reg_ea4;
+ long reg_eb4, reg_ebc, reg_ec4;
bool is12simular, is13simular, is23simular;
u8 idx;
u32 iqk_bb_reg[IQK_BB_REG_NUM] = {
@@ -2873,11 +2873,9 @@ void rtl92ee_phy_iq_calibrate(struct ieee80211_hw *hw, bool b_recovery)
reg_e94 = result[i][0];
reg_e9c = result[i][1];
reg_ea4 = result[i][2];
- reg_eac = result[i][3];
reg_eb4 = result[i][4];
reg_ebc = result[i][5];
reg_ec4 = result[i][6];
- reg_ecc = result[i][7];
}
if (final_candidate != 0xff) {
@@ -2886,13 +2884,11 @@ void rtl92ee_phy_iq_calibrate(struct ieee80211_hw *hw, bool b_recovery)
reg_e9c = result[final_candidate][1];
rtlphy->reg_e9c = reg_e9c;
reg_ea4 = result[final_candidate][2];
- reg_eac = result[final_candidate][3];
reg_eb4 = result[final_candidate][4];
rtlphy->reg_eb4 = reg_eb4;
reg_ebc = result[final_candidate][5];
rtlphy->reg_ebc = reg_ebc;
reg_ec4 = result[final_candidate][6];
- reg_ecc = result[final_candidate][7];
b_patha_ok = true;
b_pathb_ok = true;
} else {
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 6/6] rtlwifi: rtl8723be: Remove set but not used variables 'reg_ecc','reg_eac'
2019-09-30 8:54 [PATCH 0/6] rtlwifi: Remove a bunch of set but not used variables zhengbin
` (4 preceding siblings ...)
2019-09-30 8:54 ` [PATCH 5/6] rtlwifi: rtl8192ee: Remove set but not used variables 'reg_ecc','reg_eac' zhengbin
@ 2019-09-30 8:54 ` zhengbin
5 siblings, 0 replies; 10+ messages in thread
From: zhengbin @ 2019-09-30 8:54 UTC (permalink / raw)
To: pkshih, kvalo, davem, linux-wireless, netdev; +Cc: zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c: In function rtl8723be_phy_iq_calibrate:
drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c:2255:7: warning: variable reg_ecc set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c: In function rtl8723be_phy_iq_calibrate:
drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c:2254:34: warning: variable reg_eac set but not used [-Wunused-but-set-variable]
They are not used since commit a619d1abe20c ("rtlwifi:
rtl8723be: Add new driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c
index aa8a095..d483644 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c
@@ -2251,8 +2251,8 @@ void rtl8723be_phy_iq_calibrate(struct ieee80211_hw *hw, bool b_recovery)
long result[4][8];
u8 i, final_candidate, idx;
bool b_patha_ok, b_pathb_ok;
- long reg_e94, reg_e9c, reg_ea4, reg_eac, reg_eb4, reg_ebc, reg_ec4;
- long reg_ecc, reg_tmp = 0;
+ long reg_e94, reg_e9c, reg_ea4, reg_eb4, reg_ebc, reg_ec4;
+ long reg_tmp = 0;
bool is12simular, is13simular, is23simular;
u32 iqk_bb_reg[9] = {
ROFDM0_XARXIQIMBALANCE,
@@ -2334,11 +2334,9 @@ void rtl8723be_phy_iq_calibrate(struct ieee80211_hw *hw, bool b_recovery)
reg_e94 = result[i][0];
reg_e9c = result[i][1];
reg_ea4 = result[i][2];
- reg_eac = result[i][3];
reg_eb4 = result[i][4];
reg_ebc = result[i][5];
reg_ec4 = result[i][6];
- reg_ecc = result[i][7];
}
if (final_candidate != 0xff) {
reg_e94 = result[final_candidate][0];
@@ -2346,13 +2344,11 @@ void rtl8723be_phy_iq_calibrate(struct ieee80211_hw *hw, bool b_recovery)
reg_e9c = result[final_candidate][1];
rtlphy->reg_e9c = reg_e9c;
reg_ea4 = result[final_candidate][2];
- reg_eac = result[final_candidate][3];
reg_eb4 = result[final_candidate][4];
rtlphy->reg_eb4 = reg_eb4;
reg_ebc = result[final_candidate][5];
rtlphy->reg_ebc = reg_ebc;
reg_ec4 = result[final_candidate][6];
- reg_ecc = result[final_candidate][7];
b_patha_ok = true;
b_pathb_ok = true;
} else {
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* RE: [PATCH 3/6] rtlwifi: rtl8192ee: Remove set but not used variable 'err'
2019-09-30 8:54 ` [PATCH 3/6] rtlwifi: rtl8192ee: Remove set but not used variable 'err' zhengbin
@ 2019-10-01 9:38 ` Pkshih
2019-10-02 4:26 ` Kalle Valo
1 sibling, 0 replies; 10+ messages in thread
From: Pkshih @ 2019-10-01 9:38 UTC (permalink / raw)
To: zhengbin, kvalo, davem, linux-wireless, netdev
> -----Original Message-----
> From: linux-wireless-owner@vger.kernel.org [mailto:linux-wireless-owner@vger.kernel.org] On Behalf
> Of zhengbin
> Sent: Monday, September 30, 2019 4:55 PM
> To: Pkshih; kvalo@codeaurora.org; davem@davemloft.net; linux-wireless@vger.kernel.org;
> netdev@vger.kernel.org
> Cc: zhengbin13@huawei.com
> Subject: [PATCH 3/6] rtlwifi: rtl8192ee: Remove set but not used variable 'err'
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c: In function rtl92ee_download_fw:
> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c:111:6: warning: variable err set but not used
> [-Wunused-but-set-variable]
>
> It is not used since commit c93ac39da006 ("rtlwifi:
> Remove some redundant code")
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c
> index 67305ce..322798c 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c
> @@ -108,7 +108,6 @@ int rtl92ee_download_fw(struct ieee80211_hw *hw, bool buse_wake_on_wlan_fw)
> struct rtlwifi_firmware_header *pfwheader;
> u8 *pfwdata;
> u32 fwsize;
> - int err;
> enum version_8192e version = rtlhal->version;
>
> if (!rtlhal->pfirmware)
> @@ -146,7 +145,7 @@ int rtl92ee_download_fw(struct ieee80211_hw *hw, bool buse_wake_on_wlan_fw)
> _rtl92ee_write_fw(hw, version, pfwdata, fwsize);
> _rtl92ee_enable_fw_download(hw, false);
>
> - err = _rtl92ee_fw_free_to_go(hw);
> + (void)_rtl92ee_fw_free_to_go(hw);
>
> return 0;
After checking the flow, it's ok 'return _rtl92ee_fw_free_to_go(hw);'.
> }
> --
> 2.7.4
>
>
> ------Please consider the environment before printing this e-mail.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 3/6] rtlwifi: rtl8192ee: Remove set but not used variable 'err'
2019-09-30 8:54 ` [PATCH 3/6] rtlwifi: rtl8192ee: Remove set but not used variable 'err' zhengbin
2019-10-01 9:38 ` Pkshih
@ 2019-10-02 4:26 ` Kalle Valo
1 sibling, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2019-10-02 4:26 UTC (permalink / raw)
To: zhengbin; +Cc: pkshih, davem, linux-wireless, netdev, zhengbin13
zhengbin <zhengbin13@huawei.com> wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c: In function rtl92ee_download_fw:
> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c:111:6: warning: variable err set but not used [-Wunused-but-set-variable]
>
> It is not used since commit c93ac39da006 ("rtlwifi:
> Remove some redundant code")
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
Dropping this patch per Ping's comment, please fix and resend this
patch.
Patch set to Changes Requested.
--
https://patchwork.kernel.org/patch/11166207/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/6] rtlwifi: Remove set but not used variable 'rtstate'
2019-09-30 8:54 ` [PATCH 1/6] rtlwifi: Remove set but not used variable 'rtstate' zhengbin
@ 2019-10-02 4:33 ` Kalle Valo
0 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2019-10-02 4:33 UTC (permalink / raw)
To: zhengbin; +Cc: pkshih, davem, linux-wireless, netdev, zhengbin13
zhengbin <zhengbin13@huawei.com> wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/realtek/rtlwifi/ps.c: In function rtl_ps_set_rf_state:
> drivers/net/wireless/realtek/rtlwifi/ps.c:71:19: warning: variable rtstate set but not used [-Wunused-but-set-variable]
>
> It is not used since commit f1d2b4d338bf ("rtlwifi:
> rtl818x: Move drivers into new realtek directory")
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
5 patches applied to wireless-drivers-next.git, thanks.
4010758eb082 rtlwifi: Remove set but not used variable 'rtstate'
70906d941ccd rtlwifi: Remove set but not used variables 'dataempty','hoffset'
4a26e11500b8 rtlwifi: rtl8192ee: Remove set but not used variables 'short_gi','buf_len'
533e3de41205 rtlwifi: rtl8192ee: Remove set but not used variables 'reg_ecc','reg_eac'
66070e86878c rtlwifi: rtl8723be: Remove set but not used variables 'reg_ecc','reg_eac'
--
https://patchwork.kernel.org/patch/11166203/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-10-02 4:33 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-30 8:54 [PATCH 0/6] rtlwifi: Remove a bunch of set but not used variables zhengbin
2019-09-30 8:54 ` [PATCH 1/6] rtlwifi: Remove set but not used variable 'rtstate' zhengbin
2019-10-02 4:33 ` Kalle Valo
2019-09-30 8:54 ` [PATCH 2/6] rtlwifi: Remove set but not used variables 'dataempty','hoffset' zhengbin
2019-09-30 8:54 ` [PATCH 3/6] rtlwifi: rtl8192ee: Remove set but not used variable 'err' zhengbin
2019-10-01 9:38 ` Pkshih
2019-10-02 4:26 ` Kalle Valo
2019-09-30 8:54 ` [PATCH 4/6] rtlwifi: rtl8192ee: Remove set but not used variables 'short_gi','buf_len' zhengbin
2019-09-30 8:54 ` [PATCH 5/6] rtlwifi: rtl8192ee: Remove set but not used variables 'reg_ecc','reg_eac' zhengbin
2019-09-30 8:54 ` [PATCH 6/6] rtlwifi: rtl8723be: " zhengbin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).